github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-07 22:40:43 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: correct revision debouncer for backup draft

Browse Source 
We were debouncing on update_at which we kept on pushing forward, this
was leading to not enough revisions.
This commit is contained in:
Sam Saffron 2019-10-17 17:41:28 +11:00
parent 3314aa9f88
commit cb0443792b
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/draft.rb
View File

@ -137,7 +137,7 @@ class Draft < ActiveRecord::Base
).create ).create
BackupDraftPost.create!(user_id: user.id, key: key, post_id: post.id) BackupDraftPost.create!(user_id: user.id, key: key, post_id: post.id)
end end
elsif post.updated_at > 5.minutes.ago elsif post.last_version_at > 5.minutes.ago
# bypass all validations here to maximize speed # bypass all validations here to maximize speed
post.update_columns( post.update_columns(
raw: draft_body, raw: draft_body,

6
spec/models/draft_spec.rb
View File

@ -19,13 +19,17 @@ describe Draft do
Draft.set(user, "new_private_message", 0, draft.to_json) Draft.set(user, "new_private_message", 0, draft.to_json)
draft["reply"] = "test" * 100 draft["reply"] = "test" * 100
half_grace = (SiteSetting.editing_grace_period / 2 + 1).seconds
freeze_time half_grace.from_now
Draft.set(user, "new_private_message", 77, draft.to_json) Draft.set(user, "new_private_message", 77, draft.to_json)
draft_post = BackupDraftPost.find_by(user_id: user.id, key: "new_private_message").post draft_post = BackupDraftPost.find_by(user_id: user.id, key: "new_private_message").post
expect(draft_post.revisions.count).to eq(0) expect(draft_post.revisions.count).to eq(0)
freeze_time 10.minutes.from_now freeze_time half_grace.from_now
# this should trigger a post revision as 10 minutes have passed # this should trigger a post revision as 10 minutes have passed
draft["reply"] = "hello" draft["reply"] = "hello"