From cb592ae4ac177d1984a468ebcae8acf2fa460a23 Mon Sep 17 00:00:00 2001 From: Ted Johansson Date: Mon, 27 May 2024 11:10:46 +0800 Subject: [PATCH] DEV: Remove deprecated User#saw_notification_id method (#27175) --- app/models/user.rb | 12 ------------ plugins/discourse-narrative-bot/plugin.rb | 1 - 2 files changed, 13 deletions(-) diff --git a/app/models/user.rb b/app/models/user.rb index b588fc5c75b..9e1f1e502b9 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -788,18 +788,6 @@ class User < ActiveRecord::Base Reviewable.list_for(self, include_claimed_by_others: false).count end - def saw_notification_id(notification_id) - Discourse.deprecate(<<~TEXT, since: "2.9", drop_from: "3.0") - User#saw_notification_id is deprecated. Please use User#bump_last_seen_notification! instead. - TEXT - if seen_notification_id.to_i < notification_id.to_i - update_columns(seen_notification_id: notification_id.to_i) - true - else - false - end - end - def bump_last_seen_notification! query = self.notifications.visible query = query.where("notifications.id > ?", seen_notification_id) if seen_notification_id diff --git a/plugins/discourse-narrative-bot/plugin.rb b/plugins/discourse-narrative-bot/plugin.rb index 6e15b802081..fceda47e80b 100644 --- a/plugins/discourse-narrative-bot/plugin.rb +++ b/plugins/discourse-narrative-bot/plugin.rb @@ -114,7 +114,6 @@ after_initialize do notification = Notification.where(topic_id: topic.id, post_number: first_post.post_number).first if notification.present? Notification.read(self, notification.id) - self.saw_notification_id(notification.id) self.reload self.publish_notifications_state end