From ccca2dbfe048fd77bb2b94f59f493269cee68092 Mon Sep 17 00:00:00 2001 From: Natalie Tay Date: Tue, 2 May 2023 17:02:19 +0800 Subject: [PATCH] FIX: Quoted images should be lightboxed (#21332) An older change about optimising images caused the selector that adds lightboxing not to apply on quoted images. This fixes that. The selector is now not applicable as optimisation occurs in a separate place. This change allows quoted images to be opened in a lightbox. --- lib/cooked_post_processor.rb | 2 +- spec/lib/cooked_post_processor_spec.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/cooked_post_processor.rb b/lib/cooked_post_processor.rb index 0e6e15986e7..9550a83690a 100644 --- a/lib/cooked_post_processor.rb +++ b/lib/cooked_post_processor.rb @@ -209,7 +209,7 @@ class CookedPostProcessor return if upload.animated? - if img.ancestors(".onebox, .onebox-body, .quote").blank? && !img.classes.include?("onebox") + if img.ancestors(".onebox, .onebox-body").blank? && !img.classes.include?("onebox") add_lightbox!(img, original_width, original_height, upload, cropped: crop) end diff --git a/spec/lib/cooked_post_processor_spec.rb b/spec/lib/cooked_post_processor_spec.rb index df42d360cb8..02a8b90f9cd 100644 --- a/spec/lib/cooked_post_processor_spec.rb +++ b/spec/lib/cooked_post_processor_spec.rb @@ -1012,7 +1012,7 @@ RSpec.describe CookedPostProcessor do end end - it "optimizes images in quotes" do + it "optimizes and wraps images in quotes with lightbox wrapper" do post = Fabricate(:post, raw: <<~MD) [quote] ![image|1024x768, 50%](#{large_image_upload.short_url}) @@ -1023,7 +1023,7 @@ RSpec.describe CookedPostProcessor do cpp.post_process doc = Nokogiri::HTML5.fragment(cpp.html) - expect(doc.css(".lightbox-wrapper").size).to eq(0) + expect(doc.css(".lightbox-wrapper").size).to eq(1) expect(doc.css("img").first["srcset"]).to_not eq(nil) end