github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 02:19:27 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Avoid creating the same object repeatedly.

Browse Source 
Less objects created per request means less objects for the GC to
collect.
This commit is contained in:
Guo Xiang Tan 2020-09-11 15:51:11 +08:00
parent dbc630f45b
commit cd78bcee3a
No known key found for this signature in database
GPG Key ID: FBD110179AAC1F20
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/serializers/listable_topic_serializer.rb
View File

@ -35,12 +35,13 @@ class ListableTopicSerializer < BasicTopicSerializer
end
def thumbnails
extra_sizes = ThemeModifierHelper.new(request: scope.request).topic_thumbnail_sizes
extra_sizes = theme_modifier_helper.topic_thumbnail_sizes
object.thumbnail_info(enqueue_if_missing: true, extra_sizes: extra_sizes)
end
def include_thumbnails?
ThemeModifierHelper.new(request: scope.request).topic_thumbnail_sizes.present? || DiscoursePluginRegistry.topic_thumbnail_sizes.present?
theme_modifier_helper.topic_thumbnail_sizes.present? ||
DiscoursePluginRegistry.topic_thumbnail_sizes.present?
end
def include_unicode_title?
@ -125,7 +126,7 @@ class ListableTopicSerializer < BasicTopicSerializer
alias :include_new_posts? :has_user_data
def include_excerpt?
pinned || SiteSetting.always_include_topic_excerpts || ThemeModifierHelper.new(request: scope.request).serialize_topic_excerpts
pinned || SiteSetting.always_include_topic_excerpts || theme_modifier_helper.serialize_topic_excerpts
end
def pinned
@ -154,4 +155,10 @@ class ListableTopicSerializer < BasicTopicSerializer
@unread_helper ||= Unread.new(object, object.user_data, scope)
end
private
def theme_modifier_helper
@theme_modifier_helper ||= ThemeModifierHelper.new(request: scope.request)
end
end