mirror of
https://github.com/discourse/discourse.git
synced 2024-11-22 10:57:04 +08:00
Detect Googlebot from user agent and use a different layout that doesn't load javascript
This commit is contained in:
Neil Lalonde
parent
0c493c026e
commit
d298e2e065
|
|
@ -4,6 +4,7 @@ require_dependency 'discourse'
|
|||
require_dependency 'custom_renderer'
|
||||
require_dependency 'archetype'
|
||||
require_dependency 'rate_limiter'
|
||||
require_dependency 'googlebot_detection'
|
||||
|
||||
class ApplicationController < ActionController::Base
|
||||
include CurrentUser
|
||||
|
|
@ -36,6 +37,12 @@ class ApplicationController < ActionController::Base
|
|||
before_filter :check_xhr
|
||||
before_filter :redirect_to_login_if_required
|
||||
|
||||
layout :set_layout
|
||||
|
||||
def set_layout
|
||||
GooglebotDetection.googlebot?(request.user_agent) ? 'googlebot' : 'application'
|
||||
end
|
||||
|
||||
rescue_from Exception do |exception|
|
||||
unless [ActiveRecord::RecordNotFound,
|
||||
ActionController::RoutingError,
|
||||
|
|
|
|||
41
app/views/layouts/googlebot.html.erb
Normal file
41
app/views/layouts/googlebot.html.erb
Normal file
|
|
@ -0,0 +1,41 @@
|
|||
<!DOCTYPE html>
|
||||
<html lang="<%= SiteSetting.default_locale %>">
|
||||
<head>
|
||||
<meta charset="utf-8">
|
||||
<title><%= content_for?(:title) ? yield(:title) + ' - ' + SiteSetting.title : SiteSetting.title %></title>
|
||||
<meta content="width=device-width, initial-scale=1.0" name="viewport">
|
||||
<meta content="<%= SiteSetting.site_description %>" name="description">
|
||||
<meta content="" name="author">
|
||||
|
||||
<%= canonical_link_tag %>
|
||||
|
||||
<link rel="icon" type="image/png" href="<%=SiteSetting.favicon_url%>">
|
||||
<link rel="apple-touch-icon" type="image/png" href="<%=SiteSetting.apple_touch_icon_url%>">
|
||||
|
||||
<%= render :partial => "common/special_font_face" %>
|
||||
<%= render :partial => "common/discourse_stylesheet" %>
|
||||
<%= discourse_csrf_tags %>
|
||||
<%= raw SiteContent.content_for(:head) %>
|
||||
</head>
|
||||
<body>
|
||||
<%- unless customization_disabled? %>
|
||||
<%= SiteCustomization.custom_header(session[:preview_style]) %>
|
||||
<%- end %>
|
||||
<header class="d-header">
|
||||
<div class="container">
|
||||
<div class="contents">
|
||||
<div class="row">
|
||||
<div class="title span13">
|
||||
<a href="/"><img src="<%=SiteSetting.logo_url%>" alt="<%=SiteSetting.title%>" id="site-logo"></a>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</header>
|
||||
<div id="main-outlet" class="container">
|
||||
<!-- preload-content: -->
|
||||
<%= yield %>
|
||||
<!-- :preload-content -->
|
||||
</div>
|
||||
</body>
|
||||
</html>
|
||||
5
lib/googlebot_detection.rb
Normal file
5
lib/googlebot_detection.rb
Normal file
|
|
@ -0,0 +1,5 @@
|
|||
module GooglebotDetection
|
||||
def self.googlebot?(user_agent)
|
||||
!/Googlebot|Mediapartners|AdsBot/.match(user_agent).nil?
|
||||
end
|
||||
end
|
||||
|
|
@ -1,6 +1,5 @@
|
|||
module MobileDetection
|
||||
def self.mobile_device?(user_agent)
|
||||
# TODO: this is dumb. user agent matching is a doomed approach. a better solution is coming.
|
||||
user_agent =~ /Mobile|webOS|Nexus 7/ && !(user_agent =~ /iPad/)
|
||||
end
|
||||
|
||||
|
|
|
|||
30
spec/components/googlebot_detection_spec.rb
Normal file
30
spec/components/googlebot_detection_spec.rb
Normal file
|
|
@ -0,0 +1,30 @@
|
|||
require 'spec_helper'
|
||||
require_dependency 'googlebot_detection'
|
||||
|
||||
describe GooglebotDetection do
|
||||
describe "googlebot?" do
|
||||
it "returns true for googlebot user agents" do
|
||||
# https://support.google.com/webmasters/answer/1061943?hl=en
|
||||
described_class.googlebot?("Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)").should == true
|
||||
described_class.googlebot?("Googlebot/2.1 (+http://www.google.com/bot.html)").should == true
|
||||
described_class.googlebot?("Googlebot-News").should == true
|
||||
described_class.googlebot?("Googlebot-Image/1.0").should == true
|
||||
described_class.googlebot?("Googlebot-Video/1.0").should == true
|
||||
described_class.googlebot?("(compatible; Googlebot-Mobile/2.1; +http://www.google.com/bot.html)").should == true
|
||||
described_class.googlebot?("Mozilla/5.0 (iPhone; CPU iPhone OS 6_0 like Mac OS X) AppleWebKit/536.26 (KHTML, like Gecko) Version/6.0 Mobile/10A5376e Safari/8536.25 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)").should == true
|
||||
described_class.googlebot?("(compatible; Mediapartners-Google/2.1; +http://www.google.com/bot.html)").should == true
|
||||
described_class.googlebot?("Mediapartners-Google").should == true
|
||||
described_class.googlebot?("AdsBot-Google (+http://www.google.com/adsbot.html)").should == true
|
||||
end
|
||||
|
||||
it "returns false for non-googlebot user agents" do
|
||||
described_class.googlebot?("Mozilla/5.0 (Windows NT 6.2; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1667.0 Safari/537.36").should == false
|
||||
described_class.googlebot?("Mozilla/5.0 (Windows NT 6.3; Trident/7.0; rv:11.0) like Gecko").should == false
|
||||
described_class.googlebot?("Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.2; Trident/6.0)").should == false
|
||||
described_class.googlebot?("Mozilla/5.0 (iPad; CPU OS 6_0 like Mac OS X) AppleWebKit/536.26 (KHTML, like Gecko) Version/6.0 Mobile/10A5355d Safari/8536.25").should == false
|
||||
described_class.googlebot?("Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:25.0) Gecko/20100101 Firefox/25.0").should == false
|
||||
described_class.googlebot?("Mozilla/5.0 (Linux; U; Android 4.0.3; ko-kr; LG-L160L Build/IML74K) AppleWebkit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30").should == false
|
||||
end
|
||||
|
||||
end
|
||||
end
|
||||
Loading…
Reference in New Issue
Block a user