github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-23 07:00:56 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: prevents click on sk header to bubble (#9084)

Browse Source
This commit is contained in:
Joffrey JAFFEUX 2020-03-02 20:06:02 +01:00 committed by Neil Lalonde
parent 55a49d8494
commit d5ab4776cd
No known key found for this signature in database
GPG Key ID: FF871CA9037D0A91
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/assets/javascripts/select-kit/components/select-kit/select-kit-header.js.es6
View File

@ -13,6 +13,7 @@ export default Component.extend(UtilsMixin, {
return; return;
if (this.eventType !== "click" || event.button !== 0) return; if (this.eventType !== "click" || event.button !== 0) return;
this.selectKit.toggle(event); this.selectKit.toggle(event);
return false;
}, },
classNames: ["select-kit-header"], classNames: ["select-kit-header"],

19
test/javascripts/components/select-kit/single-select-test.js.es6
View File

@ -238,3 +238,22 @@ componentTest("selected value can be 0", {
assert.equal(this.subject.header().value(), 0); assert.equal(this.subject.header().value(), 0);
} }
}); });
componentTest("prevents propagating click event on header", {
template:
"{{#d-button icon='times' action=onClick}}{{single-select value=value content=content}}{{/d-button}}",
beforeEach() {
this.setProperties({
onClick: () => this.set("value", "foo"),
content: DEFAULT_CONTENT,
value: DEFAULT_VALUE
});
},
async test(assert) {
assert.equal(this.value, DEFAULT_VALUE);
await this.subject.expand();
assert.equal(this.value, DEFAULT_VALUE);
}
});