github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-24 04:13:22 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #524 from ZogStriP/fix-opengraph-tags-not-fully-sanitized

Browse Source 
FIX: OpenGraph tags not fully sanitized
This commit is contained in:
Robin Ward 2013-03-22 06:41:34 -07:00
commit d5e03b02a3
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/summarize.rb
View File

@ -1,9 +1,10 @@
# Summarize a HTML field into regular text. Used currently
# for meta tags
class Summarize
include ActionView::Helpers
require 'sanitize'
class Summarize
def initialize(text)
@text = text
end
@ -15,7 +16,7 @@ class Summarize
def summary
return nil if @text.blank?
result = sanitize(@text, tags: [], attributes: [])
result = Sanitize.clean(@text)
result.gsub!(/\n/, ' ')
result.strip!

5
spec/components/summarize_spec.rb
View File

@ -15,6 +15,11 @@ describe Summarize do
Summarize.new("hello <b>robin</b>").summary.should == "hello robin"
end
it "removes doctype entries" do
# this is not valid html but this is just testing DOCTYPE entries
Summarize.new("<!DOCTYPE html>Discourse").summary.should == "Discourse"
end
it "strips leading and trailing space" do
Summarize.new("\t \t hello \t ").summary.should == "hello"
end