From d92d65fe73c24f6464df9ef88ceead1a2007e3ed Mon Sep 17 00:00:00 2001
From: Jeff Wong <awole20@gmail.com>
Date: Tue, 15 Oct 2024 09:42:36 +0900
Subject: [PATCH] Revert "DEV: Output failing MF keys when compilation fails"
 (#29200)

This reverts commit 8eff922acea19983512b2493fce24e15bb439af9.
---
 lib/js_locale_helper.rb           | 12 +-----------
 spec/lib/js_locale_helper_spec.rb |  9 ---------
 2 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/lib/js_locale_helper.rb b/lib/js_locale_helper.rb
index bcdc56b4e5c..8b396707e1f 100644
--- a/lib/js_locale_helper.rb
+++ b/lib/js_locale_helper.rb
@@ -163,17 +163,7 @@ module JsLocaleHelper
       require("discourse-mf");
     JS
   rescue => e
-    message_formats[locale.to_s]
-      .filter_map do |key, value|
-        next if MessageFormat.compile(locale, value, strict: false)
-      rescue StandardError
-        key
-      end
-      .then do |strings|
-        Rails.logger.error(
-          "Failed to compile message formats for #{locale}.\n\nBroken strings are: #{strings.join(", ")}\n\nError: #{e}",
-        )
-      end
+    Rails.logger.error("Failed to compile message formats for #{locale} '#{e}'")
     <<~JS
       console.error("Failed to compile message formats for #{locale}. Some translation strings will be missing.");
     JS
diff --git a/spec/lib/js_locale_helper_spec.rb b/spec/lib/js_locale_helper_spec.rb
index a9648e64ce8..55b8e908be0 100644
--- a/spec/lib/js_locale_helper_spec.rb
+++ b/spec/lib/js_locale_helper_spec.rb
@@ -169,10 +169,8 @@ RSpec.describe JsLocaleHelper do
     let(:translated_message) do
       v8_ctx.eval("I18n._mfMessages.get('posts_likes_MF', {count: 3, ratio: 'med'})")
     end
-    let(:fake_logger) { FakeLogger.new }
 
     before do
-      Rails.logger.broadcast_to(fake_logger)
       overriden_translation_ja.update_columns(
         value: "{ count, plural, one {返信 # 件、} other {返信 # 件、} }",
       )
@@ -180,8 +178,6 @@ RSpec.describe JsLocaleHelper do
       v8_ctx.eval(output)
     end
 
-    after { Rails.logger.stop_broadcasting_to(fake_logger) }
-
     context "when locale is 'en'" do
       let(:locale) { "en" }
 
@@ -262,11 +258,6 @@ RSpec.describe JsLocaleHelper do
       it "raises an error" do
         expect(output).to match(/Failed to compile message formats/)
       end
-
-      it "logs which keys are problematic" do
-        output
-        expect(fake_logger.errors).to include(/posts_likes_MF/)
-      end
     end
   end