github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 05:21:50 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Fix mismatched column types (#29477)

Browse Source 
The primary key is usually a bigint column, but the foreign key columns
are usually of integer type. This can lead to issues when joining these
columns due to mismatched types and different value ranges.

This was using a temporary plugin / test API to make tests pass. After
more careful consideration, we concluded that it is safe to alter the
tables directly.

Even for larger communities, with about 1M chat messages, the
slowest `ALTER` query runs in about 15 seconds, which well under the 30
seconds query timeout limit. As a result, chat messages will be delayed
for a few seconds, but the system will remain operational.
This commit is contained in:
Bianca Nenciu 2024-11-06 20:00:40 +02:00 committed by GitHub
parent 708533b1e0
commit da43deb9ea
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 27 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
plugins/chat/db/migrate/20241029192512_alter_chat_ids_to_bigint.rb Normal file
View File

@ -0,0 +1,27 @@
# frozen_string_literal: true
class AlterChatIdsToBigint < ActiveRecord::Migration[7.1]
def up
change_column :chat_channel_archives, :chat_channel_id, :bigint
change_column :chat_channels, :chatable_id, :bigint
change_column :chat_drafts, :chat_channel_id, :bigint
change_column :chat_mention_notifications, :chat_mention_id, :bigint
change_column :chat_mention_notifications, :notification_id, :bigint
change_column :chat_mentions, :chat_message_id, :bigint
change_column :chat_message_reactions, :chat_message_id, :bigint
change_column :chat_message_revisions, :chat_message_id, :bigint
change_column :chat_messages, :chat_channel_id, :bigint
change_column :chat_messages, :in_reply_to_id, :bigint
change_column :chat_webhook_events, :chat_message_id, :bigint
change_column :chat_webhook_events, :incoming_chat_webhook_id, :bigint
change_column :direct_message_users, :direct_message_channel_id, :bigint
change_column :incoming_chat_webhooks, :chat_channel_id, :bigint
change_column :user_chat_channel_memberships, :chat_channel_id, :bigint
change_column :user_chat_channel_memberships, :last_read_message_id, :bigint
change_column :user_chat_channel_memberships, :last_unread_mention_when_emailed_id, :bigint
end
def down
raise ActiveRecord::IrreversibleMigration
end
end

20
plugins/chat/spec/plugin_helper.rb
View File

@ -153,24 +153,4 @@ RSpec.configure do |config|
# Or a very large value, if you do want to truncate at some point
c.max_formatted_output_length = nil
end
config.before(:suite) do
migrate_column_to_bigint(Chat::Channel, :chatable_id)
migrate_column_to_bigint(Chat::ChannelArchive, :chat_channel_id)
migrate_column_to_bigint(Chat::DirectMessageUser, :direct_message_channel_id)
migrate_column_to_bigint(Chat::Draft, :chat_channel_id)
migrate_column_to_bigint(Chat::IncomingWebhook, :chat_channel_id)
migrate_column_to_bigint(Chat::Mention, :chat_message_id)
migrate_column_to_bigint(Chat::MentionNotification, :chat_mention_id)
migrate_column_to_bigint(Chat::MentionNotification, :notification_id)
migrate_column_to_bigint(Chat::Message, :chat_channel_id)
migrate_column_to_bigint(Chat::Message, :in_reply_to_id)
migrate_column_to_bigint(Chat::MessageReaction, :chat_message_id)
migrate_column_to_bigint(Chat::MessageRevision, :chat_message_id)
migrate_column_to_bigint(Chat::UserChatChannelMembership, :chat_channel_id)
migrate_column_to_bigint(Chat::UserChatChannelMembership, :last_read_message_id)
migrate_column_to_bigint(Chat::UserChatChannelMembership, :last_unread_mention_when_emailed_id)
migrate_column_to_bigint(Chat::WebhookEvent, :chat_message_id)
migrate_column_to_bigint(Chat::WebhookEvent, :incoming_chat_webhook_id)
end
end