github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-20 22:26:10 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: be more tactical with replacing markdown chars

Browse Source 
* instead of using encodeURIComponent in imageNameFromFileName,
  we just replace the bad characters that we wanted to get rid
  of in the first place where we introduced encodeURIComponent.
  as per review
This commit is contained in:
Martin Brennan 2019-11-25 16:38:13 +10:00
parent b89e634dd4
commit dbfe9540fa
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/lib/uploads.js.es6
View File

@ -14,7 +14,9 @@ function imageNameFromFileName(fileName) {
name = I18n.t("upload_selector.default_image_alt_text");
}
return encodeURIComponent(name).replace(/%20/g, " ");
return name.replace(/\[|\]|\|/g, "");
// return encodeURIComponent(name).replace(/%20/g, " ");
}
export function validateUploadedFiles(files, opts) {

2
test/javascripts/lib/uploads-test.js.es6
View File

@ -198,7 +198,7 @@ QUnit.test("getUploadMarkdown", assert => {
);
assert.equal(
testUploadMarkdown("[foo|bar].png"),
"![%5Bfoo%7Cbar%5D|100x200](/uploads/123/abcdef.ext)"
"![foobar|100x200](/uploads/123/abcdef.ext)"
);
assert.equal(
testUploadMarkdown("file name with space.png"),