github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 09:42:07 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

FIX: ensures message field is rendering placeholders (#28753)

Browse Source 
A previous commit had broken this codepath, this commit ensures it's fixed and is adding a test. It's not testing the copy/paste behavior as fairly complex to test.
This commit is contained in:
Joffrey JAFFEUX 2024-09-05 11:18:21 +02:00 committed by GitHub
parent b7beab5531
commit dc1afeac89
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/automation/admin/assets/javascripts/admin/components/fields/da-message-field.gjs
View File

@ -24,8 +24,8 @@ export default class MessageField extends BaseField {
{{#if this.displayPlaceholders}}
<PlaceholdersList
@currentValue={{@field.metadata.value}}
@placeholders={{@placeholder}}
@onCopy={{this.test}}
@placeholders={{@placeholders}}
@onCopy={{this.mutValue}}
/>
{{/if}}
</div>

13
plugins/automation/test/javascripts/integration/components/da-message-field-test.js
View File

@ -24,4 +24,17 @@ module("Integration | Component | da-message-field", function (hooks) {
assert.strictEqual(this.field.metadata.value, "Hello World");
});
test("render placeholders", async function (assert) {
this.field = new AutomationFabricators(getOwner(this)).field({
component: "message",
});
this.automation.placeholders = ["foo", "bar"];
await render(
hbs`<AutomationField @automation={{this.automation}} @field={{this.field}} />`
);
assert.dom(".placeholders-list").hasText("foo bar");
});
});