github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-26 12:53:42 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: convert hotlinked non-image urls to short url.

Browse Source 
3840ace978
This commit is contained in:
Vinoth Kannan 2019-07-17 09:15:09 +05:30
parent 2a0cd066a7
commit dd0f0494c6
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/services/inline_uploads.rb
View File

@ -123,11 +123,6 @@ class InlineUploads
.sort { |a, b| a[3] <=> b[3] }
.each do |match, link, replace_with, _index|
if match == link
extension = match.split(".")[-1].downcase
next if FileHelper.supported_images.exclude?(extension)
end
node_info = link_occurences.shift
next unless node_info&.dig(:is_valid)

6
spec/services/inline_uploads_spec.rb
View File

@ -228,7 +228,7 @@ RSpec.describe InlineUploads do
MD
end
it "should not correct non image URLs to the short url and paths" do
it "should correct non image URLs to the short url" do
SiteSetting.authorized_extensions = "mp4"
upload = Fabricate(:video_upload)
@ -236,7 +236,9 @@ RSpec.describe InlineUploads do
#{GlobalSetting.cdn_url}#{upload.url}
MD
expect(InlineUploads.process(md)).to eq(md)
expect(InlineUploads.process(md)).to eq(<<~MD)
#{Discourse.base_url}#{upload.short_path}
MD
end
it "should correct img tags with uppercase upload extension" do