github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 02:19:27 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Jittery topic progress on some window sizes (#15462)

Browse Source
This commit is contained in:
Penar Musaraj 2022-01-05 14:09:25 -05:00 committed by GitHub
parent ab33d44bf6
commit e04069cf0d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
app/assets/javascripts/discourse/app/components/topic-progress.js
View File

@ -159,22 +159,35 @@ export default Component.extend({
return;
}
const composerH =
document.querySelector("#reply-control")?.clientHeight || 0;
// on desktop, pin this element to the composer
// otherwise the grid layout will change too much when toggling the composer
// and jitter when the viewport is near the topic bottom
if (!this.site.mobileView && composerH) {
this.set("docked", false);
this.element.style.setProperty("bottom", `${composerH}px`);
return;
}
if (entries[0].isIntersecting === true) {
this.set("docked", true);
this.element.style.removeProperty("bottom");
} else {
if (entries[0].boundingClientRect.top > 0) {
this.set("docked", false);
const wrapper = document.querySelector("#topic-progress-wrapper");
const composerH =
document.querySelector("#reply-control")?.clientHeight || 0;
if (composerH === 0) {
const filteredPostsHeight =
document.querySelector(".posts-filtered-notice")?.clientHeight || 0;
filteredPostsHeight === 0
? wrapper.style.removeProperty("bottom")
: wrapper.style.setProperty("bottom", `${filteredPostsHeight}px`);
? this.element.style.removeProperty("bottom")
: this.element.style.setProperty(
"bottom",
`${filteredPostsHeight}px`
);
} else {
wrapper.style.setProperty("bottom", `${composerH}px`);
this.element.style.setProperty("bottom", `${composerH}px`);
}
}
}