From e3c71221e57eeb9a14d81f6ab916bd240e2ea560 Mon Sep 17 00:00:00 2001
From: Joe <33972521+hnb-ku@users.noreply.github.com>
Date: Tue, 5 Jul 2022 02:06:28 +0800
Subject: [PATCH] UX: Makes splash screen setting enabled by default (#17327)

We now want the splash screen to be enabled by default.
---
 config/site_settings.yml                     | 2 +-
 spec/requests/application_controller_spec.rb | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/config/site_settings.yml b/config/site_settings.yml
index c6f6d1c1128..0f307b4e77b 100644
--- a/config/site_settings.yml
+++ b/config/site_settings.yml
@@ -2433,7 +2433,7 @@ uncategorized:
     hidden: true
 
   splash_screen:
-    default: false
+    default: true
 
   suggest_weekends_in_date_pickers:
     client: true
diff --git a/spec/requests/application_controller_spec.rb b/spec/requests/application_controller_spec.rb
index d0a8b3148b9..03e3f6c9fbd 100644
--- a/spec/requests/application_controller_spec.rb
+++ b/spec/requests/application_controller_spec.rb
@@ -540,14 +540,14 @@ RSpec.describe ApplicationController do
       get '/'
 
       expect(response.status).to eq(200)
-      expect(response.body).not_to include("d-splash")
+      expect(response.body).to include("d-splash")
 
-      SiteSetting.splash_screen = true
+      SiteSetting.splash_screen = false
 
       get '/'
 
       expect(response.status).to eq(200)
-      expect(response.body).to include("d-splash")
+      expect(response.body).not_to include("d-splash")
     end
   end