github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-18 13:03:16 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: missing route for edit components (#26874)

Browse Source 
In this PR separate route for components was introduced https://github.com/discourse/discourse/pull/26644

However, the route to edit components was missed and it was 404 when reloaded.

Meta: https://meta.discourse.org/t/missing-admin-theme-component-edit-route/306560
This commit is contained in:
Krzysztof Kotlarek 2024-05-06 14:27:30 +10:00 committed by GitHub
parent 755ff43dc1
commit e607dd3767
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
config/routes.rb
View File

@ -259,6 +259,7 @@ Discourse::Application.routes.draw do
get "themes/:id/:target/:field_name/edit" => "themes#index" get "themes/:id/:target/:field_name/edit" => "themes#index"
get "themes/:id" => "themes#index" get "themes/:id" => "themes#index"
get "components/:id" => "themes#index" get "components/:id" => "themes#index"
get "components/:id/:target/:field_name/edit" => "themes#index"
get "themes/:id/export" => "themes#export" get "themes/:id/export" => "themes#export"
get "themes/:id/schema/:setting_name" => "themes#schema" get "themes/:id/schema/:setting_name" => "themes#schema"
get "components/:id/schema/:setting_name" => "themes#schema" get "components/:id/schema/:setting_name" => "themes#schema"

12
spec/requests/admin/themes_controller_spec.rb
View File

@ -478,6 +478,18 @@ RSpec.describe Admin::ThemesController do
end end
end end
it "allows themes and components to be edited" do
sign_in(admin)
theme = Fabricate(:theme, name: "Awesome Theme")
component = Fabricate(:theme, name: "Awesome component", component: true)
get "/admin/customize/themes/#{theme.id}/common/scss/edit"
expect(response.status).to eq(200)
get "/admin/customize/components/#{component.id}/common/scss/edit"
expect(response.status).to eq(200)
end
shared_examples "themes inaccessible" do shared_examples "themes inaccessible" do
it "denies access with a 404 response" do it "denies access with a 404 response" do
get "/admin/themes.json" get "/admin/themes.json"