github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 10:57:04 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: remove edit PM button

Browse Source 
Edit PM button leads to confusion and is uneeded
This commit is contained in:
Sam Saffron 2020-05-28 15:15:11 +10:00
parent c8370b9c78
commit ecc8e559ec
No known key found for this signature in database
GPG Key ID: B9606168D2FFD9F5
2 changed files with 0 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/assets/javascripts/discourse/app/initializers/topic-footer-buttons.js
View File

@ -7,7 +7,6 @@ const SHARE_PRIORITY = 1000;
const BOOKMARK_PRIORITY = 900;
const ARCHIVE_PRIORITY = 800;
const FLAG_PRIORITY = 700;
const EDIT_MESSAGE_PRIORITY = 600;
const DEFER_PRIORITY = 500;
export default {
@ -166,23 +165,6 @@ export default {
}
});
registerTopicFooterButton({
id: "edit-message",
priority: EDIT_MESSAGE_PRIORITY,
icon: "pencil-alt",
label: "topic.edit_message.title",
title: "topic.edit_message.help",
action: "editFirstPost",
classNames: ["edit-message"],
dependentKeys: ["editFirstPost", "showEditOnFooter"],
dropdown() {
return this.site.mobileView && this.get("topic.isPrivateMessage");
},
displayed() {
return this.showEditOnFooter;
}
});
registerTopicFooterButton({
id: "defer",
icon: "circle",

14
test/javascripts/acceptance/personal-message-test.js
View File

@ -24,17 +24,3 @@ QUnit.test("suggested messages", async assert => {
I18n.t("suggested_topics.pm_title")
);
});
acceptance("Personal Message Tagging", {
loggedIn: true,
site: { can_tag_pms: true }
});
QUnit.test("show footer edit button", async assert => {
await visit("/t/pm-for-testing/12");
assert.ok(
exists(".edit-message"),
"shows edit first post button on footer when PM tagging is enabled"
);
});