github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-17 09:22:44 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: semantic form on login modal

Browse Source 
cf. https://meta.discourse.org/t/improve-semantics-of-orphaned-form-elements-such-as-buttons/72936
This commit is contained in:
Régis Hanol 2017-10-27 19:14:25 +02:00
parent 9112d2da3b
commit f2219138e1
1 changed files with 27 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/discourse/templates/modal/login.hbs
View File

@ -1,8 +1,8 @@
{{#login-modal screenX=lastX screenY=lastY loginName=loginName loginPassword=loginPassword action="login"}}
<form id='login-form' method='post'>
{{#d-modal-body title="login.title" class="login-modal"}}
{{login-buttons action="externalLogin"}}
{{#if canLoginLocal}}
<form id='login-form' method='post'>
<div>
<table>
<tr>
@ -32,7 +32,6 @@
</tr>
</table>
</div>
</form>
{{/if}}
{{authMessage}}
<div id='login-alert' class={{alertClass}}>{{alert}}</div>
@ -40,9 +39,7 @@
<div class="modal-footer">
{{#if canLoginLocal}}
<button class="btn btn-large btn-primary"
disabled={{loginDisabled}}
{{action "login"}}>
<button class="btn btn-large btn-primary" type="submit" disabled={{loginDisabled}} {{action "login"}}>
{{d-icon "unlock"}} &nbsp;{{loginButtonText}}
</button>
@ -60,4 +57,5 @@
{{conditional-loading-spinner condition=showSpinner size="small"}}
</div>
</form>
{{/login-modal}}