From f79f9e236a07517afd4c47062c05e0a1ea821f6c Mon Sep 17 00:00:00 2001
From: Osama Sayegh <asooomaasoooma90@gmail.com>
Date: Wed, 27 Mar 2024 15:48:48 +0300
Subject: [PATCH] FIX: Descriptions not showing for some site setting types
 (#26399)

Descriptions for the `category-list`, `file-size-restriction` and `file-types-list` site/theme settings aren't rendered due to a bug that was introduced when those components were migrated to Glimmer components. This commit fixes the bug which is that arguments passed to .gjs components should be accessed as `@argument` and not `this.arugment` inside the `<template>` tag.
---
 .../admin/addon/components/site-settings/category-list.gjs    | 4 ++--
 .../addon/components/site-settings/file-size-restriction.gjs  | 2 +-
 .../admin/addon/components/site-settings/file-types-list.gjs  | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/assets/javascripts/admin/addon/components/site-settings/category-list.gjs b/app/assets/javascripts/admin/addon/components/site-settings/category-list.gjs
index 0537132dee7..01776dbfb74 100644
--- a/app/assets/javascripts/admin/addon/components/site-settings/category-list.gjs
+++ b/app/assets/javascripts/admin/addon/components/site-settings/category-list.gjs
@@ -51,8 +51,8 @@ export default class CategoryList extends Component {
         @onChange={{this.onChangeSelectedCategories}}
       />
 
-      <SiteSettingsDescription @description={{this.setting.description}} />
-      <SettingValidationMessage @message={{this.validationMessage}} />
+      <SiteSettingsDescription @description={{@setting.description}} />
+      <SettingValidationMessage @message={{@validationMessage}} />
     </div>
   </template>
 }
diff --git a/app/assets/javascripts/admin/addon/components/site-settings/file-size-restriction.gjs b/app/assets/javascripts/admin/addon/components/site-settings/file-size-restriction.gjs
index 2f22859fb9c..15d356a1330 100644
--- a/app/assets/javascripts/admin/addon/components/site-settings/file-size-restriction.gjs
+++ b/app/assets/javascripts/admin/addon/components/site-settings/file-size-restriction.gjs
@@ -29,6 +29,6 @@ export default class FileSizeRestriction extends Component {
     />
 
     <SettingValidationMessage @message={{this.validationMessage}} />
-    <SiteSettingsDescription @description={{this.setting.description}} />
+    <SiteSettingsDescription @description={{@setting.description}} />
   </template>
 }
diff --git a/app/assets/javascripts/admin/addon/components/site-settings/file-types-list.gjs b/app/assets/javascripts/admin/addon/components/site-settings/file-types-list.gjs
index c60e2960158..7c5baf7c0e2 100644
--- a/app/assets/javascripts/admin/addon/components/site-settings/file-types-list.gjs
+++ b/app/assets/javascripts/admin/addon/components/site-settings/file-types-list.gjs
@@ -146,7 +146,7 @@ export default class FileTypesList extends Component {
       class="btn file-types-list__button document"
     />
 
-    <SettingValidationMessage @message={{this.validationMessage}} />
-    <SiteSettingsDescription @description={{this.setting.description}} />
+    <SettingValidationMessage @message={{@validationMessage}} />
+    <SiteSettingsDescription @description={{@setting.description}} />
   </template>
 }