From f92190959504e9a286d659f243fa97a222576a6a Mon Sep 17 00:00:00 2001 From: Blake Erickson Date: Tue, 10 Dec 2019 12:32:18 -0700 Subject: [PATCH] FIX: Reorder categories not working Ember was throwing this error preventing the reorder categories feature from working: ``` access theidproperty (of <(unknown):ember1803>). ... the object in question is a special kind of Ember object (a proxy). Therefore, it is still necessary to use.get('id')in this case. ``` So I updated it to use the `get` method https://api.emberjs.com/ember/3.14/functions/@ember%2Fobject/get Follow up to: 6e5fedb31281fb40e672ffb87e767afcffd35e38 --- app/assets/javascripts/discourse/helpers/category-link.js.es6 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/helpers/category-link.js.es6 b/app/assets/javascripts/discourse/helpers/category-link.js.es6 index b8a61987979..3cdb03c8f00 100644 --- a/app/assets/javascripts/discourse/helpers/category-link.js.es6 +++ b/app/assets/javascripts/discourse/helpers/category-link.js.es6 @@ -79,7 +79,9 @@ function defaultCategoryLinkRenderer(category, opts) { let restricted = get(category, "read_restricted"); let url = opts.url ? opts.url - : Discourse.getURL(`/c/${Category.slugFor(category)}/${category.id}`); + : Discourse.getURL( + `/c/${Category.slugFor(category)}/${get(category, "id")}` + ); let href = opts.link === false ? "" : url; let tagName = opts.link === false || opts.link === "false" ? "span" : "a"; let extraClasses = opts.extraClasses ? " " + opts.extraClasses : "";