github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 09:12:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

SECURITY: force IM decoder based on file extension - part 3

Browse Source
This commit is contained in:
Régis Hanol 2018-07-25 23:55:06 +02:00
parent 800c57c6ab
commit f94aeaf6cf
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/models/optimized_image.rb
View File

@ -123,7 +123,7 @@ class OptimizedImage < ActiveRecord::Base
def self.prepend_decoder!(path)
extension = File.extname(path)[1..-1]
raise Discourse::InvalidAccess unless extension[IM_DECODERS]
path = "#{extension}:#{path}"
"#{extension}:#{path}"
end
def self.thumbnail_or_resize
@ -133,8 +133,8 @@ class OptimizedImage < ActiveRecord::Base
def self.resize_instructions(from, to, dimensions, opts = {})
ensure_safe_paths!(from, to)
prepend_decoder!(from)
prepend_decoder!(to)
from = prepend_decoder!(from)
to = prepend_decoder!(to)
# NOTE: ORDER is important!
%W{
@ -170,8 +170,8 @@ class OptimizedImage < ActiveRecord::Base
def self.crop_instructions(from, to, dimensions, opts = {})
ensure_safe_paths!(from, to)
prepend_decoder!(from)
prepend_decoder!(to)
from = prepend_decoder!(from)
to = prepend_decoder!(to)
%W{
convert
@ -205,8 +205,8 @@ class OptimizedImage < ActiveRecord::Base
def self.downsize_instructions(from, to, dimensions, opts = {})
ensure_safe_paths!(from, to)
prepend_decoder!(from)
prepend_decoder!(to)
from = prepend_decoder!(from)
to = prepend_decoder!(to)
%W{
convert

6
lib/upload_creator.rb
View File

@ -140,8 +140,8 @@ class UploadCreator
OptimizedImage.ensure_safe_paths!(from, to)
OptimizedImage.prepend_decoder!(from)
OptimizedImage.prepend_decoder!(to)
from = OptimizedImage.prepend_decoder!(from)
to = OptimizedImage.prepend_decoder!(to)
begin
execute_convert(from, to)
@ -220,7 +220,7 @@ class UploadCreator
path = @file.path
OptimizedImage.ensure_safe_paths!(path)
OptimizedImage.prepend_decoder!(path)
path = OptimizedImage.prepend_decoder!(path)
Discourse::Utils.execute_command('convert', path, '-auto-orient', path)