github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-28 10:09:55 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: update "all tags" to "remove filter" for tag breadcrumb dropdown (#27424)

Browse Source
This commit is contained in:
Kris 2024-06-11 13:21:09 -04:00 committed by GitHub
parent dc2be1a9bd
commit f95d80af26
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/tests/integration/components/select-kit/tag-drop-test.js
View File

@ -58,8 +58,8 @@ module("Integration | Component | select-kit/tag-drop", function (hooks) {
); );
assert.strictEqual( assert.strictEqual(
content[1].name, content[1].name,
I18n.t("tagging.selector_all_tags"), I18n.t("tagging.selector_remove_filter"),
"it has the correct label for all-tags" "it has the correct label for removing the tag filter"
); );
await this.subject.fillInFilter("dav"); await this.subject.fillInFilter("dav");

2
app/assets/javascripts/select-kit/addon/components/tag-drop.js
View File

@ -106,7 +106,7 @@ export default ComboBoxComponent.extend(TagsMixin, {
if (this.tagId) { if (this.tagId) {
shortcuts.push({ shortcuts.push({
id: ALL_TAGS_ID, id: ALL_TAGS_ID,
name: I18n.t("tagging.selector_all_tags"), name: I18n.t("tagging.selector_remove_filter"),
}); });
} }

2
config/locales/client.en.yml
View File

@ -4454,7 +4454,6 @@ en:
all_tags: "All tags" all_tags: "All tags"
other_tags: "Other Tags" other_tags: "Other Tags"
selector_tags: "tags" selector_tags: "tags"
selector_all_tags: "all tags"
selector_no_tags: "no tags" selector_no_tags: "no tags"
selector_remove_filter: "remove filter" selector_remove_filter: "remove filter"
tags: "Tags" tags: "Tags"
@ -5386,7 +5385,6 @@ en:
legal: "Legal" legal: "Legal"
moderation_flags: "Moderation Flags" moderation_flags: "Moderation Flags"
appearance: appearance:
title: "Appearance" title: "Appearance"
sidebar_link: sidebar_link: