github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-03 05:39:41 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: when rouding numbers in poll resuls, *don't* select a never-been-voted-for option to round up from zero

Browse Source
This commit is contained in:
Régis Hanol 2016-01-14 01:59:46 +01:00
parent 1a27d887fa
commit fc92166d5f
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/poll/assets/javascripts/lib/even-round.js.es6
View File

@ -5,11 +5,13 @@ function sumsUpTo100(percentages) {
export default (percentages) => { export default (percentages) => {
const sumOfDecimals = Math.ceil(percentages.map(a => a % 1).reduce((a, b) => a + b)); const sumOfDecimals = Math.ceil(percentages.map(a => a % 1).reduce((a, b) => a + b));
// compensate error by adding 1 to the first n items // compensate error by adding 1 to the first n "non-zero" items
for (let i = 0; i < sumOfDecimals; i++) { for (let i = 0, max = percentages.length; i < sumOfDecimals && i < max; i++) {
percentages[i] = ++percentages[i]; if (percentages[i] > 0) {
// quit early when there is a rounding issue percentages[i] = ++percentages[i];
if (sumsUpTo100(percentages)) break; // quit early when there is a rounding issue
if (sumsUpTo100(percentages)) break;
}
} }
return percentages.map(p => Math.floor(p)); return percentages.map(p => Math.floor(p));
}; };