From fe5a48997ce5a177e92bcf1f3af48f71819ed6ce Mon Sep 17 00:00:00 2001
From: Guo Xiang Tan <tgx_world@hotmail.com>
Date: Wed, 30 May 2018 15:59:07 +0800
Subject: [PATCH] DEV: Store smoke tests failure image in a dedicated tmp
 folder.

---
 lib/tasks/smoke_test.rake | 3 +++
 test/smoke_test.js        | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/tasks/smoke_test.rake b/lib/tasks/smoke_test.rake
index 99f09a84624..b1856e3864b 100644
--- a/lib/tasks/smoke_test.rake
+++ b/lib/tasks/smoke_test.rake
@@ -26,6 +26,9 @@ task "smoke:test" do
     request.basic_auth(ENV['AUTH_USER'], ENV['AUTH_PASSWORD'])
   end
 
+  dir = 'tmp/smoke-test-screenshots'
+  FileUtils.mkdir_p(dir) unless Dir.exists?(dir)
+
   start = Time.now
   while true
     response = Net::HTTP.start(uri.hostname, uri.port, use_ssl: uri.scheme == 'https') do |http|
diff --git a/test/smoke_test.js b/test/smoke_test.js
index d38a23dbf3d..77983e3ac30 100644
--- a/test/smoke_test.js
+++ b/test/smoke_test.js
@@ -26,7 +26,7 @@ const path = require('path');
   });
 
   const takeFailureScreenshot = function() {
-    const screenshotPath = `${process.env.SCREENSHOT_PATH || 'tmp'}/smoke-test.png`;
+    const screenshotPath = `${process.env.SCREENSHOT_PATH || 'tmp/smoke-test-screenshots'}/smoke-test-${Date.now()}.png`;
     console.log(`Screenshot of failure taken at ${screenshotPath}`);
     return page.screenshot({ path: screenshotPath, fullPage: true });
   };