github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 06:08:55 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Cannot manually add users to automatic groups (#31062)

Browse Source 
Adding/removing users from automatic groups should not be possible.

Bug introduced in this PR
https://github.com/discourse/discourse/pull/30174

Before
<img width="1435" alt="Screenshot 2025-01-30 at 3 35 12 pm"
src="https://github.com/user-attachments/assets/a982bfb7-3597-4efb-82b8-c11a47493075"
/>

After
<img width="1391" alt="Screenshot 2025-01-30 at 3 34 47 pm"
src="https://github.com/user-attachments/assets/894a9319-94b9-4fad-bf99-e357b910a209"
/>
This commit is contained in:
Krzysztof Kotlarek 2025-01-31 12:12:42 +11:00 committed by GitHub
parent 7fd9550f64
commit ff32232834
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/controllers/group-index.js
View File

@ -64,7 +64,7 @@ export default class GroupIndexController extends Controller {
@discourseComputed("model") @discourseComputed("model")
canManageGroup(model) { canManageGroup(model) {
return this.currentUser?.canManageGroup(model); return this.currentUser?.canManageGroup(model) && !this.model.automatic;
} }
@discourseComputed @discourseComputed

5
app/assets/javascripts/discourse/tests/acceptance/group-manage-membership-test.js
View File

@ -187,6 +187,11 @@ acceptance(
.dom(".group-automatic-tooltip") .dom(".group-automatic-tooltip")
.exists("displays automatic tooltip"); .exists("displays automatic tooltip");
}); });
test("the current user cannot invite users to automatic group", async function (assert) {
await visit("/g/moderators");
assert.dom(".group-members-add").doesNotExist();
});
} }
); );