github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 12:42:16 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Notifications dropdown had incorrect spacing

Browse Source
This commit is contained in:
Robin Ward 2017-07-27 19:22:19 -04:00
parent 4f574e7c93
commit ff4e295c4f
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/discourse-common/lib/icon-library.js.es6
View File

@ -54,6 +54,8 @@ registerIconRenderer({
},
node(id, params) {
let tagName = params.tagName || 'i';
const properties = {
className: faClasses(id, params),
attributes: { "aria-hidden": true }
@ -61,9 +63,9 @@ registerIconRenderer({
if (params.title) { properties.attributes.title = params.title; }
if (params.label) {
return h('i', properties, h('span.sr-only', I18n.t(params.label)));
return h(tagName, properties, h('span.sr-only', I18n.t(params.label)));
} else {
return h('i', properties);
return h(tagName, properties);
}
}
});

2
app/assets/javascripts/discourse/widgets/topic-notifications-button.js.es6
View File

@ -10,7 +10,7 @@ createWidget('notification-option', {
html(attrs) {
return h('a', [
iconNode(attrs.icon, { class: attrs.key }),
iconNode(attrs.icon, { class: `icon ${attrs.key}`, tagName: 'span' }),
h('div', [
h('span.title', I18n.t(`topic.notifications.${attrs.key}.title`)),
h('span.desc', I18n.t(`topic.notifications.${attrs.key}.description`)),