DEV: simplify logic (#8249)

Anonymous users are only possible if allow_anonymous_posting is true,
which means that 'user.is_anonymous' check implies that
allow_anonymous_posting is true.
This commit is contained in:
Bianca Nenciu 2019-10-29 12:10:27 +02:00 committed by GitHub
parent 0c47529713
commit ff9345fbb0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions

View File

@ -45,7 +45,7 @@ export default RestrictedUserRoute.extend({
if (
transition.targetName === "preferences.second-factor" ||
!user ||
(settings.allow_anonymous_posting && user.is_anonymous) ||
user.is_anonymous ||
user.second_factor_enabled ||
(settings.enforce_second_factor === "staff" && !user.staff) ||
settings.enforce_second_factor === "no"

View File

@ -734,7 +734,7 @@ class ApplicationController < ActionController::Base
check_totp = current_user &&
!request.format.json? &&
!is_api? &&
!(SiteSetting.allow_anonymous_posting && current_user.anonymous?) &&
!current_user.anonymous? &&
((SiteSetting.enforce_second_factor == 'staff' && current_user.staff?) ||
SiteSetting.enforce_second_factor == 'all') &&
!current_user.totp_enabled?