3 Commits

Author	SHA1	Message	Date
Sam Saffron	d0d5a138c3	DEV: stop freezing frozen strings ... We have the `# frozen_string_literal: true` comment on all our files. This means all string literals are frozen. There is no need to call #freeze on any literals. For files with `# frozen_string_literal: true` ``` puts %w{a b}[0].frozen? => true puts "hi".frozen? => true puts "a #{1} b".frozen? => true puts ("a " + "b").frozen? => false puts (-("a " + "b")).frozen? => true ``` For more details see: https://samsaffron.com/archive/2018/02/16/reducing-string-duplication-in-ruby	2020-04-30 16:48:53 +10:00
Sam Saffron	30990006a9	DEV: enable frozen string literal on all files ... This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging	2019-05-13 09:31:32 +08:00
Guo Xiang Tan	45f092a49d	Extract badge_posts view management logic into a service object. ... * Avoid defininig a global constant and method. Fixes https://github.com/discourse/discourse/pull/6318	2018-09-03 09:51:35 +08:00