David Taylor
d3caa875be
DEV: Fix duplicate port on livereload ( #29771 )
...
Followup to fd5ef6896d
2024-11-14 23:05:47 +00:00
dependabot[bot]
4d89abbc14
Build(deps): Bump ace-builds from 1.36.4 to 1.36.5 ( #29764 )
...
Bumps [ace-builds](https://github.com/ajaxorg/ace-builds ) from 1.36.4 to 1.36.5.
- [Release notes](https://github.com/ajaxorg/ace-builds/releases )
- [Changelog](https://github.com/ajaxorg/ace-builds/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ajaxorg/ace-builds/compare/v1.36.4...v1.36.5 )
---
updated-dependencies:
- dependency-name: ace-builds
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-14 23:31:44 +01:00
Kris
5f130b2971
A11Y: update clickable search dropdown tips to be buttons ( #29762 )
2024-11-14 16:23:43 -05:00
Jan Cernik
2ac1894292
FIX: Error with social logins and fullpage signup ( #29761 )
2024-11-14 16:02:17 -03:00
David Taylor
f70cc6215c
DEV: Improve JSDoc for withPluginApi ( #29758 )
...
This allows consumers to get intellisense completions on the `api.` argument of their callback
2024-11-14 17:20:23 +00:00
Penar Musaraj
9b691853e0
FIX: Dismiss unread posts in subcategories ( #29671 )
...
When a parent category shows topics from subcategories, dismissing
should dismiss posts in both parent and subcategories.
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
2024-11-14 10:06:12 -05:00
David Taylor
fd5ef6896d
DEV: Overhaul devcontainer configuration ( #28446 )
...
- Uses a more appropriate image, with immutable tag (so update prompts work correctly)
- Updates port forwarding
- Improves mount setup (inc. persistant PG/Redis when rebuilding)
- Fixes ember-cli live reload
- Automatically configures VSCode & extensions
2024-11-14 12:11:38 +00:00
Joffrey JAFFEUX
9aae4df273
FIX: uses absolute strategy on ipad ( #29754 )
...
The absolute strategy was causing issues on modals.
2024-11-14 15:23:06 +09:00
Krzysztof Kotlarek
42b1ca8f78
UX: redesign admin permalinks page ( #29634 )
...
Redesign the permalinks page to follow the UX guide. In addition, the ability to edit permalinks was added.
This change includes:
- move to RestModel
- added Validations
- update endpoint and clear old values after the update
- system specs and improvements for unit tests
2024-11-14 10:03:58 +11:00
David Taylor
8d53f8ef1a
DEV: Simplify livereload configuration for better proxy compatibility ( #29742 )
...
When running a development environment behind a proxy (e.g. when using a cloud development environment, or a service like ngrok), the ember-cli port & protocol may not match the one in the browser. `livereload.js` knows how to auto-configure itself based on the current browser environment... but Ember CLI overrides that autoconfiguration with some hard-coded values.
The intention there is to allow running the livereload server on a different port to the ember-cli web proxy. We don't need that functionality.
This commit stops loading `ember-cli-live-reload.js`, and instead loads `_lr/livereload.js` directly.
2024-11-13 16:39:23 +00:00
Joffrey JAFFEUX
6779b46f55
FIX: correctly makes @disabled dynamic ( #29738 )
...
Disabled was set on field init which was preventing it to be dynamic.
2024-11-13 22:53:42 +09:00
Kris
9a22d7df7b
UX: reduce bottom topic map threshold, with protections ( #29665 )
2024-11-13 07:58:44 -05:00
Jan Cernik
3df3ad6ed6
FIX: Hide presence toggle icon is backwards ( #29737 )
2024-11-13 09:54:40 -03:00
Jan Cernik
920fa4c248
FIX: Correctly load the invites model when using full page logins ( #29713 )
2024-11-13 08:56:16 -03:00
Joffrey JAFFEUX
f1edc20a50
FIX: correctly supports dropping image ( #29733 )
...
This commit:
- Adds back the target drop options to enable the feature
- Applies the css to every elements and not just the one for admin emojis, also fixes the style as it was flashing and preventing it to work. For now we just change the color of the image icon.
- Adds a test to ensure we don't regress.
2024-11-13 17:30:14 +09:00
Jan Cernik
234133bd3b
UX: Split hide_profile_and_presence user option ( #29632 )
...
It splits the hide_profile_and_presence user option and the default_hide_profile_and_presence site setting for more granular control. It keeps the option to hide the profile under /u/username/preferences/interface and adds the presence toggle in the quick user menu.
Co-authored-by: Régis Hanol <regis@hanol.fr>
2024-11-12 22:22:58 -03:00
dependabot[bot]
7cdf559846
Build(deps): Bump ember-template-imports from 4.1.3 to 4.2.0 ( #29729 )
...
Bumps [ember-template-imports](https://github.com/ember-template-imports/ember-template-imports ) from 4.1.3 to 4.2.0.
- [Release notes](https://github.com/ember-template-imports/ember-template-imports/releases )
- [Changelog](https://github.com/ember-cli/ember-template-imports/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ember-template-imports/ember-template-imports/commits )
---
updated-dependencies:
- dependency-name: ember-template-imports
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-13 01:38:14 +01:00
dependabot[bot]
9aedd9909a
Build(deps-dev): Bump ember-cli from 5.12.0 to 6.0.0 ( #29728 )
...
Bumps [ember-cli](https://github.com/ember-cli/ember-cli ) from 5.12.0 to 6.0.0.
- [Release notes](https://github.com/ember-cli/ember-cli/releases )
- [Changelog](https://github.com/ember-cli/ember-cli/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ember-cli/ember-cli/compare/v5.12.0...v6.0.0 )
---
updated-dependencies:
- dependency-name: ember-cli
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-13 01:18:28 +01:00
Penar Musaraj
4c1af2f414
UX: Fix modal header background color in webview ( #29717 )
2024-11-12 12:47:14 -05:00
David Taylor
fb2a688b29
DEV: Bump eslint, lint-configs, and move to flat config ( #29661 )
2024-11-12 12:33:17 +00:00
Krzysztof Kotlarek
34ed35e174
FIX: filterable staff logs for flags ( #29695 )
...
Flag actions must be added to `staff_actions` method to be filterable.
2024-11-12 11:23:18 +11:00
dependabot[bot]
0a0b490743
Build(deps-dev): Bump @swc/core from 1.9.1 to 1.9.2 ( #29710 )
...
Bumps [@swc/core](https://github.com/swc-project/swc ) from 1.9.1 to 1.9.2.
- [Release notes](https://github.com/swc-project/swc/releases )
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md )
- [Commits](https://github.com/swc-project/swc/compare/v1.9.1...v1.9.2 )
---
updated-dependencies:
- dependency-name: "@swc/core"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-12 00:30:13 +01:00
Sérgio Saquetim
3019bb577b
DEV: Modernize the post menu from widgets to Glimmer components ( #28670 )
...
This commit modernizes the post menu by migrating it from the existing widget-based implementation to Glimmer components. This transition aims to improve the maintainability, performance, and overall developer experience.
It also introduces a new DAG-based transformer API for customizations that aims to be more flexible than the widget base one.
---------
Co-authored-by: David Taylor <david@taylorhq.com>
2024-11-11 15:36:08 -03:00
dependabot[bot]
5c5ac72488
Build(deps-dev): Bump jsuites from 5.7.1 to 5.7.2 ( #29692 )
...
Bumps [jsuites](https://github.com/jsuites/jsuites ) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/jsuites/jsuites/releases )
- [Changelog](https://github.com/jsuites/jsuites/blob/master/changelog.md )
- [Commits](https://github.com/jsuites/jsuites/commits )
---
updated-dependencies:
- dependency-name: jsuites
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-11 17:45:16 +00:00
Bianca Nenciu
f1700ca589
FEATURE: Paginate categories when there are many ( #29569 )
...
This commit removes the new optimized category style introduced in
previous commits (d37a0d409a80d718430c42ac
2024-11-11 17:32:45 +02:00
Jarek Radosz
e68905510d
DEV: Use the new hasHtml/includesHtml from qunit-dom ( #29680 )
2024-11-11 13:06:12 +01:00
Jarek Radosz
2272b1340b
DEV: Use qunit-dom instead of raw href/title comparisons ( #29678 )
2024-11-11 11:44:54 +01:00
Jarek Radosz
429b6a4e4e
DEV: Use qunit-dom instead of classList/activeElement ( #29676 )
2024-11-11 11:44:42 +01:00
Ted Johansson
189d98f3ca
DEV: Convert admin emojis UI to new layout ( #29615 )
...
This PR converts the custom emoji UI in the admin pages to follow the new admin UI guidelines.
2024-11-11 15:04:15 +08:00
dependabot[bot]
8c52345b55
Build(deps-dev): Bump qunit-dom from 3.2.1 to 3.3.0 ( #29690 )
2024-11-11 00:04:38 +01:00
Jarek Radosz
78ed0bb711
DEV: Use selectors instead of query() where possible ( #29677 )
2024-11-10 13:53:12 +01:00
Jarek Radosz
16a9663557
DEV: Use qunit-dom's isDisabled/isEnabled ( #29675 )
2024-11-10 02:24:58 +01:00
Jarek Radosz
d67a6002eb
DEV: Replace count with qunit-dom ( #29674 )
2024-11-10 02:06:03 +01:00
Jarek Radosz
f9e58938ce
DEV: Update visible/invisible uses to qunit-dom ( #29672 )
2024-11-10 01:41:50 +01:00
Jarek Radosz
de6d575d40
DEV: Convert all uses of exists to qunit-dom ( #29667 )
2024-11-10 01:30:33 +01:00
Penar Musaraj
20effebd51
DEV: Fix updating header background in webview ( #29668 )
...
This regressed in https://github.com/discourse/discourse/pull/28912 for media query changes.
2024-11-08 22:18:09 -05:00
Jarek Radosz
c1916f7984
DEV: Convert assert.true(exists()) to qunit-dom ( #29638 )
2024-11-08 20:27:32 +01:00
David Taylor
3a23ff98bc
DEV: Fix passing translatedTitle as argument to flat-button ( #29663 )
...
Overriding computed properties with arguments is no longer supported by Ember, so we need to rename this computed property and add fallback logic manually.
This fixes the styleguide 'buttons' page. Ref https://meta.discourse.org/t/styleguide-bugs/335211?u=david
2024-11-08 18:46:05 +00:00
Ted Johansson
f573fd8f5e
FEATURE: Add more bulk dismiss buttons with confirmation ( #29331 )
...
When performing bulk dismissal in Unread and New views, the dismiss button stays at the top of the UI. Because of this we want to provide the dismiss action also in the "sticky" menu that's always in view, even when scrolling a long list of topics.
2024-11-08 15:59:12 +08:00
Osama Sayegh
4bc030f76f
FIX: Add back the option to create invite without emailing ( #29641 )
...
Follow-up to a5497b74be
2024-11-08 07:59:24 +03:00
Kris
64291fedf8
UX: lower min_post_count to show bottom topic map ( #29649 )
2024-11-07 20:10:18 -05:00
Keegan George
5a23a74bbc
DEV: Show confirmation dialog when admins disable 2FA ( #29652 )
...
This PR ensures that admins are shown a confirmation dialog when clicking to disable 2FA for a user. The 2FA button is right below the "Grant Badge" button and as such it can easily be clicked accidentally. It's also good practice to ask for confirmation before removing important functionality.
2024-11-07 16:39:42 -08:00
Renato Atilio
7568e732cc
FIX: resume editing when through /new-message ( #29637 )
...
"Resume editing" would do nothing when going through the `/new-message` flow.
This seems to be broken since [this commit](b0f6d074be
2024-11-07 17:39:58 -03:00
chapoi
75ee73f969
UX: remove icons indicating time in userstatus, bookmarks, topic timer ( #29635 )
2024-11-07 06:54:40 +01:00
Ella E.
b4f7a1b761
UX: Apply admin table classes for consistent mobile styling on the API keys page ( #29630 )
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
* UX: Apply admin table classes for consistent mobile styling on the API keys page
* apply prettier
2024-11-06 18:38:25 -07:00
dependabot[bot]
cc01555fce
Build(deps-dev): Bump @embroider/compat in the embroider group ( #29626 )
...
Bumps the embroider group with 1 update: [@embroider/compat](https://github.com/embroider-build/embroider/tree/HEAD/packages/compat ).
Updates `@embroider/compat` from 3.6.5 to 3.7.0
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/compat )
---
updated-dependencies:
- dependency-name: "@embroider/compat"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: embroider
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-07 00:38:09 +01:00
dependabot[bot]
fa959b0b54
Build(deps-dev): Bump jsuites from 5.6.6 to 5.7.1 ( #29627 )
...
Bumps [jsuites](https://github.com/jsuites/jsuites ) from 5.6.6 to 5.7.1.
- [Release notes](https://github.com/jsuites/jsuites/releases )
- [Changelog](https://github.com/jsuites/jsuites/blob/master/changelog.md )
- [Commits](https://github.com/jsuites/jsuites/commits )
---
updated-dependencies:
- dependency-name: jsuites
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-07 00:30:33 +01:00
Keegan George
fad0d2ec62
UX: New experimental features should be marked clearly ( #29622 )
...
This PR adds a small visual change to the new feature item on the `/admin/whats-new` page. When features are marked with an experimental site setting, they should show an indication on the feature item that it is "Experimental"
2024-11-06 15:26:30 -08:00
dependabot[bot]
b8295b8b70
Build(deps-dev): Bump @swc/core from 1.8.0 to 1.9.1 ( #29628 )
...
Bumps [@swc/core](https://github.com/swc-project/swc ) from 1.8.0 to 1.9.1.
- [Release notes](https://github.com/swc-project/swc/releases )
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md )
- [Commits](https://github.com/swc-project/swc/compare/v1.8.0...v1.9.1 )
---
updated-dependencies:
- dependency-name: "@swc/core"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-07 00:06:08 +01:00
Renato Atilio
ac33ecdc8c
FIX: pass topic+category to @-mention user search ( #29620 )
...
When replying to a topic, the @-mention userSearch needs the topicId and the categoryId so they can trigger immediately, with sane suggestions.
This was broken when the mentions were moved from ComposerEditor to DEditor.
2024-11-06 15:20:54 -03:00
Jean
708533b1e0
FEATURE: Add links to searchable user fields in users directory and user profile ( #29338 )
...
* FEATURE: Add links to searchable user fields in users directory and user profile
2024-11-06 13:35:30 -04:00
Ella E.
13c7773036
UX: Make the emojis in the admin page table list work better on mobile ( #29619 )
...
* UX: Apply admin table classes for consistent mobile styling on the emojis page
* UX: remove icon from the button
* UX: styling tweaks on the emoji uploader form
* UX: right align table button controls
* apply prettier
2024-11-06 10:25:03 -07:00
David Taylor
0237ef80bd
DEV: Enable ember/no-classic-classes eslint rule ( #28610 )
2024-11-06 13:31:01 +00:00
Jarek Radosz
1ba6f6f1ae
DEV: Update content-tag to 2.0.3 ( #29616 )
2024-11-06 13:29:24 +01:00
Ted Johansson
3be925e161
DEV: Untangle award badge admin CSS ( #29614 )
...
I was skimming through existing pages to get a feel for the admin UI guidelines. I noticed that this part was missing its margin. On some further investigation, it seems that a single CSS selector, .award-badge was being used both for the section and for the button in the header, so I decided to 1) separate the two and 2) add in the missing margin.
2024-11-06 16:10:39 +08:00
Osama Sayegh
6f8f6a7726
FIX: Pass upload type correctly to uploads#create ( #29600 )
...
Prior to Uppy, the `uploads#create` endpoint used to receive a `type` param that indicated the purpose/target of the upload, such as `avatar`, `site_setting` and so on. With the introduction of Uppy, the `type` param became the MIME type of the file being uploaded, and the purpose/target of the upload became a new param called `upload_type`, however the backend could still use the `type` param (which now contains MIME type) as the purpose/target of the upload if `upload_type` is absent.
We technically don't need to send the MIME type over the network, but it seems like it's done by Uppy and we have no control over the `type` param that Uppy includes:
758de8167b/app/assets/javascripts/discourse/app/lib/uppy/uppy-upload.js (L146-L151)
2024-11-06 07:00:35 +03:00
Osama Sayegh
ae721bd0f1
DEV: Fetch settings by area name instead of individual settings ( #29604 )
...
This commit switches the route for the about config page to retrieve the list of site settings that control the /about page by their area instead of their individual names.
Internal topic: t/136384.
2024-11-06 06:56:27 +03:00
Krzysztof Kotlarek
973b599e11
FIX: correctly display category name in replace text modal ( #29612 )
...
Bug introduced in this PR https://github.com/discourse/discourse/pull/23232
The previous modal was using `category.name`
https://github.com/discourse/discourse/pull/23232/files#diff-bfae353a2f3457780e5c281b6a165261cfe552dd9dd791f3859e52d60e22be7fL20
2024-11-06 13:39:52 +11:00
chapoi
8cb8ad763a
UX: add heading role to close composer dialog ( #29590 )
2024-11-06 03:39:37 +01:00
chapoi
fa03499c7e
UX: add missing role attribute ( #29591 )
2024-11-06 03:21:48 +01:00
dependabot[bot]
e2292d4c59
Build(deps): Bump ember-auto-import from 2.9.0 to 2.10.0 ( #29606 )
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Bumps [ember-auto-import](https://github.com/embroider-build/ember-auto-import/tree/HEAD/packages/ember-auto-import ) from 2.9.0 to 2.10.0.
- [Release notes](https://github.com/embroider-build/ember-auto-import/releases )
- [Changelog](https://github.com/embroider-build/ember-auto-import/blob/main/packages/ember-auto-import/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/ember-auto-import/commits/HEAD/packages/ember-auto-import )
---
updated-dependencies:
- dependency-name: ember-auto-import
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-06 01:06:08 +01:00
Jordan Vidrine
cf350ba54c
UX: Make codeblock buttons 'flat' ( #29603 )
2024-11-05 14:45:08 -06:00
Amanda Alves Branquinho
758de8167b
DEV: Add outlet wrapper for user card information replacement ( #29523 )
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
* DEV: Add outlet wrapper for user card information replacement
* Fix format issues
* Fix format issues
2024-11-05 14:03:20 -03:00
Régis Hanol
afdca41fd5
FIX: weird slow auto scrolling on iOS ( #29598 )
...
In some cases, on Safari iOS, we would recompute the "--composer-vh" variable due to a minimal change in the viewport. This ends up triggering a loop where setting this variable triggers another viewport resize event, which triggers another change of the variable...
In order to fix (patch?) this issue, we now have a 1px leeway when checking the difference between the previous and new viewport.
Internal ref - t/141088
2024-11-05 17:58:00 +01:00
Bianca Nenciu
948e283e0f
FIX: Use correct styles on category pages ( #29588 )
...
Multiple category styles can be used on the same site. The category and
subcategories page will use the "desktop_category_page_style" setting
and individual category pages will use the style selected in settings,
if any.
Commit c1f078ca
2024-11-05 23:51:22 +08:00
dependabot[bot]
2aeb529a69
Build(deps-dev): Bump @swc/core from 1.7.42 to 1.8.0 ( #29578 )
...
Bumps [@swc/core](https://github.com/swc-project/swc ) from 1.7.42 to 1.8.0.
- [Release notes](https://github.com/swc-project/swc/releases )
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md )
- [Commits](https://github.com/swc-project/swc/compare/v1.7.42...v1.8.0 )
---
updated-dependencies:
- dependency-name: "@swc/core"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-05 15:36:47 +01:00
dependabot[bot]
0d27c7db70
Build(deps): Bump ace-builds from 1.36.3 to 1.36.4 ( #29579 )
...
Bumps [ace-builds](https://github.com/ajaxorg/ace-builds ) from 1.36.3 to 1.36.4.
- [Release notes](https://github.com/ajaxorg/ace-builds/releases )
- [Changelog](https://github.com/ajaxorg/ace-builds/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ajaxorg/ace-builds/compare/v1.36.3...v1.36.4 )
---
updated-dependencies:
- dependency-name: ace-builds
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-05 15:15:20 +01:00
Jarek Radosz
d076ed8c77
DEV: Convert some simple model methods to async/await ( #29594 )
2024-11-05 14:59:51 +01:00
Juan David Martínez Cubillos
e65367d603
DEV: Add plugin outlet to about.hbs ( #29582 )
...
* DEV: Add plugin outlet to about.hbs
* linter issues
* removed unintended code
2024-11-05 08:33:20 -05:00
Jarek Radosz
a553c9ea0c
FIX: Incorrect reference in TopicListHeaderColumn ( #29593 )
2024-11-05 13:17:41 +01:00
Jarek Radosz
cbfd596b1b
DEV: Remove unnecessary setupController methods ( #29592 )
...
and call super instead of manually setting model
2024-11-05 13:17:32 +01:00
David Taylor
1b5a7be3d4
PERF: Replace slow :has selectors with body classes ( #29581 )
2024-11-05 10:06:13 +11:00
Martin Brennan
b124736a1c
DEV: Convert install theme modal to GJS ( #29506 )
...
We will likely get rid of this at some point, but in the meantime
let's make it easier to modify and bring it up to date.
2024-11-05 09:04:33 +10:00
David Taylor
216845e4c7
DEV: Deprecate template overrides ( #29544 )
...
Template overrides have been advised against for a long time, and are increasingly hard to maintain as Discourse's development accelerates. This commit officially deprecates this customization method, which will be removed in the not-too-distant future (likely in the first half of 2025).
2024-11-04 17:38:33 +00:00
Jarek Radosz
9c5fc6f1df
DEV: Add more-topics plugin API ( #29143 )
...
From plugin-api comment:
Registers a new tab to be displayed in "more topics" area at the bottom of a topic page.
```gjs
api.registerMoreTopicsTab({
id: "other-topics",
name: i18n("other_topics.tab"),
component: <template>tbd</template>,
condition: ({ topic }) => topic.otherTopics?.length > 0,
});
```
You can additionally use more-topics-tabs value transformer to conditionally show/hide
specific tabs.
```js
api.registerValueTransformer("more-topics-tabs", ({ value, context }) => {
if (context.user?.aFeatureFlag) {
// Remove "suggested" from the topics page
return value.filter(
(tab) =>
context.currentContext !== "topic" ||
tab.id !== "suggested-topics"
);
}
});
```
2024-11-04 17:32:49 +01:00
Keegan George
7a936da05c
DEV: Auto grid images no longer experimental ( #29572 )
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Recently we added a new feature for automatically gridding images in the composer (https://github.com/discourse/discourse/pull/29260 ). After testing this feature under a setting for a short period of time, the feature is no longer experimental anymore.
This PR removes the site setting `experimental_auto_grid_images`.
2024-11-04 08:21:40 -08:00
Renato Atilio
b061fd9cc2
DEV: refactor textarea from d-editor ( #29411 )
...
Refactors the DEditor component making it textarea-agnostic.
2024-11-04 12:48:10 -03:00
Renato Atilio
6459ab9320
UX: allow anon users to download calendar ( #29551 )
...
Allows anonymous users to download the calendar file. Before, they were given the option, but it would fail silently with a `TypeError: Cannot read properties of null (reading 'user_option')`.
2024-11-04 12:35:45 -03:00
Jarek Radosz
380974ce00
DEV: Use hasAttribute/hasAria/hasStyle in tests ( #29568 )
2024-11-04 11:30:38 +01:00
Jarek Radosz
9694d2477a
DEV: Convert more notOk assertions ( #29556 )
...
…to either qunit-dom or `strictEqual`
2024-11-04 10:27:30 +01:00
Jarek Radosz
693a4e691b
DEV: Replace ok(true) assertions ( #29555 )
...
…with `verifySteps`, `expect(0)`, or by removing it
2024-11-04 10:27:11 +01:00
Joffrey JAFFEUX
584a9d98ed
DEV: adds is-disabled modifier to form field container ( #29567 )
...
We already had a data-attribute, but a class feels more natural in this case.
2024-11-04 17:57:40 +09:00
dependabot[bot]
a43bd24c67
Build(deps): Bump @faker-js/faker from 9.1.0 to 9.2.0 ( #29562 )
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
Bumps [@faker-js/faker](https://github.com/faker-js/faker ) from 9.1.0 to 9.2.0.
- [Release notes](https://github.com/faker-js/faker/releases )
- [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md )
- [Commits](https://github.com/faker-js/faker/compare/v9.1.0...v9.2.0 )
---
updated-dependencies:
- dependency-name: "@faker-js/faker"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-03 23:18:38 +01:00
Jarek Radosz
b81055a6d4
DEV: Convert more equal assertions ( #29554 )
...
…to either qunit-dom or `strictEqual`
2024-11-03 21:04:38 +01:00
dependabot[bot]
ba7f4e3c63
Build(deps-dev): Bump webpack from 5.96.0 to 5.96.1 ( #29545 )
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
Bumps [webpack](https://github.com/webpack/webpack ) from 5.96.0 to 5.96.1.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.96.0...v5.96.1 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-03 16:26:55 +01:00
David Taylor
323013d9c7
DEV: restore topic argument for after-topic-status outlet ( #29550 )
...
Followup to dd329d55
2024-11-01 18:25:40 +00:00
Sérgio Saquetim
4863b2ab7e
DEV: Added value transformers that mutate the value instead of returning it ( #29537 )
2024-11-01 14:23:46 -03:00
benj
cfc23c43e9
FEATURE - Add username column to custom emoji table ( #29522 )
...
* Adds emoji column for creator username
2024-11-01 10:32:59 -05:00
David Taylor
68c7c8e25d
DEV: Deprecate mobile-specific templates ( #29514 )
...
We are moving away from the mobile-specific template pattern in favor of logical `{{#if}}` statements. This brings us closer to a standard Ember app, makes testing easier, and reduces duplicate code.
This commit includes some minor refactoring in the resolver & component-templates initializer, so that the mobile lookups happen on desktop, without actually being used. This allows us to print the deprecation message consistently, to improve visibility to developers.
2024-11-01 14:51:12 +00:00
David Battersby
8aa4c39c3c
DEV: allow non focused tab to be primary tab in service worker ( #29516 )
...
Follow up to #29388 - when there are no clients in focus, we should take the first visible client as the primary tab.
2024-11-01 09:42:33 +04:00
Martin Brennan
9c17588f6a
FIX: Admin dashboard tooltips not working on mobile ( #29538 )
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
This commit fixes the (?) tooltips for reports on
the admin dashboard on mobile.
The fix is that float-kit instances can now have different triggers
and un-triggers for mobile and desktop, and float-kit is now aware
of the site being in mobile view.
Example usage:
```
@triggers={{hash mobile=(array "click")}}
```
So now, if you press on the tooltip trigger on mobile it shows
correctly, and on desktop both hover and click can be used.
---------
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2024-11-01 12:25:12 +10:00
dependabot[bot]
dd768119aa
Build(deps-dev): Bump webpack from 5.95.0 to 5.96.0 ( #29534 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.95.0 to 5.96.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.95.0...v5.96.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-31 23:48:47 +01:00
dependabot[bot]
816babe387
Build(deps-dev): Bump @swc/core from 1.7.40 to 1.7.42 ( #29526 )
...
Bumps [@swc/core](https://github.com/swc-project/swc ) from 1.7.40 to 1.7.42.
- [Release notes](https://github.com/swc-project/swc/releases )
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md )
- [Commits](https://github.com/swc-project/swc/compare/v1.7.40...v1.7.42 )
---
updated-dependencies:
- dependency-name: "@swc/core"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-31 23:20:54 +01:00
dependabot[bot]
618f4d4dd9
Build(deps): Bump jspreadsheet-ce from 4.14.0 to 4.15.0 ( #29528 )
...
Bumps [jspreadsheet-ce](https://github.com/jspreadsheet/ce ) from 4.14.0 to 4.15.0.
- [Release notes](https://github.com/jspreadsheet/ce/releases )
- [Commits](https://github.com/jspreadsheet/ce/commits )
---
updated-dependencies:
- dependency-name: jspreadsheet-ce
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-31 22:51:49 +01:00
dependabot[bot]
779aacbcf5
Build(deps-dev): Bump ember-qunit from 8.1.0 to 8.1.1 ( #29527 )
...
Bumps [ember-qunit](https://github.com/emberjs/ember-qunit ) from 8.1.0 to 8.1.1.
- [Release notes](https://github.com/emberjs/ember-qunit/releases )
- [Commits](https://github.com/emberjs/ember-qunit/compare/v8.1.0...v8.1.1 )
---
updated-dependencies:
- dependency-name: ember-qunit
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-31 22:35:05 +01:00
dependabot[bot]
2caf5d79ba
Build(deps): Bump @embroider/addon-shim in the embroider group ( #29524 )
...
Bumps the embroider group with 1 update: [@embroider/addon-shim](https://github.com/embroider-build/embroider/tree/HEAD/packages/addon-shim ).
Updates `@embroider/addon-shim` from 1.8.9 to 1.9.0
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/addon-shim )
---
updated-dependencies:
- dependency-name: "@embroider/addon-shim"
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: embroider
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-31 22:31:28 +01:00
dependabot[bot]
db194ac38b
Build(deps-dev): Bump @types/qunit in the types group ( #29525 )
...
Bumps the types group with 1 update: [@types/qunit](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/qunit ).
Updates `@types/qunit` from 2.19.11 to 2.19.12
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/qunit )
---
updated-dependencies:
- dependency-name: "@types/qunit"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-31 22:31:10 +01:00
Keegan George
71f808dea9
DEV: Improve method of presenting link clicks ( #29453 )
...
Licenses / run (push) Waiting to run
Linting / run (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, chat) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (system, themes) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (annotations, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, core) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (backend, plugins) (push) Waiting to run
Tests / ${{ matrix.target }} ${{ matrix.build_type }} (frontend, plugins) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Chrome) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox ESR) (push) Waiting to run
Tests / core frontend (${{ matrix.browser }}) (Firefox Evergreen) (push) Waiting to run
Migration Tests / Tests with Ruby ${{ matrix.ruby }} (3.3) (push) Has been cancelled
Currently the tracking for clicked links are injected into the HTML in a span tag. This leads to the link counter value being highlighted when copying and pasting. Additionally, any means for using CSS to hide link counters result in a gap due to it occupying a specific width.
With this change, we make link counters appear in a data attribute on the link element and visually shown with CSS `::after` element.
2024-10-31 12:44:08 -07:00
Kris
3fb3e3560e
REVERT: "A11Y: topic list links should not be headings ( #27700 )" ( #29520 )
...
This reverts commit 72a5389459
2024-10-31 12:42:55 -04:00
David Taylor
210a295a87
DEV: Remove mobile template for subcategories-with-featured-topics ( #29513 )
...
We are moving away from the mobile-specific template pattern in favor of logical `{{#if}}` statements. This brings us closer to a standard Ember app, makes testing easier, and reduces duplicate code.
2024-10-31 16:12:16 +00:00
