23822 Commits

Author	SHA1	Message	Date
Régis Hanol	afdca41fd5	FIX: weird slow auto scrolling on iOS (#29598) ... In some cases, on Safari iOS, we would recompute the "--composer-vh" variable due to a minimal change in the viewport. This ends up triggering a loop where setting this variable triggers another viewport resize event, which triggers another change of the variable... In order to fix (patch?) this issue, we now have a 1px leeway when checking the difference between the previous and new viewport. Internal ref - t/141088	2024-11-05 17:58:00 +01:00
Bianca Nenciu	948e283e0f	FIX: Use correct styles on category pages (#29588) ... Multiple category styles can be used on the same site. The category and subcategories page will use the "desktop_category_page_style" setting and individual category pages will use the style selected in settings, if any. Commit c1f078ca tried to use the same style for both the category and subcategories page, but the route matching did not take into account the "discovery.categoryAll" and "discovery.categoryNone" variants of the "discovery.category" route.	2024-11-05 23:51:22 +08:00
dependabot[bot]	2aeb529a69	Build(deps-dev): Bump @swc/core from 1.7.42 to 1.8.0 (#29578) ... Bumps [@swc/core](https://github.com/swc-project/swc) from 1.7.42 to 1.8.0. - [Release notes](https://github.com/swc-project/swc/releases) - [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md) - [Commits](https://github.com/swc-project/swc/compare/v1.7.42...v1.8.0) --- updated-dependencies: - dependency-name: "@swc/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-05 15:36:47 +01:00
dependabot[bot]	0d27c7db70	Build(deps): Bump ace-builds from 1.36.3 to 1.36.4 (#29579) ... Bumps [ace-builds](https://github.com/ajaxorg/ace-builds) from 1.36.3 to 1.36.4. - [Release notes](https://github.com/ajaxorg/ace-builds/releases) - [Changelog](https://github.com/ajaxorg/ace-builds/blob/master/CHANGELOG.md) - [Commits](https://github.com/ajaxorg/ace-builds/compare/v1.36.3...v1.36.4) --- updated-dependencies: - dependency-name: ace-builds dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-05 15:15:20 +01:00
Jarek Radosz	d076ed8c77	DEV: Convert some simple model methods to async/await (#29594)	2024-11-05 14:59:51 +01:00
Juan David Martínez Cubillos	e65367d603	DEV: Add plugin outlet to about.hbs (#29582) ... * DEV: Add plugin outlet to about.hbs * linter issues * removed unintended code	2024-11-05 08:33:20 -05:00
Jarek Radosz	a553c9ea0c	FIX: Incorrect reference in TopicListHeaderColumn (#29593)	2024-11-05 13:17:41 +01:00
Jarek Radosz	cbfd596b1b	DEV: Remove unnecessary setupController methods (#29592) ... and call super instead of manually setting model	2024-11-05 13:17:32 +01:00
David Taylor	1b5a7be3d4	PERF: Replace slow :has selectors with body classes (#29581)	2024-11-05 10:06:13 +11:00
Martin Brennan	b124736a1c	DEV: Convert install theme modal to GJS (#29506) ... We will likely get rid of this at some point, but in the meantime let's make it easier to modify and bring it up to date.	2024-11-05 09:04:33 +10:00
David Taylor	216845e4c7	DEV: Deprecate template overrides (#29544) ... Template overrides have been advised against for a long time, and are increasingly hard to maintain as Discourse's development accelerates. This commit officially deprecates this customization method, which will be removed in the not-too-distant future (likely in the first half of 2025).	2024-11-04 17:38:33 +00:00
Jarek Radosz	9c5fc6f1df	DEV: Add more-topics plugin API (#29143) ... From plugin-api comment: Registers a new tab to be displayed in "more topics" area at the bottom of a topic page. ```gjs api.registerMoreTopicsTab({ id: "other-topics", name: i18n("other_topics.tab"), component: <template>tbd</template>, condition: ({ topic }) => topic.otherTopics?.length > 0, }); ``` You can additionally use more-topics-tabs value transformer to conditionally show/hide specific tabs. ```js api.registerValueTransformer("more-topics-tabs", ({ value, context }) => { if (context.user?.aFeatureFlag) { // Remove "suggested" from the topics page return value.filter( (tab) => context.currentContext !== "topic" || tab.id !== "suggested-topics" ); } }); ```	2024-11-04 17:32:49 +01:00
Keegan George	7a936da05c	DEV: Auto grid images no longer experimental (#29572) ... Recently we added a new feature for automatically gridding images in the composer (https://github.com/discourse/discourse/pull/29260). After testing this feature under a setting for a short period of time, the feature is no longer experimental anymore. This PR removes the site setting `experimental_auto_grid_images`.	2024-11-04 08:21:40 -08:00
Kris	1d637c5243	UX: remove extra margin from PM small actions (#29571)	2024-11-04 10:53:35 -05:00
Renato Atilio	b061fd9cc2	DEV: refactor textarea from d-editor (#29411) ... Refactors the DEditor component making it textarea-agnostic.	2024-11-04 12:48:10 -03:00
Renato Atilio	6459ab9320	UX: allow anon users to download calendar (#29551) ... Allows anonymous users to download the calendar file. Before, they were given the option, but it would fail silently with a `TypeError: Cannot read properties of null (reading 'user_option')`.	2024-11-04 12:35:45 -03:00
Kris	d853b5384b	UX: align PM icon when editing title, allow shrink-to-fit (#29570)	2024-11-04 10:31:11 -05:00
Jarek Radosz	380974ce00	DEV: Use hasAttribute/hasAria/hasStyle in tests (#29568)	2024-11-04 11:30:38 +01:00
Jarek Radosz	9694d2477a	DEV: Convert more notOk assertions (#29556) ... …to either qunit-dom or `strictEqual`	2024-11-04 10:27:30 +01:00
Jarek Radosz	693a4e691b	DEV: Replace ok(true) assertions (#29555) ... …with `verifySteps`, `expect(0)`, or by removing it	2024-11-04 10:27:11 +01:00
Joffrey JAFFEUX	584a9d98ed	DEV: adds is-disabled modifier to form field container (#29567) ... We already had a data-attribute, but a class feels more natural in this case.	2024-11-04 17:57:40 +09:00
dependabot[bot]	a43bd24c67	Build(deps): Bump @faker-js/faker from 9.1.0 to 9.2.0 (#29562) ... Bumps [@faker-js/faker](https://github.com/faker-js/faker) from 9.1.0 to 9.2.0. - [Release notes](https://github.com/faker-js/faker/releases) - [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md) - [Commits](https://github.com/faker-js/faker/compare/v9.1.0...v9.2.0) --- updated-dependencies: - dependency-name: "@faker-js/faker" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-03 23:18:38 +01:00
Jarek Radosz	b81055a6d4	DEV: Convert more equal assertions (#29554) ... …to either qunit-dom or `strictEqual`	2024-11-03 21:04:38 +01:00
dependabot[bot]	ba7f4e3c63	Build(deps-dev): Bump webpack from 5.96.0 to 5.96.1 (#29545) ... Bumps [webpack](https://github.com/webpack/webpack) from 5.96.0 to 5.96.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](https://github.com/webpack/webpack/compare/v5.96.0...v5.96.1) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-03 16:26:55 +01:00
David Taylor	323013d9c7	DEV: restore topic argument for after-topic-status outlet (#29550) ... Followup to dd329d55	2024-11-01 18:25:40 +00:00
Sérgio Saquetim	4863b2ab7e	DEV: Added value transformers that mutate the value instead of returning it (#29537)	2024-11-01 14:23:46 -03:00
benj	cfc23c43e9	FEATURE - Add username column to custom emoji table (#29522) ... * Adds emoji column for creator username	2024-11-01 10:32:59 -05:00
David Taylor	68c7c8e25d	DEV: Deprecate mobile-specific templates (#29514) ... We are moving away from the mobile-specific template pattern in favor of logical `{{#if}}` statements. This brings us closer to a standard Ember app, makes testing easier, and reduces duplicate code. This commit includes some minor refactoring in the resolver & component-templates initializer, so that the mobile lookups happen on desktop, without actually being used. This allows us to print the deprecation message consistently, to improve visibility to developers.	2024-11-01 14:51:12 +00:00
David Battersby	8aa4c39c3c	DEV: allow non focused tab to be primary tab in service worker (#29516) ... Follow up to #29388 - when there are no clients in focus, we should take the first visible client as the primary tab.	2024-11-01 09:42:33 +04:00
Martin Brennan	9c17588f6a	FIX: Admin dashboard tooltips not working on mobile (#29538) ... This commit fixes the (?) tooltips for reports on the admin dashboard on mobile. The fix is that float-kit instances can now have different triggers and un-triggers for mobile and desktop, and float-kit is now aware of the site being in mobile view. Example usage: ``` @triggers={{hash mobile=(array "click")}} ``` So now, if you press on the tooltip trigger on mobile it shows correctly, and on desktop both hover and click can be used. --------- Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>	2024-11-01 12:25:12 +10:00
dependabot[bot]	dd768119aa	Build(deps-dev): Bump webpack from 5.95.0 to 5.96.0 (#29534) ... Bumps [webpack](https://github.com/webpack/webpack) from 5.95.0 to 5.96.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](https://github.com/webpack/webpack/compare/v5.95.0...v5.96.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-31 23:48:47 +01:00
dependabot[bot]	816babe387	Build(deps-dev): Bump @swc/core from 1.7.40 to 1.7.42 (#29526) ... Bumps [@swc/core](https://github.com/swc-project/swc) from 1.7.40 to 1.7.42. - [Release notes](https://github.com/swc-project/swc/releases) - [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md) - [Commits](https://github.com/swc-project/swc/compare/v1.7.40...v1.7.42) --- updated-dependencies: - dependency-name: "@swc/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-31 23:20:54 +01:00
dependabot[bot]	618f4d4dd9	Build(deps): Bump jspreadsheet-ce from 4.14.0 to 4.15.0 (#29528) ... Bumps [jspreadsheet-ce](https://github.com/jspreadsheet/ce) from 4.14.0 to 4.15.0. - [Release notes](https://github.com/jspreadsheet/ce/releases) - [Commits](https://github.com/jspreadsheet/ce/commits) --- updated-dependencies: - dependency-name: jspreadsheet-ce dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-31 22:51:49 +01:00
dependabot[bot]	779aacbcf5	Build(deps-dev): Bump ember-qunit from 8.1.0 to 8.1.1 (#29527) ... Bumps [ember-qunit](https://github.com/emberjs/ember-qunit) from 8.1.0 to 8.1.1. - [Release notes](https://github.com/emberjs/ember-qunit/releases) - [Commits](https://github.com/emberjs/ember-qunit/compare/v8.1.0...v8.1.1) --- updated-dependencies: - dependency-name: ember-qunit dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-31 22:35:05 +01:00
dependabot[bot]	2caf5d79ba	Build(deps): Bump @embroider/addon-shim in the embroider group (#29524) ... Bumps the embroider group with 1 update: [@embroider/addon-shim](https://github.com/embroider-build/embroider/tree/HEAD/packages/addon-shim). Updates `@embroider/addon-shim` from 1.8.9 to 1.9.0 - [Release notes](https://github.com/embroider-build/embroider/releases) - [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md) - [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/addon-shim) --- updated-dependencies: - dependency-name: "@embroider/addon-shim" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: embroider ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-31 22:31:28 +01:00
dependabot[bot]	db194ac38b	Build(deps-dev): Bump @types/qunit in the types group (#29525) ... Bumps the types group with 1 update: [@types/qunit](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/qunit). Updates `@types/qunit` from 2.19.11 to 2.19.12 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/qunit) --- updated-dependencies: - dependency-name: "@types/qunit" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: types ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-31 22:31:10 +01:00
Keegan George	71f808dea9	DEV: Improve method of presenting link clicks (#29453) ... Currently the tracking for clicked links are injected into the HTML in a span tag. This leads to the link counter value being highlighted when copying and pasting. Additionally, any means for using CSS to hide link counters result in a gap due to it occupying a specific width. With this change, we make link counters appear in a data attribute on the link element and visually shown with CSS `::after` element.	2024-10-31 12:44:08 -07:00
Kris	3fb3e3560e	REVERT: "A11Y: topic list links should not be headings (#27700)" (#29520) ... This reverts commit 72a5389459.	2024-10-31 12:42:55 -04:00
David Taylor	210a295a87	DEV: Remove mobile template for subcategories-with-featured-topics (#29513) ... We are moving away from the mobile-specific template pattern in favor of logical `{{#if}}` statements. This brings us closer to a standard Ember app, makes testing easier, and reduces duplicate code.	2024-10-31 16:12:16 +00:00
David Taylor	8300380287	DEV: Remove mobile-specific template for sub-category-* (#29512) ... We are moving away from the mobile-specific template pattern in favor of logical `{{#if}}` statements. This brings us closer to a standard Ember app, makes testing easier, and reduces duplicate code.	2024-10-31 16:12:00 +00:00
David Taylor	8bb360d849	DEV: Remove mobile-specific template for parent-category-row (#29511) ... We are moving away from the mobile-specific template pattern in favor of logical `{{#if}}` statements. This brings us closer to a standard Ember app, makes testing easier, and reduces duplicate code.	2024-10-31 16:11:52 +00:00
David Taylor	ee05a7244a	DEV: Remove mobile-specific template for categories-only-optimized (#29510) ... We are moving away from the mobile-specific template pattern in favor of logical `{{#if}}` statements. This brings us closer to a standard Ember app, makes testing easier, and reduces duplicate code.	2024-10-31 16:11:45 +00:00
David Taylor	a2fe8ed206	DEV: Remove mobile-specific template for categories-only (#29509) ... We are moving away from the mobile-specific template pattern in favor of logical `{{#if}}` statements. This brings us closer to a standard Ember app, makes testing easier, and reduces duplicate code.	2024-10-31 16:11:37 +00:00
Penar Musaraj	c8e03f251f	DEV: Remove body docked class and its scroll event listener (#29515) ... Docking is a leftover from older header code, it looks like it is no longer used in the app. This helper was registering a scroll event listener to check if the header should be docked or not. Initially, a "docked" class was added to the body element. This class persisted through the lifecycle of the app and the scroll event was doing no useful work. Some older themes may still use it in CSS, that will cause a regression, from a quick look at existing code, the surface area should be small (2-3 themes). It's worth removing the event listener for performance reasons. We could possibly add the class "docked" statically to the body element, but it's redundant. It's best to clean up the relevant CSS in themes, where applicable.	2024-10-31 10:21:50 -04:00
Penar Musaraj	041ac3d8b7	DEV: Refactor header offset calculations (#29398)	2024-10-31 09:50:01 -04:00
Jarek Radosz	4b533c47f0	DEV: Update sidebar plugin api tests (#29507)	2024-10-31 12:26:25 +01:00
Jarek Radosz	b44b136b84	DEV: Add back-compat to recently converted computed props (#29508)	2024-10-31 12:25:21 +01:00
Osama Sayegh	0ad1c02932	FEATURE: Add 'Community title' field to about config page (#29500) ... This commit adds a new "Community title" field to the about config page. This field controls the `short_site_description` setting, which is shown in the browser tab for key pages such categories pages and topic lists. Internal topic: t/140812.	2024-10-31 10:04:31 +03:00
Jarek Radosz	dc96b6e953	DEV: Add owner arg to plugin connector's shouldRender callbacks (#29488)	2024-10-31 01:06:02 +01:00
Jarek Radosz	ae8d919528	DEV: Deprecate htmlHelper (#29495)	2024-10-31 00:37:37 +01:00
dependabot[bot]	33b2845adc	Build(deps): Bump ember-auto-import from 2.8.1 to 2.9.0 (#29497) ... Bumps [ember-auto-import](https://github.com/embroider-build/ember-auto-import/tree/HEAD/packages/ember-auto-import) from 2.8.1 to 2.9.0. - [Release notes](https://github.com/embroider-build/ember-auto-import/releases) - [Changelog](https://github.com/embroider-build/ember-auto-import/blob/main/packages/ember-auto-import/CHANGELOG.md) - [Commits](https://github.com/embroider-build/ember-auto-import/commits/HEAD/packages/ember-auto-import) --- updated-dependencies: - dependency-name: ember-auto-import dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-31 00:37:29 +01:00
dependabot[bot]	789de08e9f	Build(deps-dev): Bump @floating-ui/dom from 1.6.11 to 1.6.12 (#29498) ... Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom) from 1.6.11 to 1.6.12. - [Release notes](https://github.com/floating-ui/floating-ui/releases) - [Changelog](https://github.com/floating-ui/floating-ui/blob/master/packages/dom/CHANGELOG.md) - [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.6.12/packages/dom) --- updated-dependencies: - dependency-name: "@floating-ui/dom" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-30 23:42:36 +01:00
dependabot[bot]	c433ca7cf2	Build(deps): Bump @babel/standalone in the babel group (#29496) ... Bumps the babel group with 1 update: [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone). Updates `@babel/standalone` from 7.26.1 to 7.26.2 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.2/packages/babel-standalone) --- updated-dependencies: - dependency-name: "@babel/standalone" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: babel ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-30 23:22:37 +01:00
Jan Cernik	81396467d0	UX: More improvements to login/signup forms (#29417)	2024-10-30 13:33:06 -03:00
Bianca Nenciu	430c42acde	FEATURE: Conditionally force optimized category style (#29473) ... The `categories_only_optimized` category page style has been introduced in commit d37a0d401c. This commit makes sure that style is enforced for users who can see over 1000 categories in order to keep `/categories` page functional.	2024-10-30 16:46:56 +02:00
Jarek Radosz	cf156d0f51	DEV: Convert topic-timeline to gjs (#29483)	2024-10-30 11:13:38 +01:00
Jarek Radosz	671f7beadb	DEV: Convert TopicNavigationPopup to gjs (#29476)	2024-10-30 11:13:31 +01:00
Jarek Radosz	81b95d3202	DEV: Convert timeline sub-components to gjs (#29475)	2024-10-30 11:13:21 +01:00
Martin Brennan	8fb2e2a3ec	UX: Fix No button on review queue on mobile (#29485) ... The "No" button for flagged posts was a different size on mobile	2024-10-30 15:37:11 +10:00
Osama Sayegh	19672faba6	FEATURE: Add invite link to the sidebar (#29448) ... This commit adds a new "Invite" link to the sidebar for all users who can invite to the site. Clicking the link opens the invite modal without changing the current route the user is on. Admins can customize the new link or remove it entirely if they wish by editing the sidebar section. Internal topic: t/129752.	2024-10-30 05:31:14 +03:00
Bianca Nenciu	9a80d71882	FEATURE: Add links to subcategories page on category page (#29474) ... This applies only to the optimized category page style.	2024-10-29 20:47:46 +02:00
Ella E.	921e7b275b	UX: Move BackButton outside admin-config-area to prevent unintended wrapping (#29457)	2024-10-29 10:23:54 -06:00
Osama Sayegh	2ffe413b0b	FEATURE: Enable the new /about page for everyone (#29390) ... This commit removes the feature flag for the new /about page, enabling it for all sites, and removes the code for old the /about page. Internal topic: t/140413.	2024-10-29 18:40:11 +03:00
Jarek Radosz	cc447a1ae3	DEV: Simplify TopicNotificationsButton (#29465)	2024-10-29 16:27:23 +01:00
Jarek Radosz	6d918c6307	UX: Remove the admin menu button from expanded mobile timeline (#29464)	2024-10-29 12:12:00 +01:00
David Taylor	b364a13ad3	DEV: Update dynamic component hbs syntax (#29445) ... The block form of `{{#component` is not supported by Glint tooling. They recommend using this `{{#let`-based syntax to achieve the same result	2024-10-29 11:11:10 +00:00
David Taylor	336d98732d	DEV: Correct test following 7af72804 (#29463) ... Looks like the test was previously asserting the broken behaviour 🤦‍♂️	2024-10-29 10:47:57 +00:00
Akshay Birajdar	a1c9486e3f	FIX: Missing glimmer topic list focus actions on mobile (#29421)	2024-10-29 11:26:05 +01:00
Natalie Tay	7af728048c	FIX: Copy upon getting logged out (#29462)	2024-10-29 18:19:54 +08:00
Jarek Radosz	ecdf199585	DEV: Refactor composer-/topic-presence-display (#29455) ... Re-land #29262 as the d-shared-edits incompatibility has now been resolved. This reverts commit a59c07fc45.	2024-10-29 10:44:05 +01:00
Jarek Radosz	ffd3500f0b	DEV: Remove unused component args (#29454)	2024-10-29 10:43:55 +01:00
chapoi	04aed79028	UX: lower copy link z-index (#29458)	2024-10-29 10:35:14 +01:00
David Battersby	7bcd46b87d	DEV: use service worker for chat sound (#29388) ... This change makes use of service workers to determine if we should play chat sounds in the current browser tab. Since users can have multiple tabs open, we currently attempt to play sound across all active tabs. With this change we iterate over all clients and check if client.focused is true (ie. the current tab/window we have open), if so we allow playing the audio in the current tab and for all other hidden tabs/windows we return false. --------- Co-authored-by: Bianca Nenciu <nbianca@users.noreply.github.com>	2024-10-29 13:15:53 +04:00
Jordan Vidrine	f902e0fdd7	UX: Look and feel changes (#29245) ... This PR: - Removes components from being displayed in the card - Adds a DMenu to house previous footer actions - Allows themes to be updated from this grid, with an animation and different border to show the update is happening - Stops position of cards changing when default changes - Fixes outline colour not changing when default changes - Show a global notice on the page when previewing a theme - Allows updating a theme from the grid, and showing an indicator of what theme needs to be updated - Moves "Set as default" to the dropdown for the theme - Show screenshot for theme if it is available - Prevent page reloading when updating the theme - Fixes theme install modal on grid page - Temporarily remove sorting of default theme to the top	2024-10-29 12:25:17 +10:00
Sam	4d7f70b923	FEATURE: do not insert smart list if SHIFT+Enter is pressed (#29452) ... A common pattern in the industry for bypassing smart lists is detection of the shift key. This information is not available in the "beforeinput" event but it always fires afer keydown, so we track if shift is pressed on keydown.	2024-10-29 09:18:52 +10:00
David Taylor	9230d4e7f2	DEV: Update remaining mixins to remove object-literal decorators (#29444) ... These are unsupported by modern tooling (including ts/glint parsers), so we are working to remove them. The easiest path for mixins is to switch back to the mega-legacy EmberObject syntax for computed/on)	2024-10-28 19:38:52 +00:00
David Taylor	2aed7606a7	DEV: Remove final object-literal decorator from plugin-api-test (#29446)	2024-10-28 19:38:17 +00:00
Ella E.	311c042700	UX: Add description config area card (#29418) ... * DEV: add a description to the config area card component * UX: update strings and placeholders for your org config area card	2024-10-28 09:39:51 -06:00
David Taylor	de16947b9b	DEV: Update emoji-picker.js to native class syntax (#29438)	2024-10-28 15:27:49 +00:00
David Taylor	8ee00dcbd0	DEV: Update tests to remove/ignore classic-class uses (#29440) ... In preparation for https://github.com/discourse/discourse/pull/28610	2024-10-28 15:04:29 +00:00
Kris	ca693b53eb	UX: limit user-card focus ring to desktop (#29435)	2024-10-28 10:10:03 -04:00
David Taylor	aa89acbda6	DEV: Upgrade Uppy to v4 (#29397) ... Key changes include: - `@uppy/aws-s3-multipart` is now part of `@uppy/aws-s3`, and controlled with a boolean - Some minor changes/renames to Uppy APIs - Uppy has removed batch signing from their S3 multipart implementation. This commit implements a batching system outside of Uppy to avoid needing one-signing-request-per-part - Reduces concurrent part uploads to 6, because S3 uses HTTP/1.1 and browsers limit concurrent connections to 6-per-host. - Upstream drop-target implementation has changed slightly, so we now need `pointer-events: none` on the hover element	2024-10-28 14:01:44 +00:00
Martin Brennan	27bdfb6437	FEATURE: Add user preference to disable smart lists (#29434) ... Followup 30fdd7738e Adds a new site setting and corresponding user preference to disable smart lists. By default they are enabled, because this is a better experience for most users. A small number of users would prefer to not have this enabled. Smart lists automatically append new items to each list started in the composer when enter is pressed. If enter is pressed on an empty list item, it is cleared. This setting will be removed when the new composer is complete.	2024-10-28 14:18:15 +10:00
Martin Brennan	456fbb1dbf	FEATURE: Allow themes to define screenshots (#29079) ... This commit allows themes to define up to 2 screenshots in about.json. These should be paths within the theme's git repository, images with a 1MB max file size and max width 3840x2160. These screenshots will be downloaded and stored against a theme field, and we will use these in the redesigned theme grid UI. These screenshots will be updated when the theme is updated in the same way the additional theme files are. For now this is gated behind a hidden `theme_download_screenshots` site setting, to allow us to test this on a small number of sites without making other sites make unnecessary uploads. **Future considerations:** * We may want to have a specialized naming system for screenshots. E.g. having light.png/dark.png/some_palette.png * We may want to show more than one screenshot for the theme, maybe in a carousel or reacting to dark mode or color palette changes * We may want to allow clicking on the theme screenshot to show a lightbox * We may want to make an optimized thumbnail image for the theme grid --------- Co-authored-by: Ted Johansson <ted@discourse.org>	2024-10-28 10:10:20 +10:00
dependabot[bot]	3ff453fdf1	Build(deps-dev): Bump @swc/core from 1.7.39 to 1.7.40 (#29424) ... Bumps [@swc/core](https://github.com/swc-project/swc) from 1.7.39 to 1.7.40. - [Release notes](https://github.com/swc-project/swc/releases) - [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md) - [Commits](https://github.com/swc-project/swc/compare/v1.7.39...v1.7.40) --- updated-dependencies: - dependency-name: "@swc/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-28 00:09:10 +01:00
dependabot[bot]	49180d514f	Build(deps-dev): Bump jsuites from 5.6.5 to 5.6.6 (#29429) ... Bumps [jsuites](https://github.com/jsuites/jsuites) from 5.6.5 to 5.6.6. - [Release notes](https://github.com/jsuites/jsuites/releases) - [Changelog](https://github.com/jsuites/jsuites/blob/master/changelog.md) - [Commits](https://github.com/jsuites/jsuites/commits) --- updated-dependencies: - dependency-name: jsuites dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-28 00:09:03 +01:00
dependabot[bot]	2809cf1c4d	Build(deps-dev): Bump @ember/optional-features from 2.1.0 to 2.2.0 (#29427) ... Bumps [@ember/optional-features](https://github.com/emberjs/ember-optional-features) from 2.1.0 to 2.2.0. - [Release notes](https://github.com/emberjs/ember-optional-features/releases) - [Changelog](https://github.com/emberjs/ember-optional-features/blob/master/CHANGELOG.md) - [Commits](https://github.com/emberjs/ember-optional-features/commits) --- updated-dependencies: - dependency-name: "@ember/optional-features" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-27 23:20:31 +01:00
dependabot[bot]	7c56117207	Build(deps): Bump @faker-js/faker from 9.0.3 to 9.1.0 (#29425) ... Bumps [@faker-js/faker](https://github.com/faker-js/faker) from 9.0.3 to 9.1.0. - [Release notes](https://github.com/faker-js/faker/releases) - [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md) - [Commits](https://github.com/faker-js/faker/compare/v9.0.3...v9.1.0) --- updated-dependencies: - dependency-name: "@faker-js/faker" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-27 23:19:51 +01:00
dependabot[bot]	0108e7048a	Build(deps): Bump the babel group with 2 updates (#29423) ... Bumps the babel group with 2 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) and [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone). Updates `@babel/core` from 7.25.9 to 7.26.0 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.0/packages/babel-core) Updates `@babel/standalone` from 7.25.9 to 7.26.1 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.1/packages/babel-standalone) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: babel - dependency-name: "@babel/standalone" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: babel ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-27 23:06:49 +01:00
Isaac Janzen	1d2b6dbb01	DEV: Add disableDefaultKeyboardShortcuts plugin API to disable default keyboard shortcuts (#29401) ... # Context Add `disableDefaultKeyboardShortcuts` function to the plugin API to allow for disabling [default bindings](e4941278b2/app/assets/javascripts/discourse/app/lib/keyboard-shortcuts.js (L49)). # Details This function is used to disable a "default" keyboard shortcut. You can pass an array of shortcut bindings as strings to disable them. **Please note that this function must be called from a pre-initializer.** Example: ```js api.disableDefaultKeyboardShortcuts(['command+f', 'shift+c']); ``` - Added system spec, displaying intended behavior	2024-10-25 14:14:04 -05:00
Kris	74bb520877	A11Y: fix and improve user card accessibility (#29399)	2024-10-25 12:43:43 -04:00
Ella E.	92cd2818ad	UX: Update /about config page copy (#29387) ... * UX: Update formkit description copy * UX: Remove unused string	2024-10-25 09:54:28 -06:00
David Taylor	3076b6e8d2	PERF: Update maybeContinueList to avoid replacing the entire post (#29416) ... Using execCommand to replace the entire contents of the textarea is very slow for larger posts (it seems the browser does a reflow after every 'virtual keypress'). This commit updates the `maybeContinueList()` function to be more surgical when removing the bullet. Now it only selects & removes the characters which actually need to be deleted Similar to a7cd220704	2024-10-25 16:37:09 +01:00
chapoi	8ac1f6ad9a	UX: Visual adjustments to login/signup forms (#28680) ... This adds several improvements to the signup/login forms. Some of them include: - Added a minimal signup progress bar design for mobile. - Made the signup/login modals full height on mobile. - Improved the activation, account creation, and login-required pages on mobile. - Removed the subheader and emoji from the welcome component. - Removed most input instructions. - Used consistent font size for text below the inputs. - Displayed input instructions only when the field is focused. - Improved the vertical alignment of input labels. - Increased the spacing between inputs. - Fixed label positioning for custom fields. - Moved the "(optional)" text for the name input outside the instructions. - Disabled buttons during login to prevent layout shifts. - Reused the CTA component for modals as well. - Matched the invite CTA styles with the signup form. --------- Co-authored-by: Jan Cernik <jancernik12@gmail.com> Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>	2024-10-25 09:34:59 -03:00
David Taylor	7d2aea4d69	DEV: Deprecate uppy-upload-mixin (#29394)	2024-10-24 20:47:25 +01:00
Penar Musaraj	9b1c6f8384	FIX: remove redundant body scroll lock (#29395) ... PR #26784 adds the scroll lock in the modal which renders this second scroll lock for SK component redundant. Having it there in fact causes issues on iPads, where it isn't necessary.	2024-10-24 13:41:08 -04:00
Amanda Alves Branquinho	0ecad3a7c9	DEV: Add outlet wrapper for user badges form (#29333) ... * DEV: Add outlet wrapper for user badges form * Add outlet for badge granter table * add extra args to outlet	2024-10-24 11:10:10 -03:00
Jan Cernik	0983e73c2c	FIX: Enable scroll events in modals for IOS (#29393)	2024-10-24 10:04:03 -04:00
Jan Cernik	ed40c8bfd0	FIX: Remove scroll events for mobile modals (#29391) ... * FIX: Remove scroll events for mobile modals This causes some issues with different devices. We want to test the side effects of removing this.	2024-10-24 10:18:51 -03:00
David Taylor	f84f7436c5	DEV: Allow parent method to be called using super. in modifyClass (#29389)	2024-10-24 12:11:02 +01:00