4 Commits

Author	SHA1	Message	Date
Bianca Nenciu	05ac4f4091	FIX: Do not try to show logo if it does not exist (#12968) ... The generator tried to include the logo in the certificate, even when it did not exist and that caused a server error.	2021-05-06 19:09:04 +03:00
Rafael dos Santos Silva	bf5611f7eb	FIX: Make discobot certificate faster/non blocking (#11344) ... This moves the way we add the user avatar and site logo to the discobot certificates from embeded base64 png to just using the files urls in the href to the image tag. This will make generation faster and the certificate smaller overall, but it can't be used in a `img` tag anymore, since SVGs in `img` tags don't load the external images In order to work around that we will move the certificate in posts to an iframe, which works fine without any user visible changes. For this to be possible the plugin automatically adds the site current domain to the list of allowed iframe origins.	2021-02-01 20:49:32 -03:00
Vinoth Kannan	039b4111e3	FIX: print raw html of logo image to skip unwanted html encoding (#11805) ... Currently, the image logo is broken since the image tag is rendering incorrectly.	2021-01-22 19:48:01 +05:30
Krzysztof Kotlarek	e2f9b7dd6f	FIX: Narrative Bot certificates are ERB templates (#8174) ... There are at least two ways of rendering templates outside of the controller. The first one is Rails way enabled with Rails 5 https://evilmartians.com/chronicles/new-feature-in-rails-5-render-views-outside-of-actions The downside of this method is that all variables need to be passed as params (I could find a way to pass the whole context) Another way is to use instance_eval described in Erubi documentation https://github.com/jeremyevans/erubi#usage - it works perfectly fine, however, I didn't feel very confident about using eval unless necessary. An additional benefit of using `ApplicationController.render` is that if Rails would change the ERB engine in the future, this code should still work. If you want to test it on your local, you need to be signed in and then that two URLs are generating certificates: http://localhost:3000/discobot/certificate.svg?date=Oct+07+2019&type=standard&user_id=1 http://localhost:3000/discobot/certificate.svg?date=Oct+07+2019&type=advanced&user_id=1 Dev: https://dev.discourse.org/t/discourse-narrative-bot-should-not-be-storing-giant-strings/17130	2019-10-09 17:45:01 +11:00