33518 Commits

Author	SHA1	Message	Date
David Taylor	0237ef80bd	DEV: Enable ember/no-classic-classes eslint rule (#28610)	2024-11-06 13:31:01 +00:00
Jarek Radosz	1ba6f6f1ae	DEV: Update content-tag to 2.0.3 (#29616)	2024-11-06 13:29:24 +01:00
Loïc Guitaut	5177aef37d	FIX: Don’t try to serialize associations in PostRevisionSerializer ... Currently, if an association is added as a tracked field in `PostRevisor`, the `PostRevisionSerializer` class will try to serialize it somehow. This will raise an error as ActiveRecord collection proxies can't be serialized. This patch addresses this issue by skipping any association tracked by the `PostRevisor` class.	2024-11-06 10:38:41 +01:00
Ted Johansson	3be925e161	DEV: Untangle award badge admin CSS (#29614) ... I was skimming through existing pages to get a feel for the admin UI guidelines. I noticed that this part was missing its margin. On some further investigation, it seems that a single CSS selector, .award-badge was being used both for the section and for the button in the header, so I decided to 1) separate the two and 2) add in the missing margin.	2024-11-06 16:10:39 +08:00
chapoi	a097d86eea	UX: fix visibility of grant badge modal dropdowns (#29613)	2024-11-06 07:30:13 +01:00
Osama Sayegh	6f8f6a7726	FIX: Pass upload type correctly to uploads#create (#29600) ... Prior to Uppy, the `uploads#create` endpoint used to receive a `type` param that indicated the purpose/target of the upload, such as `avatar`, `site_setting` and so on. With the introduction of Uppy, the `type` param became the MIME type of the file being uploaded, and the purpose/target of the upload became a new param called `upload_type`, however the backend could still use the `type` param (which now contains MIME type) as the purpose/target of the upload if `upload_type` is absent. We technically don't need to send the MIME type over the network, but it seems like it's done by Uppy and we have no control over the `type` param that Uppy includes: 758de8167b/app/assets/javascripts/discourse/app/lib/uppy/uppy-upload.js (L146-L151) This commit does a couple of things: 1. It amends the `uploads#create` endpoint so it always requires the `upload_type` param and doesn't fallback to `type` if `upload_type` is absent 2. It forces consumers of the `UppyUpload` class (and by extension `UppyImageUploader`) to specify `type` of the upload Internal topic: t/140945.	2024-11-06 07:00:35 +03:00
Osama Sayegh	ae721bd0f1	DEV: Fetch settings by area name instead of individual settings (#29604) ... This commit switches the route for the about config page to retrieve the list of site settings that control the /about page by their area instead of their individual names. Internal topic: t/136384.	2024-11-06 06:56:27 +03:00
Krzysztof Kotlarek	973b599e11	FIX: correctly display category name in replace text modal (#29612) ... Bug introduced in this PR https://github.com/discourse/discourse/pull/23232 The previous modal was using `category.name` https://github.com/discourse/discourse/pull/23232/files#diff-bfae353a2f3457780e5c281b6a165261cfe552dd9dd791f3859e52d60e22be7fL20	2024-11-06 13:39:52 +11:00
chapoi	8cb8ad763a	UX: add heading role to close composer dialog (#29590)	2024-11-06 03:39:37 +01:00
chapoi	fa03499c7e	UX: add missing role attribute (#29591)	2024-11-06 03:21:48 +01:00
dependabot[bot]	e2292d4c59	Build(deps): Bump ember-auto-import from 2.9.0 to 2.10.0 (#29606) ... Bumps [ember-auto-import](https://github.com/embroider-build/ember-auto-import/tree/HEAD/packages/ember-auto-import) from 2.9.0 to 2.10.0. - [Release notes](https://github.com/embroider-build/ember-auto-import/releases) - [Changelog](https://github.com/embroider-build/ember-auto-import/blob/main/packages/ember-auto-import/CHANGELOG.md) - [Commits](https://github.com/embroider-build/ember-auto-import/commits/HEAD/packages/ember-auto-import) --- updated-dependencies: - dependency-name: ember-auto-import dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-06 01:06:08 +01:00
Alan Guo Xiang Tan	57f4176b57	DEV: Bump rubocop_discourse (#29608)	2024-11-06 06:27:49 +08:00
Jordan Vidrine	cf350ba54c	UX: Make codeblock buttons 'flat' (#29603)	2024-11-05 14:45:08 -06:00
Amanda Alves Branquinho	758de8167b	DEV: Add outlet wrapper for user card information replacement (#29523) ... * DEV: Add outlet wrapper for user card information replacement * Fix format issues * Fix format issues	2024-11-05 14:03:20 -03:00
Régis Hanol	afdca41fd5	FIX: weird slow auto scrolling on iOS (#29598) ... In some cases, on Safari iOS, we would recompute the "--composer-vh" variable due to a minimal change in the viewport. This ends up triggering a loop where setting this variable triggers another viewport resize event, which triggers another change of the variable... In order to fix (patch?) this issue, we now have a 1px leeway when checking the difference between the previous and new viewport. Internal ref - t/141088	2024-11-05 17:58:00 +01:00
Bianca Nenciu	948e283e0f	FIX: Use correct styles on category pages (#29588) ... Multiple category styles can be used on the same site. The category and subcategories page will use the "desktop_category_page_style" setting and individual category pages will use the style selected in settings, if any. Commit c1f078ca tried to use the same style for both the category and subcategories page, but the route matching did not take into account the "discovery.categoryAll" and "discovery.categoryNone" variants of the "discovery.category" route.	2024-11-05 23:51:22 +08:00
dependabot[bot]	2aeb529a69	Build(deps-dev): Bump @swc/core from 1.7.42 to 1.8.0 (#29578) ... Bumps [@swc/core](https://github.com/swc-project/swc) from 1.7.42 to 1.8.0. - [Release notes](https://github.com/swc-project/swc/releases) - [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md) - [Commits](https://github.com/swc-project/swc/compare/v1.7.42...v1.8.0) --- updated-dependencies: - dependency-name: "@swc/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-05 15:36:47 +01:00
dependabot[bot]	0d27c7db70	Build(deps): Bump ace-builds from 1.36.3 to 1.36.4 (#29579) ... Bumps [ace-builds](https://github.com/ajaxorg/ace-builds) from 1.36.3 to 1.36.4. - [Release notes](https://github.com/ajaxorg/ace-builds/releases) - [Changelog](https://github.com/ajaxorg/ace-builds/blob/master/CHANGELOG.md) - [Commits](https://github.com/ajaxorg/ace-builds/compare/v1.36.3...v1.36.4) --- updated-dependencies: - dependency-name: ace-builds dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-05 15:15:20 +01:00
Jarek Radosz	d076ed8c77	DEV: Convert some simple model methods to async/await (#29594)	2024-11-05 14:59:51 +01:00
Juan David Martínez Cubillos	e65367d603	DEV: Add plugin outlet to about.hbs (#29582) ... * DEV: Add plugin outlet to about.hbs * linter issues * removed unintended code	2024-11-05 08:33:20 -05:00
Jarek Radosz	a553c9ea0c	FIX: Incorrect reference in TopicListHeaderColumn (#29593)	2024-11-05 13:17:41 +01:00
Jarek Radosz	cbfd596b1b	DEV: Remove unnecessary setupController methods (#29592) ... and call super instead of manually setting model	2024-11-05 13:17:32 +01:00
David Taylor	1b5a7be3d4	PERF: Replace slow :has selectors with body classes (#29581)	2024-11-05 10:06:13 +11:00
Martin Brennan	b124736a1c	DEV: Convert install theme modal to GJS (#29506) ... We will likely get rid of this at some point, but in the meantime let's make it easier to modify and bring it up to date.	2024-11-05 09:04:33 +10:00
David Taylor	216845e4c7	DEV: Deprecate template overrides (#29544) ... Template overrides have been advised against for a long time, and are increasingly hard to maintain as Discourse's development accelerates. This commit officially deprecates this customization method, which will be removed in the not-too-distant future (likely in the first half of 2025).	2024-11-04 17:38:33 +00:00
Jarek Radosz	9c5fc6f1df	DEV: Add more-topics plugin API (#29143) ... From plugin-api comment: Registers a new tab to be displayed in "more topics" area at the bottom of a topic page. ```gjs api.registerMoreTopicsTab({ id: "other-topics", name: i18n("other_topics.tab"), component: <template>tbd</template>, condition: ({ topic }) => topic.otherTopics?.length > 0, }); ``` You can additionally use more-topics-tabs value transformer to conditionally show/hide specific tabs. ```js api.registerValueTransformer("more-topics-tabs", ({ value, context }) => { if (context.user?.aFeatureFlag) { // Remove "suggested" from the topics page return value.filter( (tab) => context.currentContext !== "topic" || tab.id !== "suggested-topics" ); } }); ```	2024-11-04 17:32:49 +01:00
Keegan George	7a936da05c	DEV: Auto grid images no longer experimental (#29572) ... Recently we added a new feature for automatically gridding images in the composer (https://github.com/discourse/discourse/pull/29260). After testing this feature under a setting for a short period of time, the feature is no longer experimental anymore. This PR removes the site setting `experimental_auto_grid_images`.	2024-11-04 08:21:40 -08:00
Kris	1d637c5243	UX: remove extra margin from PM small actions (#29571)	2024-11-04 10:53:35 -05:00
Renato Atilio	b061fd9cc2	DEV: refactor textarea from d-editor (#29411) ... Refactors the DEditor component making it textarea-agnostic.	2024-11-04 12:48:10 -03:00
Renato Atilio	6459ab9320	UX: allow anon users to download calendar (#29551) ... Allows anonymous users to download the calendar file. Before, they were given the option, but it would fail silently with a `TypeError: Cannot read properties of null (reading 'user_option')`.	2024-11-04 12:35:45 -03:00
Kris	d853b5384b	UX: align PM icon when editing title, allow shrink-to-fit (#29570)	2024-11-04 10:31:11 -05:00
Jarek Radosz	380974ce00	DEV: Use hasAttribute/hasAria/hasStyle in tests (#29568)	2024-11-04 11:30:38 +01:00
Jarek Radosz	9694d2477a	DEV: Convert more notOk assertions (#29556) ... …to either qunit-dom or `strictEqual`	2024-11-04 10:27:30 +01:00
Jarek Radosz	693a4e691b	DEV: Replace ok(true) assertions (#29555) ... …with `verifySteps`, `expect(0)`, or by removing it	2024-11-04 10:27:11 +01:00
Joffrey JAFFEUX	584a9d98ed	DEV: adds is-disabled modifier to form field container (#29567) ... We already had a data-attribute, but a class feels more natural in this case.	2024-11-04 17:57:40 +09:00
dependabot[bot]	a43bd24c67	Build(deps): Bump @faker-js/faker from 9.1.0 to 9.2.0 (#29562) ... Bumps [@faker-js/faker](https://github.com/faker-js/faker) from 9.1.0 to 9.2.0. - [Release notes](https://github.com/faker-js/faker/releases) - [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md) - [Commits](https://github.com/faker-js/faker/compare/v9.1.0...v9.2.0) --- updated-dependencies: - dependency-name: "@faker-js/faker" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-03 23:18:38 +01:00
pgcd	725d2411e5	This commit fixes an undesirable geometric query memory usage introduced in b908abe35a (#29539) ... I have been unable to figure out a way of testing this usefully (as I fear it would require creating several thousands of objects), but existing tests pass and a manual test with ~400k topics succeeds after the fix, while it would hang indefinitely and/or consume all disk space before the fix. I have reported the initial problem and my findings in https://meta.discourse.org/t/topic-reset-all-highest-exhausts-all-available-disk-space/333837	2024-11-04 09:00:03 +11:00
Jarek Radosz	b81055a6d4	DEV: Convert more equal assertions (#29554) ... …to either qunit-dom or `strictEqual`	2024-11-03 21:04:38 +01:00
dependabot[bot]	ba7f4e3c63	Build(deps-dev): Bump webpack from 5.96.0 to 5.96.1 (#29545) ... Bumps [webpack](https://github.com/webpack/webpack) from 5.96.0 to 5.96.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](https://github.com/webpack/webpack/compare/v5.96.0...v5.96.1) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-03 16:26:55 +01:00
Mark VanLandingham	deeed5b8c1	DEV: Add 'custom' WebHook event type group (#29549)	2024-11-01 13:30:37 -05:00
David Taylor	323013d9c7	DEV: restore topic argument for after-topic-status outlet (#29550) ... Followup to dd329d55	2024-11-01 18:25:40 +00:00
Sérgio Saquetim	4863b2ab7e	DEV: Added value transformers that mutate the value instead of returning it (#29537)	2024-11-01 14:23:46 -03:00
Bianca Nenciu	723dc1fa55	Dev fix some types (#29547) ... The primary key is usually a bigint column, but the foreign key columns are usually of integer type. This can lead to issues when joining these columns due to mismatched types and different value ranges. This was using a temporary plugin / test API to make tests pass. After more careful consideration, we concluded that it is safe to alter the tables directly.	2024-11-01 19:19:25 +02:00
benj	cfc23c43e9	FEATURE - Add username column to custom emoji table (#29522) ... * Adds emoji column for creator username	2024-11-01 10:32:59 -05:00
David Taylor	68c7c8e25d	DEV: Deprecate mobile-specific templates (#29514) ... We are moving away from the mobile-specific template pattern in favor of logical `{{#if}}` statements. This brings us closer to a standard Ember app, makes testing easier, and reduces duplicate code. This commit includes some minor refactoring in the resolver & component-templates initializer, so that the mobile lookups happen on desktop, without actually being used. This allows us to print the deprecation message consistently, to improve visibility to developers.	2024-11-01 14:51:12 +00:00
David Battersby	8aa4c39c3c	DEV: allow non focused tab to be primary tab in service worker (#29516) ... Follow up to #29388 - when there are no clients in focus, we should take the first visible client as the primary tab.	2024-11-01 09:42:33 +04:00
Martin Brennan	9c17588f6a	FIX: Admin dashboard tooltips not working on mobile (#29538) ... This commit fixes the (?) tooltips for reports on the admin dashboard on mobile. The fix is that float-kit instances can now have different triggers and un-triggers for mobile and desktop, and float-kit is now aware of the site being in mobile view. Example usage: ``` @triggers={{hash mobile=(array "click")}} ``` So now, if you press on the tooltip trigger on mobile it shows correctly, and on desktop both hover and click can be used. --------- Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>	2024-11-01 12:25:12 +10:00
Martin Brennan	254cf22559	FIX: Allow target attribute in translation overrides (#29503) ... Some of our translations are HTML and have `target='_blank'` included, we should allow the same when sanitizing input for translation overrides.	2024-11-01 09:48:07 +10:00
dependabot[bot]	dd768119aa	Build(deps-dev): Bump webpack from 5.95.0 to 5.96.0 (#29534) ... Bumps [webpack](https://github.com/webpack/webpack) from 5.95.0 to 5.96.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](https://github.com/webpack/webpack/compare/v5.95.0...v5.96.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-31 23:48:47 +01:00
dependabot[bot]	816babe387	Build(deps-dev): Bump @swc/core from 1.7.40 to 1.7.42 (#29526) ... Bumps [@swc/core](https://github.com/swc-project/swc) from 1.7.40 to 1.7.42. - [Release notes](https://github.com/swc-project/swc/releases) - [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md) - [Commits](https://github.com/swc-project/swc/compare/v1.7.40...v1.7.42) --- updated-dependencies: - dependency-name: "@swc/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-31 23:20:54 +01:00