github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 09:35:14 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
33,306 Commits 190 Branches 500 Tags 938 MiB
05206a61ab
Commit Graph

19734 Commits

Author SHA1 Message Date
Guo Xiang Tan
5aed463649 Update annotation. 2019-05-24 12:58:26 +08:00
Guo Xiang Tan
5478aa63ab FIX: Add missing unique index on user_id for user_profiles. 2019-05-24 12:11:49 +08:00
Guo Xiang Tan
4f5c9bb8d3 DEV: Prefer create! over create. 
We want to know when stuff fails.
 2019-05-24 12:07:22 +08:00
Blake Erickson
1fbe078ae0 FIX: Undefined method when serializing a user 
Apparently is is possible to have a user without a user_profile. This
fix will return nil for any user_profile fields during serialization
(like the after delete web hook) instead of blowing up.
 2019-05-23 19:44:55 -06:00
Guo Xiang Tan
1babc3bec6 Follow up to 3388872991. 2019-05-24 09:02:39 +08:00
Kris
3388872991 UX: Separate section for 2FA settings, more consistent layout 2019-05-24 08:58:12 +08:00
Robin Ward
648af78298 FIX: Linting 2019-05-23 12:16:45 -04:00
Robin Ward
f73988acd2 Remove unused computed property. 2019-05-23 12:06:18 -04:00
Robin Ward
e74cd54fc6 REFACTOR: Replace score bonuses with low/med/high priorities 
We removed score from the UX so it makes more sense to have sites set
priorities instead of score bonuses.
 2019-05-23 11:54:45 -04:00
Joffrey JAFFEUX
30961dd875 Revert "UX: Prevent long names from overflowing on user admin" 
This reverts commit 6207b71c36.
 2019-05-23 16:56:30 +02:00
Régis Hanol
943fdc1762 make eslint happy 2019-05-23 12:51:40 +02:00
Régis Hanol
0cc81f95a5 FIX: popover should use target when no data attributes 2019-05-23 12:41:36 +02:00
Guo Xiang Tan
ca6c919299 DEV: Remove unused variable. 
Follow up to df1e6eed5a07f49eeda4c0bbd8c63d539aefdb3b..
 2019-05-23 16:42:42 +08:00
Joffrey JAFFEUX
f0a776f05d
FIX: allows scrolling when a lot of categories are used (#7590) 2019-05-23 10:04:53 +02:00
Guo Xiang Tan
df1e6eed5a FIX: Pull hotlinked images for lightbox links as well. 2019-05-23 15:44:37 +08:00
Arpit Jalan
553ffbfcb5 FEATURE: add OpenGraph data to /login page 2019-05-23 07:03:01 +05:30
Sam Saffron
954293655f FEATURE: rake posts:destroy_old_user_data_exports 
Historically we would keep the user data export posts around but delete
the uploads.

This leaves a lot of broken uploads in the system.

This rake task allows us to clean up old mess.
 2019-05-23 11:11:37 +10:00
Kris
6207b71c36 UX: Prevent long names from overflowing on user admin 2019-05-22 15:10:09 -04:00
Kris
9f6af5f8a7 UX: Prevent long names from overflowing on user profiles 2019-05-22 15:03:50 -04:00
Kris
881c832a2f UX: Remove padding from empty row 2019-05-22 14:27:17 -04:00
Robin Ward
ca03baf2b2 UX: Hide pending score statuses 2019-05-22 11:26:17 -04:00
Joffrey JAFFEUX
cf63a9bb53
FIX: exception when pressing backspace on empty selection (#7587) 2019-05-22 17:18:46 +02:00
Joffrey JAFFEUX
c238f0d223
FIX: ensures selection is lookedup into async content (#7586) 2019-05-22 17:11:19 +02:00
Gerhard Schlager
58f72cd439 Remove duplicate translations 2019-05-22 16:15:22 +02:00
Joffrey JAFFEUX
40c903ec23
FIX: ie11 exception on new category popup (#7585) 2019-05-22 15:17:28 +02:00
Gerhard Schlager
e224100023 FIX: Don't convert :) into Emoji when emojis or emoji shurtcuts are disabled 2019-05-22 11:44:39 +02:00
Sam Saffron
d9413a61d2 PERF: move crawl_topic_links to the low queue 
Crawling topic links can be somewhat delayed no need to run it in the default
queue.
 2019-05-22 10:18:49 +10:00
Joffrey JAFFEUX
0ed1cfd8d9
FIX: ensures we have an elementFromPoint before using it (#7583) 2019-05-21 21:26:54 +02:00
Vinoth Kannan
793915fe6a DEV: should ignore missing post uploads when a user export destroyed 2019-05-21 13:32:36 +05:30
Joffrey JAFFEUX
236adc9ccb
FIX: shows parent category name in title anchor (#7576) 2019-05-21 08:33:22 +02:00
Osama Sayegh
0b5924d61e
Refactor keyboard shortcuts modal to fix RTL locales (#7545) 
* Refactor keyboard shortcuts modal to fix RTL locales

* Feedback

* Remove lowercase modifier keys
 2019-05-21 06:39:32 +03:00
Joffrey JAFFEUX
bc8c77723e
FIX: puts focus-event at application level (#7568) 
Also attempts to use simpler and newer APIs
 2019-05-20 13:48:03 +02:00
Gerhard Schlager
b788948985 FEATURE: English locale with international date formats 
Makes en_US the new default locale
 2019-05-20 13:47:20 +02:00
Joffrey JAFFEUX
9bbf421125
FIX: better node check for clickoutside in widgets (#7573) 2019-05-20 12:45:33 +02:00
Joffrey JAFFEUX
0ddfeb9c64
FIX: ensures mousetrap is reset with the application (#7569) 2019-05-20 10:45:31 +02:00
Osama Sayegh
14bae6d52d Make email_excerpt method take an optional post param (#7570) 
The spoiler alert plugin replaces spoiler text found in email excerpts with posts URL, which means it needs to have a reference to the post it's processing.

This change makes `email_excerpt` accepts an optional post param, which calls `PrettyText.format_for_email` which then triggers the `reduce_cooked` event that the plugin subscribes to.
 2019-05-20 10:04:23 +02:00
Kris
7eea2e35e4 Upload image preview needs width on desktop 2019-05-17 11:25:35 -04:00
Joffrey JAFFEUX
b05d7042ae
FIX: prevents events on toolbar when in form (#7567) 
If a button is not of type button, pressing enter inside an `<input>` inside a `<form>` without the action attribute will trigger the first available `<button>` as most browsers default the type of an unspecified button to submit.

This commit also prevents d-editor-modal to be filled when it's hidden.
 2019-05-17 11:14:09 +02:00
Guo Xiang Tan
148bfc9be5 DEV: Simplify client and server side code to support removing tags. 
Follow up to 834c86678f.
 2019-05-17 16:39:20 +08:00
David Taylor
5666316285 FEATURE: Display 'last updated' on dashboard, improve release notes link (#7560) 2019-05-17 15:42:45 +10:00
Guo Xiang Tan
834c86678f FIX: Missing post revision when editing the first post. 2019-05-17 12:54:27 +08:00
Guo Xiang Tan
e2444e0d31 DEV: Fix another frozen string error. 2019-05-17 10:07:37 +08:00
Sam Saffron
25137554ed FIX: _.include is no longer imported from lodash 
Instead use toArray and indexOf which is also clearer
 2019-05-17 08:58:39 +10:00
Kris
80b3560050 IE11: Login form needs full flex shorthand 2019-05-16 14:07:49 -04:00
Robin Ward
225593d445 FIX: Small tweak to percentiles based on feedback 2019-05-16 13:45:36 -04:00
Joffrey JAFFEUX
ad4d01233b
DEV: attempts to make d-editor tests more resilient (#7556) 2019-05-16 14:42:01 +02:00
Joffrey JAFFEUX
244c03573a
FIX: btn class was duplicated on admin-menu-buttons (#7555) 2019-05-16 14:37:53 +02:00
Joffrey JAFFEUX
0c6ebe66ce
EXPERIMENTAL: clicks outside seem unreliable with absolute nodes (#7557) 2019-05-16 14:37:37 +02:00
Joffrey JAFFEUX
1afe6d0aee
FIX: share-and-invite modal was too narrow (#7559) 2019-05-16 14:37:19 +02:00
Vinoth Kannan
0e677daaee FIX: include posts with data-orig-src attribute in have_uploads scope query. 2019-05-16 16:39:38 +05:30
Vinoth Kannan
56ada8374f DEV: wrap find_missing_uploads method in distributed mutex 
And skip posts with deleted topics.\ne8fafbc123170dd1f7d2a8adea4e7810585d3e76
 2019-05-16 15:17:53 +05:30
Régis Hanol
a5a4f9dc1a
DEV: make prettier happy 
(cc @jjaffeux)
 2019-05-16 11:38:47 +02:00
Joffrey JAFFEUX
d47bf8b6c4
SECURITY: updates lodash from 1.3.0 to 4.17.5 (#7546) 2019-05-16 10:34:19 +02:00
Guo Xiang Tan
a36fe019bb DEV: Fix race condition when enqueuing edit wiki-ed notification. 2019-05-16 13:48:46 +08:00
Vinoth Kannan
636b75fa16 REFACTOR: remove duplicate reject loop and implicit return 
e8fafbc123
 2019-05-16 10:04:04 +05:30
Guo Xiang Tan
227bedebf7 DEV: Fix modifying a frozen string. 2019-05-16 11:30:31 +08:00
Kris
7cd1067f3d FIX: Select-kit too narrow in topic timer 2019-05-15 17:58:40 -04:00
Régis Hanol
501bee56b7 Make prettier happy 2019-05-15 23:46:50 +02:00
Neil Lalonde
7eea55d564 PERF: remove "new posts" stat from summary email 
It performs horribly and isn't a personalized stat like the others.
 2019-05-15 16:28:21 -04:00
Régis Hanol
db89722a98 UX: ignore leading/trailing whitespaces in site settings search 2019-05-15 22:22:20 +02:00
Bianca Nenciu
b9fcb2bcdf
DEV: Add before button hook in post-menu. (#7550) 2019-05-15 22:48:23 +03:00
Kris
0ef25f7a66 prettier 2019-05-15 13:35:58 -04:00
Kris
a3f6c7d6af
REFACTOR: Remove table layout from modals, clean up styles (#7549) 2019-05-15 13:26:25 -04:00
Maja Komel
9a17b19636 FIX: don't hide back button at the bottom of timeline (#7544) 2019-05-15 19:02:48 +02:00
Penar Musaraj
fc5bb39096 FIX: Do not send duplicate alerts for the same post (#7476) 2019-05-15 18:47:36 +02:00
David Taylor
1299c94a52 FIX: Make serverside and clientside omniauth origin redirects consistent 
Previously external domains were allowed in the client-side redirects, but not the server-side redirects. Now the behavior is to only allow local origins.
 2019-05-15 12:40:51 +01:00
Bianca Nenciu
1d3375b176 FEATURE: Preserve notifications levels when splitting topics. (#7494) 2019-05-15 17:29:29 +10:00
Vinoth Kannan
42b10a646d FIX: return 404 only if upload url also not internal. 2019-05-15 02:06:54 +05:30
Maja Komel
e0fe01925e FIX: make frozen string mutable in incoming_domain 2019-05-14 17:44:53 +02:00
Joffrey JAFFEUX
d127119549
REFACTOR: user-selector take 2 (#7540) 2019-05-14 09:43:29 +02:00
Sam Saffron
624184560e PERF: improve performance of publish_notifications_state 
User.publish_notifications_state is called every time a notification is
created, this can become a very critical code path.

On some heavy notification related sites this can be a major CPU user on PG

This index makes it much cheaper to publish notification state, cause a
simple index lookup does the trick.
 2019-05-14 16:02:55 +10:00
Neil Lalonde
6f747c6b71 FIX: don't allow username to be changed to same as password 
We were blocking user registrations with same username and password,
but allowing usernames to be changed to be same as password later.
Also disallow names to be the same as password.
 2019-05-13 16:43:40 -04:00
Gerhard Schlager
bbab60fa9b FIX: Don’t try to delete inactive moderators 
follow-up to 6d77156a
 2019-05-13 21:44:03 +02:00
Régis Hanol
7707d5db2d Revert "REFACTOR: user-selector (#7529)" 
This reverts commit 9a56df89f0.
 2019-05-13 19:39:30 +02:00
Arpit Jalan
a2b1789c3e FIX: do not log username change if the save process was unsuccessful 2019-05-13 22:20:27 +05:30
Robin Ward
fb1da53dff FIX: Issue with incorrect heights when cloaking plugin content in posts 
We noticed this with the house ads plugin. It inserted content after a
post, which was not taken into account when calculating and memoizing
the height of the element.

Co-authored-by: nlalonde
Co-authored-by: pmusaraj
 2019-05-13 11:29:21 -04:00
Joffrey JAFFEUX
7326ddea6d
REFACTOR: tags mixin (#7533) 2019-05-13 17:05:21 +02:00
Joffrey JAFFEUX
b8db702a02
REFACTOR: admin-user-index route (#7534) 2019-05-13 17:04:41 +02:00
Joffrey JAFFEUX
717aa764b6
FIX: more efficient topic-footer-button-api (#7535) 2019-05-13 17:04:24 +02:00
David Taylor
750c125707 DEV: Include foreign keys in model annotations 2019-05-13 15:53:42 +01:00
Penar Musaraj
607c671003 Fix string literal when switching theme in dev env 2019-05-13 10:25:51 -04:00
Penar Musaraj
f1b0782624 UI: Adjust footer nav bar size in iOS app 2019-05-13 10:25:51 -04:00
David Taylor
1bff81419e DEV: Update annotations 2019-05-13 15:24:24 +01:00
Gerhard Schlager
53d2232731 FIX: Remove trailing slash from topic URL 
this lead to duplicate slashes in concatenated URLs
 2019-05-13 14:51:45 +02:00
Joffrey JAFFEUX
df18243827
FIX: prevents exception if report doest define filters (#7532) 2019-05-13 13:34:28 +02:00
Joffrey JAFFEUX
9a56df89f0
REFACTOR: user-selector (#7529) 2019-05-13 13:03:12 +02:00
Arpit Jalan
25b39b86ae FIX: reload the user record instead of fetching via email 2019-05-13 15:16:53 +05:30
Joffrey JAFFEUX
e64ed9dbc1
REFACTOR: edit-category controller (#7527) 2019-05-13 11:30:32 +02:00
Guo Xiang Tan
64c117519e Fix modifying frozen strings errors take 3. 2019-05-13 16:45:23 +08:00
Guo Xiang Tan
74989783da Fix modifying frozen strings error in OneboxController. 2019-05-13 16:25:52 +08:00
Guo Xiang Tan
b584e30902 Fix modifying frozen strings error take 2. 2019-05-13 16:23:45 +08:00
Joffrey JAFFEUX
9b75320d63
FIX: track mutations on topic edit category-chooser only on select (#7528) 2019-05-13 10:22:28 +02:00
Sam Saffron
d643294c9d FIX: delete duplicate invites earlier in the process 
There was a race condition when 2 invites existed for 1 user where in some
cases data from both invites would be used for the redeem. Depending on DB
ordering.

Fix is to delete duplicate invites earlier in the process prior to
`redeem_from_email` being called.
 2019-05-13 17:42:39 +10:00
Gerhard Schlager
81c329fbb8 FIX: Customizing missing pluralized translations didn't work 2019-05-13 09:36:05 +02:00
Guo Xiang Tan
d369b84ced Fix modifying frozen strings error. 2019-05-13 14:31:20 +08:00
Guo Xiang Tan
8165ceb320 Make rubocop happy. 2019-05-13 09:55:44 +08:00
Sam Saffron
30990006a9 DEV: enable frozen string literal on all files 
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.

Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
 2019-05-13 09:31:32 +08:00
Penar Musaraj
a859ddc77e Improve theme/component delete modal warning 2019-05-10 14:14:12 -04:00
Joffrey JAFFEUX
c093fa0376
PERF: reduces cpu/memory consumption of sk in some cases (#7525) 2019-05-10 17:12:10 +02:00
Robin Ward
643c75c419 FIX: Don't increment version if the reviewable operation fails 
In fact, roll back the entire operation in the database.
 2019-05-10 09:53:25 -04:00