Osama Sayegh
062a5f316d
DEV: Wire up the dimiss button in the new notifications menu ( #17745 )
...
This commit is a subset of the changes proposed in https://github.com/discourse/discourse/pull/17379 .
2022-08-03 15:32:35 +03:00
Osama Sayegh
ce9eec8606
DEV: Combine all header notification bubbles into one in the new user menu ( #17718 )
...
Extracted from https://github.com/discourse/discourse/pull/17379 .
2022-08-03 08:57:59 +03:00
Phil Pirozhkov
493d437e79
Add RSpec 4 compatibility ( #17652 )
...
* Remove outdated option
04078317bahttps://github.com/rspec/rspec-core/pull/2803
* Use the non-globally exposed RSpec syntax, cont
https://github.com/rspec/rspec-core/pull/2803
* Comply to strict predicate matchers
See:
- https://github.com/rspec/rspec-expectations/pull/1195
- https://github.com/rspec/rspec-expectations/pull/1196
- https://github.com/rspec/rspec-expectations/pull/1277
2022-07-28 10:27:38 +08:00
Osama Sayegh
9103081eb7
DEV: Add likes, mentions and replies tabs to the new user menu ( #17623 )
...
This commit is a subset of the changes proposed in https://github.com/discourse/discourse/pull/17379 .
2022-07-25 15:19:53 +03:00
David Taylor
c9dab6fd08
DEV: Automatically require 'rails_helper' in all specs ( #16077 )
...
It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors.
By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.
2022-03-01 17:50:50 +00:00
Guo Xiang Tan
16961dee76
FIX: Typo in NotificationsController#index not caught by tests.
2020-07-22 09:22:26 +08:00
Ahmed Gagan
04d7693355
FIX: Filter read/unread notifications on the server side ( #10152 )
...
https://meta.discourse.org/t/notifications-unread-only-filter/37621/32
2020-07-02 11:06:00 +01:00
Guo Xiang Tan
9c7d3b2dc0
FIX: Avoid marking notifications as seen in readonly mode.
2020-06-25 10:14:07 +08:00
Jarek Radosz
781e3f5e10
DEV: Use response.parsed_body in specs ( #9615 )
...
Most of it was autofixed with rubocop-discourse 2.1.1.
2020-05-07 17:04:12 +02:00
Guo Xiang Tan
152238b4cf
DEV: Prefer public_send over send.
2019-05-07 09:33:21 +08:00
Sam Saffron
4ea21fa2d0
DEV: use #frozen_string_literal: true on all spec
...
This change both speeds up specs (less strings to allocate) and helps catch
cases where methods in Discourse are mutating inputs.
Overall we will be migrating everything to use #frozen_string_literal: true
it will take a while, but this is the first and safest move in this direction
2019-04-30 10:27:42 +10:00
Guo Xiang Tan
4dee7ed6d9
DEV: Fix randomlly failing spec.
2019-01-22 15:19:31 +08:00
Guo Xiang Tan
3a8f69c3d2
DEV: Assert for 200 response code to avoid changing magic helper in the future.
2018-06-07 16:11:09 +08:00
Sam
89ad2b5900
DEV: Rails 5.2 upgrade and global gem upgrade
...
This updates tests to use latest rails 5 practice
and updates ALL dependencies that could be updated
Performance testing shows that performance has not regressed
if anything it is marginally faster now.
2018-06-07 14:21:33 +10:00
OsamaSayegh
807223deef
REFACTOR: notifications controller specs to requests
2018-06-04 16:06:53 +10:00
