Jarek Radosz
0650504bf5
DEV: Remove after-transition function ( #21142 )
...
All supported browsers use `transitionend` event now, so this code is not necessary and makes it difficult to use that event in tests (you'd have to trigger all variants to cover the bases)
That function was used only in core (no hits in all-the*) in two places, so I think it's rather safe to just trash it without deprecating it first.
(History Corner – this helper was originally added in the initial commit of Discourse! 1839614bcc/app/assets/javascripts/discourse/components/transition_helper.js.coffee
2023-04-18 20:45:20 +02:00
NullVoxPopuli
e2f65cd170
DEV: Replace virtual-dom fork with patch-package ( #21007 )
...
Using patch-package is much easier to reason with than maintaining a full fork of virtual-dom.
Original reasoning for the fork can be found in e216a98fc64007150a (diff-f648eb0588a88af826e29622f64aca611e191c66eb9e79396d559edaef622313)
2023-04-18 19:42:25 +01:00
David Taylor
7a8ed517a4
DEV: Improve modifyClass warning message ( #21140 )
...
- Print warning when it affects user/currentUser
- Improve description and link to Meta topic
2023-04-18 11:41:38 +01:00
Penar Musaraj
b869d35f94
FIX: Dismiss modal when "Keep Editing" is used ( #21117 )
...
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2023-04-17 17:44:21 -04:00
Keegan George
d3f3914ade
DEV: Add an offset mobile devices ( #21119 )
2023-04-17 13:35:11 -07:00
Mark VanLandingham
ae5aa0c79f
DEV: Plugin API addQuickAccessProfileItem adds to revamped user menu ( #21084 )
2023-04-17 06:15:16 -05:00
Joffrey JAFFEUX
2535381f44
FIX: ensures tag notification level is changed ( #21106 )
...
Following a change in e9f7262813
2023-04-17 10:48:41 +02:00
Jarek Radosz
dd98ecb7d1
DEV: Remove unnecessary getURL("/") ( #21103 )
...
Our `ajax()` prepends the protocol/host/subfolder path.
2023-04-15 14:34:25 +02:00
Jarek Radosz
b8cf79895e
DEV: Set QUnit per-test timeout ( #21102 )
...
60s is a lot, and I'd prefer 15s, but the first test in a suite can take up to 40s. 60s is still better than `Infinity` 😌
2023-04-15 14:34:13 +02:00
dependabot[bot]
d6b6041ae2
Build(deps): Bump webpack in /app/assets/javascripts ( #21089 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.78.0 to 5.79.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.78.0...v5.79.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-14 13:22:33 +02:00
Krzysztof Kotlarek
933d276b7d
FIX: decrease reorder sidebar delay for desktop ( #21098 )
...
Delay to reorder links in custom sidebar section doesn't have to be that long for desktop compared to touch screen.
2023-04-14 12:31:21 +10:00
David Battersby
967010e545
FEATURE: Add an emoji deny list site setting ( #20929 )
...
This feature will allow sites to define which emoji are not allowed. Emoji in this list should be excluded from the set we show in the core emoji picker used in the composer for posts when emoji are enabled. And they should not be allowed to be chosen to be added to messages or as reactions in chat.
This feature prevents denied emoji from appearing in the following scenarios:
- topic title and page title
- private messages (topic title and body)
- inserting emojis into a chat
- reacting to chat messages
- using the emoji picker (composer, user status etc)
- using search within emoji picker
It also takes into account the various ways that emojis can be accessed, such as:
- emoji autocomplete suggestions
- emoji favourites (auto populates when adding to emoji deny list for example)
- emoji inline translations
- emoji skintones (ie. for certain hand gestures)
2023-04-13 15:38:54 +08:00
Jarek Radosz
cb1e95cd3d
FIX: Educational composer messages regressed in 788dc0a ( #21082 )
...
Tests coming in another PR
2023-04-12 20:05:52 +02:00
David Taylor
fa5a423681
Revert "DEV: Support modifyClass for native class fields on EmberObjects ( #20987 )" ( #21080 )
...
This reverts commit a19efc4304
2023-04-12 17:38:44 +01:00
David Taylor
a19efc4304
DEV: Support modifyClass for native class fields on EmberObjects ( #20987 )
...
EmberObject's `reopen` feature allows changes to be made to the prototype of the class, but it does not work with native class fields. Native class field values are set on the instance in the constructor, and therefore override any values from the prototype.
This commit implements a workaround which detects possible field overrides and then sets the values during the `init()` function of the EmberObject. This isn't perfect - old field values will still be present while any constructor function is running. But in the vast majority of cases, it should provide parity with old non-native-class EmberObject properties.
This commit also adds a warning when trying to override fields on non-EmberObject classes. There is no change in behavior here - we're just warning about the fact it doesn't work.
2023-04-12 16:49:57 +01:00
Jarek Radosz
788dc0a096
DEV: Refactor ComposerMessages ( #21077 )
...
Co-authored-by: David Taylor <david@taylorhq.com>
2023-04-12 17:02:37 +02:00
David Taylor
db16700355
PERF: Memoize element references for dockCheck ( #21079 )
...
This is run frequently in a scroll listener. Removing the need for repeated `querySelector` calls makes those scroll handlers much faster.
2023-04-12 14:17:43 +01:00
David Taylor
a328153ec2
DEV: Enable patch-package in production and in javascripts/discourse ( #21078 )
...
When running `yarn install` in a yarn workspace, the lifecycle hooks in the root package.json are not triggered. https://github.com/yarnpkg/yarn/issues/5790
As a workaround, we can additionally run `patch-package` from the `javascripts/discourse/package.json` `postinstall` hook. `patch-package` is idempotent, so it doesn't matter if it is triggered multiple times.
Longer term we intend to move to pnpm, which has built-in patch support.
2023-04-12 13:15:53 +01:00
David Battersby
7d34ba38a2
FIX: all staff_counters should be pluralized strings ( #21048 )
...
Make all staff_counters pluralized strings
2023-04-12 17:13:37 +08:00
Alan Guo Xiang Tan
2eb60c9713
DEV: Switch sidebar section link identifier to data attribute ( #21051 )
...
Data attribute is less restrictive than relying on the class attribute
2023-04-12 15:52:10 +08:00
dependabot[bot]
f0435844df
Build(deps): Bump sass from 1.61.0 to 1.62.0 in /app/assets/javascripts ( #21063 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.61.0 to 1.62.0.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.61.0...1.62.0 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-12 09:08:49 +08:00
Kris
ce601ac84c
UX: improve composer control spacing on mobile ( #21021 )
2023-04-11 14:11:00 -05:00
Rafael dos Santos Silva
087ee8c5e2
DEV: Experimental JS plugin API for topic summary HTML ( #20963 )
2023-04-11 11:22:34 -04:00
Jan Cernik
a3801a9e16
DEV: Stop event propagation in DTooltip ( #20897 )
2023-04-11 12:07:03 -03:00
Jan Cernik
352bd35bf6
Add RenderGlimmer support for embedded posts ( #21046 )
2023-04-11 06:22:42 -03:00
Jarek Radosz
b6cfcdfbb3
DEV: Force an upgrade of watch-detector ( #21053 )
...
Fixes the unnecessary message when starting ember server:
```
Invalid watchman found, version: [2023.04.03.00] did not satisfy [>= 3.0.0].
Visit https://ember-cli.com/user-guide/#watchman for more info.
```
2023-04-11 11:14:57 +02:00
NullVoxPopuli
c320c286f9
DEV: Use patch-package to apply ember-jquery workaround
...
Co-authored-by: David Taylor <david@taylorhq.com>
2023-04-11 10:12:30 +01:00
dependabot[bot]
47eced2050
Build(deps): Bump terser in /app/assets/javascripts ( #21042 )
...
Bumps [terser](https://github.com/terser/terser ) from 5.16.8 to 5.16.9.
- [Release notes](https://github.com/terser/terser/releases )
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v5.16.8...v5.16.9 )
---
updated-dependencies:
- dependency-name: terser
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-11 10:38:49 +02:00
Alan Guo Xiang Tan
90172e5a9e
FIX: Incorrect message inbox displayed due to username case sensitivity ( #21049 )
2023-04-11 11:31:10 +08:00
David Battersby
569b923fb6
FIX: staff_counters should be pluralized strings ( #21039 )
...
Small change to format the staff counter template to apply the correct pluralization for flagged posts/topics.
2023-04-10 17:00:31 +08:00
dependabot[bot]
bb94cc0251
Build(deps): Bump eslint from 8.37.0 to 8.38.0 in /app/assets/javascripts ( #21033 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 8.37.0 to 8.38.0.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v8.37.0...v8.38.0 )
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-10 08:09:09 +08:00
Kris
18470c9195
UX: fix solo preference page layout ( #21012 )
2023-04-07 08:55:32 -04:00
Jarek Radosz
584a3a4237
DEV: Remove unneeded optional chaining operators ( #21019 )
...
(and fix a typo, and remove an unnecessary `this.element` check)
2023-04-07 14:10:49 +02:00
dependabot[bot]
92420bad6f
Build(deps): Bump sass from 1.60.0 to 1.61.0 in /app/assets/javascripts ( #21014 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.60.0 to 1.61.0.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.60.0...1.61.0 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-07 09:53:32 +02:00
Daniel Waterworth
0ff86feb96
DEV: Rely on helpers for ajax error handling to reduce repetition ( #20988 )
2023-04-06 11:25:24 -05:00
Daniel Waterworth
355b44472b
DEV: Allow HTML errors whenever a popup is generated ( #20989 )
...
Follow-up-to: 6bbf832400
2023-04-06 10:00:54 -05:00
dependabot[bot]
cee06bdc77
Build(deps): Bump @uppy/aws-s3 in /app/assets/javascripts ( #20996 )
...
Bumps [@uppy/aws-s3](https://github.com/transloadit/uppy ) from 3.0.5 to 3.0.6.
- [Release notes](https://github.com/transloadit/uppy/releases )
- [Changelog](https://github.com/transloadit/uppy/blob/main/CHANGELOG.md )
- [Commits](https://github.com/transloadit/uppy/compare/@uppy/aws-s3@3.0.5...@uppy/aws-s3@3.0.6 )
---
updated-dependencies:
- dependency-name: "@uppy/aws-s3"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-06 13:39:31 +02:00
Jarek Radosz
d6bf5f40fb
DEV: Change the params for categoryNone redirect ( #20944 )
...
Makes the params (`router.currentRoute.params`) the same in this codepath as in the regular flow. (issue originally reported in: https://meta.discourse.org/t/category-banners/86241/174 )
See also https://github.com/discourse/discourse-category-banners/pull/31 for the first stab at the bug.
2023-04-06 12:26:19 +02:00
dependabot[bot]
3485936517
Build(deps): Bump @uppy/aws-s3-multipart in /app/assets/javascripts ( #20998 )
...
Bumps [@uppy/aws-s3-multipart](https://github.com/transloadit/uppy ) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/transloadit/uppy/releases )
- [Changelog](https://github.com/transloadit/uppy/blob/main/CHANGELOG.md )
- [Commits](https://github.com/transloadit/uppy/compare/@uppy/aws-s3-multipart@3.1.2...@uppy/aws-s3-multipart@3.1.3 )
---
updated-dependencies:
- dependency-name: "@uppy/aws-s3-multipart"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-06 12:24:20 +02:00
dependabot[bot]
38adfca295
Build(deps): Bump @uppy/xhr-upload in /app/assets/javascripts ( #20993 )
...
Bumps [@uppy/xhr-upload](https://github.com/transloadit/uppy ) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/transloadit/uppy/releases )
- [Changelog](https://github.com/transloadit/uppy/blob/main/CHANGELOG.md )
- [Commits](https://github.com/transloadit/uppy/compare/@uppy/xhr-upload@3.1.0...@uppy/xhr-upload@3.1.1 )
---
updated-dependencies:
- dependency-name: "@uppy/xhr-upload"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-06 12:21:00 +02:00
NullVoxPopuli
97d8614811
DEV: Extract global compat code into module ( #20901 )
...
Moves a couple things from discourse-boot.js to a different JS file imported from app/app.js.
This is a forwards compatible technique to import and throw data on the window.
One thing to make note of, though, is that if the virtual-dom and discourse-widget-hbs/helpers were previously included in the build elsewhere, they will now become part of the app bundle.
Later, when using embroider, all bundles will be chunks, and webpack will optimize which chunk contains which modules appropriately.
2023-04-06 10:09:12 +01:00
dependabot[bot]
9014cd6a6f
Build(deps): Bump @uppy/utils in /app/assets/javascripts ( #20992 )
...
Bumps [@uppy/utils](https://github.com/transloadit/uppy ) from 5.1.3 to 5.2.0.
- [Release notes](https://github.com/transloadit/uppy/releases )
- [Changelog](https://github.com/transloadit/uppy/blob/main/CHANGELOG.md )
- [Commits](https://github.com/transloadit/uppy/compare/@uppy/utils@5.1.3...@uppy/utils@5.2.0 )
---
updated-dependencies:
- dependency-name: "@uppy/utils"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-06 10:57:41 +02:00
dependabot[bot]
718a8d1164
Build(deps): Bump webpack in /app/assets/javascripts ( #20999 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.77.0 to 5.78.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.77.0...v5.78.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-06 10:55:24 +02:00
Ted Johansson
1b132dad0d
FIX: Correctly pre-select first option in bookmark notification drop-down ( #20976 )
...
When selecting the "Keep bookmark" in the user preference for what to do after a bookmark reminder is sent, it does not propagate to the drop-down in the "Create bookmark" modal. Instead it defaults to "Keep bookmark and clear reminder". All other options work fine.
We set a default ("Keep bookmark and clear reminder") if no user preference is found, However, this uses the index of the option, and the index of the first option ("Keep bookmark") is 0, which is treated as falsey in JavaScript, thus causing the default to be selected.
This change switches from logical "or" conditional `||` operator to nullish coalescing `??` operator.
2023-04-06 14:58:40 +08:00
Krzysztof Kotlarek
e586f6052f
FEATURE: public custom sidebar sections visible to anonymous ( #20931 )
...
Previously, public custom sections were only visible to logged-in users. In this PR, we are making them visible to anonymous as well.
The reason is that Community Section will be moved into custom section model to be easily editable by admins.
2023-04-06 08:55:47 +10:00
Daniel Waterworth
cd6d47e012
FIX: Handle errors when we show the edit user directory columns modal ( #20986 )
2023-04-05 14:31:32 -05:00
Daniel Waterworth
79c87b5003
FIX: Show better default error when failing to delete all user posts ( #20985 )
2023-04-05 14:26:00 -05:00
Keegan George
3d7833d67e
FIX: <QuoteButton/> shifts when content is added to header ( #20878 )
2023-04-05 12:08:38 -07:00
Bianca Nenciu
e1a5f36d52
UX: Do not show bootstrap mode button on mobile ( #20984 )
...
It took too much place in the header.
2023-04-05 21:50:27 +03:00
dependabot[bot]
81566949f5
Build(deps): Bump ember-auto-import in /app/assets/javascripts ( #20970 )
...
Bumps [ember-auto-import](https://github.com/ef4/ember-auto-import/tree/HEAD/packages/ember-auto-import ) from 2.6.1 to 2.6.2.
- [Release notes](https://github.com/ef4/ember-auto-import/releases )
- [Changelog](https://github.com/ef4/ember-auto-import/blob/main/packages/ember-auto-import/CHANGELOG.md )
- [Commits](https://github.com/ef4/ember-auto-import/commits/v2.6.2/packages/ember-auto-import )
---
updated-dependencies:
- dependency-name: ember-auto-import
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-05 12:43:21 +02:00
