discourse

github-mirror/discourse

Fork 0

mirror of https://github.com/discourse/discourse.git synced 2025-02-25 22:19:40 +08:00

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
David Taylor	0ed4b09527	DEV: Move `discourse-common/(utils\|lib)` to `discourse/lib` (#30733 ) `discourse-common` was created in the past to share logic between the 'wizard' app and the main 'discourse' app. Since then, the wizard has been consolidated into the main app, so the separation of `discourse-common` is no longer useful. This commit moves `discourse-common/(lib\|utils)/` into `discourse/lib/`, adds shims for the imports, and updates existing uses in core.	2025-01-13 13:02:49 +00:00
Kelv	b07e7cc70f	DEV: refactor setting object mixin to helper class (#30529 ) This PR moves the logic from the setting-object mixin to a helper class. I've opted to maintain the interface of the previous classes (ThemeSettings / SiteSetting) that used the mixed-in methods through aliases so that we limit the amount of changes here (these are referenced in the string form and across classes/templates). Another option we may consider in future if we want to optimize for performance is straight duplication which would trade off this overhead of aliasing/chaining calls through the helper for some duplicate code - only 2 models require these methods at the time of this PR.	2025-01-06 12:02:46 +08:00

David Taylor

0ed4b09527

DEV: Move discourse-common/(utils|lib) to discourse/lib (#30733 )

`discourse-common` was created in the past to share logic between the
'wizard' app and the main 'discourse' app. Since then, the wizard has
been consolidated into the main app, so the separation of
`discourse-common` is no longer useful.

This commit moves `discourse-common/(lib|utils)/*` into
`discourse/lib/*`, adds shims for the imports, and updates existing
uses in core.

2025-01-13 13:02:49 +00:00

Kelv

b07e7cc70f

DEV: refactor setting object mixin to helper class (#30529 )

This PR moves the logic from the setting-object mixin to a helper class. I've opted to maintain the interface of the previous classes (ThemeSettings / SiteSetting) that used the mixed-in methods through aliases so that we limit the amount of changes here (these are referenced in the string form and across classes/templates).

Another option we may consider in future if we want to optimize for performance is straight duplication which would trade off this overhead of aliasing/chaining calls through the helper for some duplicate code - only 2 models require these methods at the time of this PR.

2025-01-06 12:02:46 +08:00

2 Commits