Dan Ungureanu
0653750fbf
FEATURE: Hash user API keys in the database ( #9344 )
...
The 'key' column will be dropped in a future commit.
2020-04-07 16:42:52 +03:00
Martin Brennan
34df9f7908
Revert DEFAULT_SHORTCUTS plugin API-breaking change
...
* this was done in previous commit
93c38cc175
2020-04-07 16:27:13 +10:00
Martin Brennan
42c2678d8f
FIX: Show topic level bookmark with reminder modal ( #9336 )
...
* When using the topic-level bookmark button or shortcut, we now show the bookmark with reminder modal for consistency.
* When hovering on a bookmark reminder notification where the bookmark has a name, show the name of the bookmark on hover.
2020-04-07 15:43:00 +10:00
Martin Brennan
7e42963590
DEV: Define keyboard shortcuts help onShow, and un-define onClose ( #9355 )
...
This is so we don't have a big hash just sitting in the controller definition, it is only created when it is needed. From comment here #9318 (comment)
2020-04-07 14:40:03 +10:00
Martin Brennan
93c38cc175
FEATURE: Bookmark keyboard shortcuts ( #9318 )
...
Adds keyboard bindings and associated help menu for selecting reminder type in bookmark modal, and pressing Enter to save.
Introduce the following APIs for `KeyboardShortcuts`:
* `pause` - Uses the provided array of combinations and unbinds them using `Mousetrap`.
* `unpause` - Uses the provided combinations and rebinds them to their default shortcuts listed in `KeyboardShortcuts`.
* `addBindings` - Adds the array of keyboard shortcut bindings and calls the provided callback when a binding is fired with Mousetrap.
* `unbind` - Takes an object literal of a binding map and unbinds all of them e.g. `{ enter: { handler: saveAndClose" } };`
2020-04-07 14:03:15 +10:00
Blake Erickson
d04ba4b3b2
DEPRECATION: Remove support for api creds in query params ( #9106 )
...
* DEPRECATION: Remove support for api creds in query params
This commit removes support for api credentials in query params except
for a few whitelisted routes like rss/json feeds and the handle_mail
route.
Several tests were written to valid these changes, but the bulk of the
spec changes are just switching them over to use header based auth so
that they will pass without changing what they were actually testing.
Original commit that notified admins this change was coming was created
over 3 months ago: 2db2003187
2020-04-06 16:55:44 -06:00
Mark VanLandingham
58bec3b200
DEV: Option for adding an icon in wizard-field-checkboxes component ( #9363 )
2020-04-06 14:00:55 -05:00
Joffrey JAFFEUX
b248c553c2
DEV: ensures CustomEmoji cache is cleared after spec ( #9361 )
2020-04-06 19:41:59 +02:00
Joffrey JAFFEUX
028915e4b9
FIX: revert inadvertently removed css class ( #9360 )
2020-04-06 19:22:29 +02:00
Jordan Vidrine
30983021e2
No category styles ( #9359 )
...
* UI: "No category styles" apply to category boxes
2020-04-06 12:02:33 -05:00
David Taylor
3814ca06a8
DEV: Allow using .js extension for javascript modules in themes ( #9358 )
2020-04-06 17:24:59 +01:00
dependabot-preview[bot]
ed74a6c126
Build(deps): Bump public_suffix from 4.0.3 to 4.0.4 ( #9353 )
...
Bumps [public_suffix](https://github.com/weppos/publicsuffix-ruby ) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/weppos/publicsuffix-ruby/releases )
- [Changelog](https://github.com/weppos/publicsuffix-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/weppos/publicsuffix-ruby/compare/4.0.3...v4.0.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-06 11:42:03 -04:00
dependabot-preview[bot]
c72fb252a5
Build(deps): Bump loofah from 2.4.0 to 2.5.0 ( #9352 )
...
Bumps [loofah](https://github.com/flavorjones/loofah ) from 2.4.0 to 2.5.0.
- [Release notes](https://github.com/flavorjones/loofah/releases )
- [Changelog](https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/loofah/compare/v2.4.0...v2.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-06 11:41:47 -04:00
dependabot-preview[bot]
24fbe3e796
Build(deps): Bump oj from 3.10.5 to 3.10.6 ( #9351 )
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.10.5 to 3.10.6.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.10.5...v3.10.6 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-06 11:40:45 -04:00
dependabot-preview[bot]
8c06c64bfb
Build(deps): Bump aws-sdk-s3 from 1.61.1 to 1.61.2 ( #9348 )
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.61.1 to 1.61.2.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-06 11:35:29 -04:00
dependabot-preview[bot]
a00cfe853a
Build(deps): Bump parser from 2.7.0.5 to 2.7.1.0 ( #9347 )
...
Bumps [parser](https://github.com/whitequark/parser ) from 2.7.0.5 to 2.7.1.0.
- [Release notes](https://github.com/whitequark/parser/releases )
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/whitequark/parser/compare/v2.7.0.5...v2.7.1.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-06 11:34:59 -04:00
Vinoth Kannan
fd39c85c1a
FIX: add category hashtags support for sub-sub categories.
...
Hashtags will include last two levels only (ex: "parent:child").
2020-04-06 20:43:38 +05:30
Joffrey JAFFEUX
a947b7b839
FIX: prevents registering multiple topic-notifications-button:changed ( #9356 )
...
A large topic page will always have the bottom tracking button, and will also have the timeline, meaning we already had 2 tracking events.
But it gets even worse when you know that the timeline button is a component connector which will trigger `didInsertElement` very frequently, meaning we were constantly adding more and more appEvents handlers.
2020-04-06 15:06:26 +02:00
Sam Saffron
81c912bb00
FIX: when loading drafts set the topic
...
the behavior of loadDraft regressed and it no longer correctly set the topic
model leading to "undefined" when attempting to reply
2020-04-06 16:29:14 +10:00
Martin Brennan
40546af217
FIX: Remove date from bookmark reminder non-English translations ( #9354 )
...
The {{date}} interpolated value was removed from the English translations in #9329 but not from the other translations, causing breakages.
Also adds a , inbetween date and time for reminders using long_no_year for readability.
2020-04-06 13:14:46 +10:00
Krzysztof Kotlarek
ce00da3bcd
FIX: guardian always got user but sometimes it is anonymous ( #9342 )
...
* FIX: guardian always got user but sometimes it is anonymous
```
def initialize(user = nil, request = nil)
@user = user.presence || AnonymousUser.new
@request = request
end
```
AnonymouseUser defines `blank?` method
```
class AnonymousUser
def blank?
true
end
...
end
```
so if we would use @user.present? it would be correct, however, just @user is always true
2020-04-06 09:56:47 +10:00
Dan Ungureanu
f8ec5f309a
FIX: Ensure category_id is an integer
2020-04-04 14:20:01 +03:00
Dan Ungureanu
b9d411a4eb
FIX: Topic.time_to_first_response should include sub-sub-categories ( #9349 )
2020-04-04 13:31:34 +03:00
Kris
a8002baaed
UX: Restyle bookmark reminder modal
2020-04-03 20:49:09 -04:00
Jordan Vidrine
751f229665
UX: removes color on categories if no style chosen ( #9346 )
...
* UX: removes color on categories if no style chosen
* Update app/assets/javascripts/discourse/templates/components/categories-only.hbs
* Update messages.hbs
Co-authored-by: Robin Ward <robin.ward@gmail.com>
2020-04-03 15:09:01 -05:00
Gerhard Schlager
ad6709772a
PERF: Backup with lots of uploads stored on S3 was slow
...
Creating the backup needs a lot more disk space after this change, but it is a lot faster.
2020-04-03 18:13:34 +02:00
Gerhard Schlager
2b2584912a
Improve Telligent import script
...
* Imports private messages
* Replaces internal links for topics and replies
* Allows incremental import of accepted answers
2020-04-03 18:10:52 +02:00
David Taylor
3cfe086a94
FIX: Limit personal message participants when converting from topic ( #9343 )
...
Previously all topic posters would be added which could lead to major performance issues. Now if there are too many posters, only the acting user will be added as a participant.
2020-04-03 16:42:01 +01:00
David Taylor
91fff746a4
FIX: Check active themes for all requests
...
Previously, the list of active themes was only used in html views. Now we have theme modifiers, themes can affect .json routes.
2020-04-03 15:50:13 +01:00
dependabot-preview[bot]
4500928a39
Build(deps-dev): Bump fabrication from 2.21.0 to 2.21.1 ( #9341 )
...
Bumps [fabrication](https://github.com/paulelliott/fabrication ) from 2.21.0 to 2.21.1.
- [Release notes](https://github.com/paulelliott/fabrication/releases )
- [Changelog](https://github.com/paulelliott/fabrication/blob/master/Changelog.markdown )
- [Commits](https://github.com/paulelliott/fabrication/compare/2.21.0...2.21.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-03 10:32:05 -04:00
dependabot-preview[bot]
06de6f80f8
Build(deps): Bump tzinfo from 1.2.6 to 1.2.7 ( #9340 )
...
Bumps [tzinfo](https://github.com/tzinfo/tzinfo ) from 1.2.6 to 1.2.7.
- [Release notes](https://github.com/tzinfo/tzinfo/releases )
- [Changelog](https://github.com/tzinfo/tzinfo/blob/master/CHANGES.md )
- [Commits](https://github.com/tzinfo/tzinfo/compare/v1.2.6...v1.2.7 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-03 10:31:45 -04:00
Joffrey JAFFEUX
883901e4c0
FIX: do not attempt to deselect tags if filter is not empty ( #9345 )
2020-04-03 16:27:56 +02:00
Daniel Waterworth
76bb01c31c
DEV: Increase process_post lock timeout
...
The process_post job uses CookedPostProcessor which also uses a
DistributedMutex. There's no good reason for the timeout of the outer
lock to be smaller than the timeout of the inner lock.
2020-04-03 13:34:44 +01:00
Sam Saffron
624a9bf234
DEV: allow for internal format change of Drafts
...
This follows up on 20d8b49add
2020-04-03 14:56:34 +11:00
Vinoth Kannan
82201fa466
FIX: jobs/delete_replies: Add Time+Duration, not Time+Time #9314
...
Co-authored-by: Kane York <kanepyork@gmail.com>
2020-04-03 09:23:40 +05:30
Sam Saffron
8d5cc8956d
DEV: avoid leaked HTTP call in test
...
We were running a failed request on route transition, this avoids it by
faking it.
2020-04-03 14:45:27 +11:00
Sam Saffron
20d8b49add
DEV: remove targetUsernames deprecation
...
Stable already has this rename, no need to carry the deprecation anymore.
2020-04-03 14:35:30 +11:00
Sam Saffron
83f5f9176b
DEV: only load staff logs when page is visited
...
Previously we would load admin staff action logs unconditionally as soon
as the controller was instantiated, this is not desirable we only want to
run the query when you visit the route.
2020-04-03 14:13:01 +11:00
Vinoth Kannan
2f9879a9a1
FIX: move total rows count & load more URL inside meta.
...
We're fetching "total rows count" from root attributes only if meta object not found. 2b78bd01ab/app/assets/javascripts/discourse/models/store.js (L236)
2020-04-03 07:32:50 +05:30
Joffrey JAFFEUX
9c43963ff3
FIX: allows color-input to set hex and color names through input ( #9339 )
2020-04-02 21:19:31 +02:00
Vinoth Kannan
e7e931b70b
FIX: track links in onebox body if it's same as header link.
2020-04-03 00:08:29 +05:30
Daniel Waterworth
76610acb6f
FIX: Default to light theme in wizard so that previews are displayed
...
Previously, without a theme selection, the previews wouldn't show.
2020-04-02 18:37:45 +01:00
Daniel Waterworth
bca126f3f5
REFACTOR: Move the multisite middleware to the front
...
Both request tracking and message bus rely on multisite before the
middleware has run which is not ideal.
Follow-up-to: ca1208a636
2020-04-02 16:44:44 +01:00
Penar Musaraj
724d2e99de
DEV: Only include "report-sample" CSP directive when reporting is enabled ( #9337 )
2020-04-02 11:16:38 -04:00
Arpit Jalan
ef7753953d
FIX: show today's date on /top page period chooser
2020-04-02 20:36:08 +05:30
Daniel Waterworth
ca1208a636
Revert "REFACTOR: Move the multisite middleware to the front"
...
Looks like this is causing problems.
Follow-up-to: a91843f0dc
2020-04-02 15:20:28 +01:00
Zdravko Curic
41510d5b84
FIX: jQuery deprecation warning ( #9331 )
2020-04-02 09:54:51 -04:00
Daniel Waterworth
a91843f0dc
REFACTOR: Move the multisite middleware to the front
...
Both request tracking and message bus rely on multisite before the
middleware has run which is not ideal.
2020-04-02 10:15:38 +01:00
Sam Saffron
8a50ab45aa
DEV: use REPORT_REQUESTS=1 to find all requests
...
We can use this to profile our pretender and ensure nothing is superfluous
and nothing is missing
2020-04-02 16:01:49 +11:00
Vinoth Kannan
37bf38f801
FIX: removing a timer with duration doesn't work.
2020-04-02 05:59:35 +05:30
