1499 Commits

Author	SHA1	Message	Date
Bianca Nenciu	b2eb0f4ad6	FEATURE: Export any type of report supporting table mode. (#7662)	2019-06-28 08:50:31 +02:00
Guo Xiang Tan	8deaef3872	FIX: Don't replace img tags within anchor tags with markdown format. ... Follow up to 9a25b0d614.	2019-06-21 12:32:02 +08:00
Guo Xiang Tan	c9db897777	FIX: Remove onebox src from Jobs::PullHotlinkedImages. ... The test that was added is incorrect because the post was not cooked.	2019-06-14 09:21:25 +08:00
Sam Saffron	457be89445	DEV: only skip migration if a non seeded upload exists ... Followup to 667b9801	2019-06-14 09:52:02 +10:00
Sam Saffron	667b98017a	FIX: do not attempt to migrate pre-existing uploads ... This makes this job re-runnable just in case cause it will skip creation of new uploads if an upload already exists	2019-06-14 09:39:22 +10:00
Guo Xiang Tan	9daed05ad0	Fix the build.	2019-06-13 13:53:43 +08:00
Guo Xiang Tan	f0846ea7cf	DEV: Remove unused line.	2019-06-12 17:38:30 +08:00
Bianca Nenciu	934adb14d2	FIX: On tag change notify only users watching the tag. (#7707)	2019-06-11 18:06:54 +03:00
Guo Xiang Tan	fb0a655e8a	FEATURE: Update pull hotlinked images to use Upload#short_url.	2019-06-11 15:17:29 +08:00
Guo Xiang Tan	9d0fba64c0	FIX: Use attachment format in user export system post take 2.	2019-06-11 12:15:11 +08:00
David Taylor	54afa314fb	FIX: Do not download emojis in pull_hotlinked_images	2019-06-07 13:00:52 +01:00
Bianca Nenciu	f63b8bb79d	FIX: Periodically ensure consistency of categories. (#7663)	2019-06-06 11:30:52 +02:00
Penar Musaraj	f00275ded3	FEATURE: Support private attachments when using S3 storage (#7677) ... * Support private uploads in S3 * Use localStore for local avatars * Add job to update private upload ACL on S3 * Test multisite paths * update ACL for private uploads in migrate_to_s3 task	2019-06-06 13:27:24 +10:00
Neil Lalonde	1cf0b549ab	FIX: don't send post edit notification when hidden tags are changed ... Create a hidden revision so staff can see the changed, but don't send notifications to non-staff.	2019-06-04 15:48:15 -04:00
Arpit Jalan	e7fe7010b8	FIX: use hijack for processing bulk invites (#7679) ... FIX: do not store bulk invite CSV file on server	2019-06-04 20:19:46 +05:30
Neil Lalonde	ecc9c76692	FEATURE: dynamically update the topic heat settings monthly (#7670) ... The site settings beginning with "topic views heat" and "topic post like heat" are set to defaults when installing Discourse, but there has not been a process or guidance for updating these values based on community activity. This feature will update them once a month. The low, medium, and high settings will be based on the minimums of the 45th, 25th, and 10th percentile topics respectively, so that 45% of topics will have some "heat". Disable automatic changes with the automatic_topic_heat_values setting.	2019-06-04 10:34:07 -04:00
Sam Saffron	22abad4151	PERF: stop reindexing and skipping deleted posts	2019-06-04 17:53:35 +10:00
Sam Saffron	74c4f926fc	FIX: drop deleted posts from search index ... This does two things 1. Our "index grace period" has been wound down to 1 day, there is no point keeping a bloated index for a week, usually when people delete stuff they mean for it to be removed 2. We were never dropping deleted posts from the index, only posts from deleted topics These changes speed up search a tiny bit and reduce background work.	2019-06-04 17:19:59 +10:00
Sam Saffron	77300c1d8d	DEV: reindex old data in a more consistent way ... Previously we were grabbing arbitrary rows in many cases which makes diagnosing issues in the indexer more complex	2019-06-04 11:47:24 +10:00
Arpit Jalan	f54a865846	DEV: refactor cleaning up of user export topics	2019-05-30 10:24:45 +05:30
Arpit Jalan	028121b95b	FIX: delete system generated message when user_export record is deleted (#7595) ... FIX: system generated message for user export should be closed by default	2019-05-28 16:38:41 +05:30
Robin Ward	b85fa62882	FIX: Don't send replies to flags that are ignored by expiry ... The `AutoQueueHandler` will ignore really old flags. In that case, don't notify the user that the moderator is looking into it. They probably never saw it because it didn't meet the reviewable minimum priority.	2019-05-27 17:24:36 -04:00
Robin Ward	e74cd54fc6	REFACTOR: Replace score bonuses with low/med/high priorities ... We removed score from the UX so it makes more sense to have sites set priorities instead of score bonuses.	2019-05-23 11:54:45 -04:00
Guo Xiang Tan	ca6c919299	DEV: Remove unused variable. ... Follow up to df1e6eed5a07f49eeda4c0bbd8c63d539aefdb3b..	2019-05-23 16:42:42 +08:00
Guo Xiang Tan	df1e6eed5a	FIX: Pull hotlinked images for lightbox links as well.	2019-05-23 15:44:37 +08:00
Sam Saffron	954293655f	FEATURE: rake posts:destroy_old_user_data_exports ... Historically we would keep the user data export posts around but delete the uploads. This leaves a lot of broken uploads in the system. This rake task allows us to clean up old mess.	2019-05-23 11:11:37 +10:00
Sam Saffron	d9413a61d2	PERF: move crawl_topic_links to the low queue ... Crawling topic links can be somewhat delayed no need to run it in the default queue.	2019-05-22 10:18:49 +10:00
Gerhard Schlager	b788948985	FEATURE: English locale with international date formats ... Makes en_US the new default locale	2019-05-20 13:47:20 +02:00
Robin Ward	225593d445	FIX: Small tweak to percentiles based on feedback	2019-05-16 13:45:36 -04:00
Gerhard Schlager	bbab60fa9b	FIX: Don’t try to delete inactive moderators ... follow-up to 6d77156a	2019-05-13 21:44:03 +02:00
Guo Xiang Tan	8165ceb320	Make rubocop happy.	2019-05-13 09:55:44 +08:00
Sam Saffron	30990006a9	DEV: enable frozen string literal on all files ... This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging	2019-05-13 09:31:32 +08:00
Guo Xiang Tan	f04518fdf9	DEV: Reduce number of jobs enqueued. ... Apply code review suggestion from 405ba00c08.	2019-05-08 15:58:08 +08:00
Guo Xiang Tan	405ba00c08	FEATURE: Create notifications on wiki edits for watching users. ... * Moves creation of notification into background job.	2019-05-08 15:31:10 +08:00
Robin Ward	5af7c90bab	FEATURE: Hide Reviewable scores, change score filter to Priority ... We found score hard to understand. It is still there behind the scenes for sorting purposes, but it is no longer shown. You can now filter by minimum priority (low, med, high) instead of score.	2019-05-07 14:05:23 -04:00
Guo Xiang Tan	451f7842ff	DEV: More send -> public_send.	2019-05-07 10:05:58 +08:00
Guo Xiang Tan	152238b4cf	DEV: Prefer public_send over send.	2019-05-07 09:33:21 +08:00
Sam Saffron	9be70a22cd	DEV: introduce new API to look up dynamic site setting ... This removes all uses of both `send` and `public_send` from consumers of SiteSetting and instead introduces a `get` helper for dynamic lookup This leads to much cleaner and safer code long term as we are always explicit to test that a site setting is really there before sending an arbitrary string to the class It also removes a couple of risky stubs from the auth provider test	2019-05-07 11:00:30 +10:00
Sam Saffron	f8eddd40ad	PERF: remove avg_time calculations and regular jobs from posts and topics ... After careful analysis of large data-sets it became apparent that avg_time had no impact whatsoever on "best of" topic scoring. Calculating avg_time was a very costly operation especially on large databases. We have some longer term plans of introducing other weighting that is read time based into our scoring for "best of" and "top" topics, but in the interim to stop a large amount of work that is not achieving any value we are removing the jobs. Column removal will follow once we decide on a new replacement metric.	2019-05-06 15:59:01 +10:00
Guo Xiang Tan	ebca588fd0	DEV: Remove unused line of code.	2019-05-02 16:54:10 +08:00
Guo Xiang Tan	24347ace10	FIX: Properly associate user_profiles background urls via upload id. ... `Upload#url` is more likely and can change from time to time. When it does changes, we don't want to have to look through multiple tables to ensure that the URLs are all up to date. Instead, we simply associate uploads properly to `UserProfile` so that it does not have to replicate the URLs in the table.	2019-05-02 14:58:24 +08:00
Vinoth Kannan	9c78c18256	Check both site and global setting for s3 enabled value.	2019-05-01 10:49:53 +05:30
Robin Ward	404b35bd04	FEATURE: Category Reviewable by Group ... Allow a group to review content in a particular category.	2019-04-30 15:23:06 -04:00
Sam Saffron	45285f1477	DEV: remove update_attributes which is deprecated in Rails 6 ... See: https://github.com/rails/rails/pull/31998 update_attributes is a relic of the past, it should no longer be used.	2019-04-29 17:32:25 +10:00
Sam Saffron	8fc2b0124f	PERF: destroy users in batches of 50 users ... This speeds up the process as we no longer need to commit a transaction per user deleted	2019-04-26 22:51:33 +10:00
Gerhard Schlager	6d77156a94	FIX: Don't try to delete inactive admins	2019-04-25 11:59:50 +02:00
Guo Xiang Tan	e351b2ee26	Revert "FEATURE: stop running migrate to new scheme once done" ... This reverts commit 2e346e6ea2. Super seeded by 573ddcbbd0.	2019-04-24 14:03:31 +08:00
Sam Saffron	2e346e6ea2	FEATURE: stop running migrate to new scheme once done ... This setting will automatically disable itself when there are no longer any problem uploads	2019-04-24 14:32:39 +10:00
Guo Xiang Tan	149411ec90	PERF: Speed up Upload.migrate_to_new_scheme by limiting remap scope. ... Doing a `LIKE` on `Post#raw` and `Post#cooked` takes forever on large sites.	2019-04-24 11:56:48 +08:00
Robin Ward	fca3f53e9c	FIX: Safer scoring with concurrency	2019-04-23 15:53:37 -04:00
Robin Ward	70097966ed	FIX: Don't add the reviewable score twice	2019-04-23 15:46:18 -04:00
Robin Ward	6f56fba016	UX: Update post actions to "Approve Post" and "Reject Post" ... This should be more clear.	2019-04-23 12:19:11 -04:00
Gerhard Schlager	a7bc1ecbae	FEATURE: Add support for Unicode usernames and group names ... Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>	2019-04-23 13:00:27 +02:00
Michał Frąckiewicz	8f7cfc29db	FIX: Detect SNS notifications for SES correctly (#7284) ... * Fix handling SNS notifications for AWS SES This fixes detection of email bounce by: - removing hard requirement for email ID, ID in webhook msg never equals this in email_log - gets bounce_score from user stats instead of nonexistent field in webhook msg * Remove empty line * Prettify access to EmailLog for parsing SNS notification Co-Authored-By: SystemZ <SystemZ@users.noreply.github.com>	2019-04-23 13:03:31 +10:00
Guo Xiang Tan	0210b0aabc	REFACTOR: Prefer accessing instance variables directly. ... * No need to wrap instance variables with another method to read it. * Remove memoization that wasn't really memozing anything.	2019-04-20 09:39:25 +08:00
Tarek Khalil	6e46197bc8	FIX: Disable webhooks on 410 and 404 HTTP responses (#7392) ... FIX: Disable webhooks on 410 and 404 HTTP responses (#7392)	2019-04-18 12:36:37 +01:00
Robin Ward	14f9d40e48	FEATURE: Clarify Reviewable User Actions ... "Approve" is now "Approve User" and "Delete" is a dropdown with a choice that allows you to block.	2019-04-17 11:44:17 -04:00
Tarek Khalil	02a9429c38	REFACTOR: Quick refactor of the webhook event emitter job (#7385) ... * REFACTOR: Quick refactor of the webhook event emitter job	2019-04-17 10:03:23 +01:00
Robin Ward	ba6d4b2a8d	FIX: Better handling for toggling must_approve_users ... If you turn it on now, default all users to approved since they were previously. Also support approving a user that doesn't have a reviewable record (it will be created first.) This also includes a refactor to move class method calls to `DiscourseEvent` into an initializer. Otherwise the load order of classes makes a difference in the test environment and some settings might be triggered and others not, randomly.	2019-04-16 15:56:35 -04:00
Guo Xiang Tan	d6e45864ce	Fix failing spec.	2019-04-16 09:59:35 +08:00
Guo Xiang Tan	ce4c8e957b	PERF: Avoid looking up the same group multiple times during bulk invite. ... Also cache the guardian check because it does a query to check if the user is an owner of the group.	2019-04-16 09:42:25 +08:00
Guo Xiang Tan	25514550f0	FIX: Bulk invite should skip invite and add existing users to groups.	2019-04-16 09:42:25 +08:00
Guo Xiang Tan	6e6cdfaf80	FIX: Bulk invite should not add users to automatic groups. ... * Also checks that the user creating the bulk invite has permission.	2019-04-16 09:42:25 +08:00
Dan Ungureanu	e23c87c442	FIX: Prevent exception in rescue block. ... > Job exception: undefined method `id' for nil:NilClass > clean_up_inactive_users.rb:25:in `rescue in block in execute'	2019-04-16 01:27:39 +03:00
Arpit Jalan	594674703c	FIX: properly log webhook errors in UI on rescue (#7376)	2019-04-15 12:19:48 +05:30
Robin Ward	f7ebfb1acc	FIX: Only consider pending queued posts for cleaning up uploads	2019-04-12 14:39:32 -04:00
David Taylor	268d4d4c82	FEATURE: Multiple SCSS file support for themes (#7351) ... Theme developers can include any number of scss files within the /scss/ directory of a theme. These can then be imported from the main common/desktop/mobile scss.	2019-04-12 11:36:08 +01:00
Robin Ward	c0c236f36e	FIX: Better to put a ReviewableUser back into pending than silently fail	2019-04-11 16:36:47 -04:00
Robin Ward	d21dd521d2	FIX: Don't try to create a reviewable user twice	2019-04-11 12:30:54 -04:00
Robin Ward	331a809738	FEATURE: Display the reason for many reviewable items ... Queued Posts and Users will now display a reason why they are in the review queue.	2019-04-11 12:04:45 -04:00
Régis Hanol	ab79060468	FIX: don't send activation reminder to staged users	2019-04-10 17:29:08 +02:00
Bianca Nenciu	3d545d66df	FEATURE: Send user activation reminders. (#7280)	2019-04-10 16:53:52 +02:00
Tarek Khalil	442fb2facb	FEATURE: Remove ignore feature SiteSetting and enable ignore by default (#7349)	2019-04-10 12:54:59 +02:00
Sam Saffron	ec1c3559da	PERF: correct clean up inactive so it does not clog scheduler ... also add a hard limit of 1000 users per job run so we do not clog the scheduler destroyer.destroy has a transaction and this can have some serious complications with the open record set find_each has going	2019-04-09 22:25:05 +10:00
Guo Xiang Tan	6d0e8821f8	FIX: Optimize query and avoid bloating memory in Jobs::MigrateUploadScheme.	2019-04-09 15:45:30 +08:00
Vinoth Kannan	914ada1c74	DEV: convert scheduled job EnsurePostUploadsExistence into a rake task	2019-04-09 02:07:35 +05:30
Guo Xiang Tan	108c231d1c	FIX: Clean up topic_search_data of trashed topics. ... This keeps the index and table smaller.	2019-04-08 16:53:39 +08:00
Guo Xiang Tan	c4997ce85f	FIX: Don't try and reindex posts that have been trashed.	2019-04-08 16:38:43 +08:00
Maja Komel	ca33d091b3	FIX: don't trigger notifications when changing category/tags of unlisted topics (#7323)	2019-04-05 15:06:38 +02:00
Robin Ward	c9ddc6ce30	FIX: Make sure the site setting works and fix build	2019-04-04 17:44:10 -04:00
Vinoth Kannan	2c7a50860f	DEV: disable missing post uploads check by default.	2019-04-05 02:29:10 +05:30
Vinoth Kannan	a385f6c48a	REFACTOR: create custom field even when missing post uploads not found	2019-04-04 21:49:44 +05:30
Vinoth Kannan	44e87372da	FEATURE: Add scheduled job to ensure s3 uploads existence	2019-04-04 20:37:44 +05:30
Arpit Jalan	f87b35e6f4	FIX: do not raise exception if the file is missing	2019-04-04 15:36:51 +05:30
Robin Ward	588f61f717	FIX: Linting	2019-04-03 18:08:07 -04:00
Vinoth Kannan	3b581de3b8	remove unrelated code ... already added in a separate job	2019-04-04 02:26:28 +05:30
Vinoth Kannan	b3fb0a7039	FEATURE: ensure consistency of post uploads in cooked content	2019-04-04 02:23:28 +05:30
Robin Ward	111a502231	FIX: Deleting Users should work nicely with Reviewable Users ... "Rejecting" a user in the queue is equivalent to deleting them, which would then making it impossible to review rejected users. Now we store information about the user in the payload so if they are deleted things still display in the Rejected view. Secondly, if a user is destroyed outside of the review queue, it will now automatically "Reject" that queue item.	2019-04-03 16:42:39 -04:00
Robin Ward	82bddcbe51	FIX: Don't create two reviewable scores for a user	2019-04-03 16:03:32 -04:00
Robin Ward	c1ea63bdc1	FIX: Reviewables should not be created for users until they are active ... Conversely, if a user is deactivated the reviewable should automatically be rejected. Before this fix, if a user was not active they'd still show in the review queue but without an "Approve" button which was confusing.	2019-04-03 15:25:00 -04:00
Guo Xiang Tan	d151425353	PERF: Delete search data of posts from trashed topics periodically. (#7302) ... This keeps both the index and table smaller.	2019-04-03 10:10:41 +08:00
Guo Xiang Tan	feb731bffd	FIX: Regenerate optimized images instead of migrating from old scheme. ... `OptimizedImage.migrate_to_new_scheme` was optimizing optimized images which we don't need to do. Regnerating the optimized image is way easier.	2019-04-03 09:45:02 +08:00
Guo Xiang Tan	d8704c11ca	PERF: Better use of index when queueing a topci for search reindex. ... Also move `Search::INDEX_VERSION` to `SearchIndexer` which is where the version is actually being used.	2019-04-02 09:53:37 +08:00
Guo Xiang Tan	aa2311a7b0	FIX: Don't reindex posts belonging to a deleted topic for search. ... Posts belonging to a deleted topic can't be index for search so we need to avoid loading those post ids.	2019-04-02 07:36:53 +08:00
Guo Xiang Tan	3fc5dbb045	FIX: Don't attempt to reindex posts that have an empty raw. ... If the post ids keep loading, we might end up in a situations where we're always loading the same post ids over and over again without indexing anything new. Follow up to daeda80ada.	2019-04-02 07:13:33 +08:00
Robin Ward	76669bb5a6	FIX: Don't refer to pending review items as flags ... They could be queued posts or users, and the notice should reflect that properly.	2019-04-01 14:46:56 -04:00
Guo Xiang Tan	8794d940d3	Revert update_columns -> update! when rebaking/post-processing post. ... `update!` goes through validation which means old posts that doesn't adhere to the existing validations will raise an error.	2019-04-01 16:29:00 +08:00
Guo Xiang Tan	cfd507822f	PERF: Improve quality of PostSearchData#raw_data. (#7275) ... This commit fixes the follow quality issue with `PostSearchData#raw_data`: 1. URLs are being tokenized and links with similar href and characters are being duplicated in the raw data. `Post#cooked`: ``` <p><a href=\"https://meta.discourse.org/some.png\" class=\"onebox\" target=\"_blank\" rel=\"nofollow noopener\">https://meta.discourse.org/some.png</a></p> ``` `PostSearchData#raw_data` Before: ``` This is a test topic 0 Uncategorized https://meta.discourse.org/some.png discourse org/some png https://meta.discourse.org/some.png discourse org/some png ``` `PostSearchData#raw_data` After: ``` This is a test topic 0 Uncategorized https://meta.discourse.org/some.png meta discourse org ``` 2. Ligthbox being included in search pollutes the `PostSearchData#raw_data` unncessarily. From 28 March 2018 to 28 March 2019, searches for the term `image` on `meta.discourse.org` had a click through rate of 2.1%. Non-lightboxed images are not included in indexing for search yet we were indexing content within a lightbox. Also, search for terms like `image` was affected we were using `Pasted image` as the filename for uploads that were pasted. `Post#cooked` ``` <p>Let me see how I can fix this image<br>\n<div class=\"lightbox-wrapper\"><a class=\"lightbox\" href=\"https://meta.discourse.org/some.png\" title=\"some.png\" rel=\"nofollow noopener\"><img src=\"https://meta.discourse.org/some.png\" width=\"275\" height=\"299\"><div class=\"meta\">\n<svg class=\"fa d-icon d-icon-far-image svg-icon\" aria-hidden=\"true\"><use xlink:href=\"#far-image\"></use></svg><span class=\"filename\">some.png</span><span class=\"informations\">1750×2000</span><svg class=\"fa d-icon d-icon-discourse-expand svg-icon\" aria-hidden=\"true\"><use xlink:href=\"#discourse-expand\"></use></svg>\n</div></a></div></p> ``` `PostSearchData#raw_data` Before: ``` This is a test topic 0 Uncategorized Let me see how I can fix this image some.png png https://meta.discourse.org/some.png discourse org/some png some.png png 1750×2000 ``` `PostSearchData#raw_data` After: ``` This is a test topic 0 Uncategorized Let me see how I can fix this image ``` In terms of indexing performance, we now have to parse the given HTML through nokogiri twice. However performance is not a huge worry here since a string length of 194170 takes only 30ms to scrub plus the indexing takes place in a background job.	2019-04-01 10:14:29 +08:00
Guo Xiang Tan	daeda80ada	FIX: Don't index posts with empty Post#raw for search. (#7263) ... * DEV: Remove unnecessary join in `Jobs::ReindexSearch`. * FIX: Don't index posts with empty `Post#raw` for search.	2019-04-01 10:06:27 +08:00
Tarek Khalil	b1cb95fc23	FEATURE: Introduce ignore duration selection (#7266) ... * FEATURE: Introducing new UI for tracking User's ignored or muted states	2019-03-29 10:14:53 +00:00
Robin Ward	b58867b6e9	FEATURE: New 'Reviewable' model to make reviewable items generic ... Includes support for flags, reviewable users and queued posts, with REST API backwards compatibility. Co-Authored-By: romanrizzi <romanalejandro@gmail.com> Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>	2019-03-28 12:45:10 -04:00
David Taylor	95d5819218	FIX: Re-download hotlinked optimized images (#7249) ... * FIX: Download local images, even if download remote is disabled	2019-03-27 21:31:12 +01:00
Guo Xiang Tan	b58c965aad	FIX: Destroy optimized image if attempting to migrate to new scheme fails.	2019-03-26 14:37:34 +08:00
Neil Lalonde	399e937a38	FIX: prevent sending multiple summary emails due to Sidekiq delays	2019-03-22 12:34:34 -04:00
David Taylor	a9d5ffbe3d	FIX: Prevent critical emails bypassing disable, and improve email test logic ... - The test_email job is removed, because it was always being run synchronously (not in sidekiq) - 34b29f62 added a bypass for critical emails, to match the spec. This removes the bypass, and removes the spec. - This adapts the specs for 72ffabf6, so that they check for emails being sent - This reimplements c2797921, allowing test emails to be sent even when emails are disabled	2019-03-22 17:28:43 +08:00
Vinoth Kannan	1e3cb7575d	DEV: Update webhook event attributes even when an error raised	2019-03-21 20:45:21 +05:30
Vinoth Kannan	4c6bfb9b39	DEV: Don't destroy webhook in case of error	2019-03-21 18:34:54 +05:30
Tarek Khalil	a31a35b334	FEATURE: Ignored user notification behaviour should be as a muted user (#7227)	2019-03-21 12:15:34 +01:00
Tarek Khalil	fed2dd9148	FEATURE: Add scheduled job to purge expired ignored users (#7211)	2019-03-20 11:01:43 +01:00
Régis Hanol	31e06dbcd2	FIX: SES webhook wasn't parsing the message	2019-03-19 11:40:19 +01:00
Guo Xiang Tan	4020c87680	DEV: Refactor tests for Jobs::CleanUpInactiveUsers. ... * Remove use of 0 in favor of `TrustLevel.levels[:newuser]`. * Consolidate two tests into a single one. * Test that disabling the feature works. * Avoid loading full ActiveRecord object in test when we only need to know the existence of the record.	2019-03-19 09:57:21 +08:00
Bianca Nenciu	2347661a74	FEATURE: Clean up inactive users. (#7172)	2019-03-18 16:25:15 +01:00
Bianca Nenciu	5114ef958a	FIX: Do not trigger post alerts for empty posts. (#7138)	2019-03-15 17:58:43 +01:00
Penar Musaraj	9334d2f4f7	FEATURE: add more granular user option levels for email notifications (#7143) ... Migrates email user options to a new data structure, where `email_always`, `email_direct` and `email_private_messages` are replace by * `email_messages_level`, with options: `always`, `only_when_away` and `never` (defaults to `always`) * `email_level`, with options: `always`, `only_when_away` and `never` (defaults to `only_when_away`)	2019-03-15 10:55:11 -04:00
Tarek Khalil	bd6d31c9ec	FEATURE: Add IgnoredUsersSummary daily job (#7144) ... * FEATURE: Add `IgnoredUsersSummary` daily job ## Why? This is part of the [Ability to ignore a user feature](https://meta.discourse.org/t/ability-to-ignore-a-user/110254/8). We want to: 1. Send an automatic group PM that goes out to moderators 2. When {x} users have Ignored the same user, threshold defined by a site setting, default of 5 3. Only send this message every X days which is defined by another site setting	2019-03-14 22:51:43 +00:00
Robin Ward	fa5a158683	REFACTOR: Move queue_jobs out of SiteSetting ... It is not a setting, and only relevant in specs. The new API is: ``` Jobs.run_later! # jobs will be thrown on the queue Jobs.run_immediately! # jobs will run right away, avoid the queue ```	2019-03-14 10:47:38 -04:00
Guo Xiang Tan	b0c8fdd7da	FIX: Properly support defaults for upload site settings.	2019-03-13 16:36:57 +08:00
Bianca Nenciu	c6ed86220e	FIX: Notify on tag change. (#7119)	2019-03-12 18:09:34 +01:00
Guo Xiang Tan	34b29f62db	DEV: Remove the use of stubs and mocks in Jobs::UserEmail tests. ... We can only be sure that an email is sent when we get a mailer in `ActionMailer::Deliveries`. A couple of tests were actually incorrect because it didn't flow through our email sender where there are more conditions in determining whether an email is sent or not.	2019-03-12 09:39:16 +08:00
Dan Ungureanu	32bae48fd3	DEV: Use User#human? User#bot? (#7140)	2019-03-12 07:58:14 +08:00
David Taylor	0a4562253e	DEV: Add 'starting' event to sidekiq log when interval logging enabled	2019-03-08 10:56:36 +00:00
David Taylor	e2510d79cc	DEV: Improve thread-safety of sidekiq logging	2019-03-08 10:31:49 +00:00
David Taylor	9db05a895a	DEV: Add job_id to sidkiq log ... This makes it easier to correlate 'pending' logs from the same job	2019-03-08 09:16:13 +00:00
Gerhard Schlager	1121514799	UX: Localize date format in "new user of the month" message	2019-03-06 21:58:25 +01:00
David Taylor	df474bceee	DEV: Further sidekiq logging stability improvements ... - Open the log file in "append" mode. This avoids issues if the file does not exist (and matches standard rails log behavior) - Correctly parse the interval logging environment variable	2019-03-06 12:50:15 +00:00
David Taylor	fe62de68dd	DEV: Correct sidekiq logging to avoid thread leak	2019-03-06 10:11:31 +00:00
David Taylor	8b30ed5b7a	DEV: Serialize the job parameters in sidekiq logs ... Otherwise this can lead to some very large data structures when processing the logs later	2019-03-05 17:44:49 +00:00
David Taylor	8963f1af30	FEATURE: Optional detailed performance logging for Sidekiq jobs (#7091) ... By default, this does nothing. Two environment variables are available: - `DISCOURSE_LOG_SIDEKIQ` Set to `"1"` to enable logging. This will log all completed jobs to `log/rails/sidekiq.log`, along with various db/redis/network statistics. This is useful to track down poorly performing jobs. - `DISCOURSE_LOG_SIDEKIQ_INTERVAL` (seconds) Check running jobs periodically, and log their current duration. They will appear in the logs with `status:pending`. This is useful to track down jobs which take a long time, then crash sidekiq before completing.	2019-03-05 11:19:11 +00:00
Régis Hanol	326d892f5e	Aadd 'secondary_emails' field in users export ... FIX: escape_comma wasn't working in CSV exports FIX: group_names field wasn't properly serialized	2019-02-27 10:12:20 +01:00
Régis Hanol	e3a23116d2	FIX: don't update gravatar if the user has no email	2019-02-20 22:34:43 +01:00
Régis Hanol	fc14847c14	PERF: only require aws-sdk-sns gem when it's being used	2019-02-14 11:08:21 +01:00
Vinoth Kannan	484bd82278	FIX: Add onceoff job to remove double quotes from s3 etags	2019-02-14 05:19:41 +05:30
Régis Hanol	4d674acc25	FEATURE: AWS SNS bounce notifications webhooks	2019-02-13 21:26:40 +01:00
Vinoth Kannan	b4f713ca52	FEATURE: Use amazon s3 inventory to manage upload stats (#6867)	2019-02-01 10:10:48 +05:30
Robin Ward	78ddc82952	FIX: Respect min_flags_staff_visibility for new flags too ... There was a situation where if: * There were new flags to review that met the visibility threshold AND * There were old flags that *didn't* meet the threshold THEN a pending flags notification would be sent out. This fixes that case. Staff should not be notified of flags if they do not meet the threshold and are old.	2019-01-25 11:27:43 -05:00
Robin Ward	96b2585a91	REFACTOR: Remove unncessary stubs from pending flags reminder ... They seem to be calculated fine by the application, and stubbing makes the tests more brittle and prone to regression.	2019-01-24 13:45:58 -05:00
Robin Ward	f32de88dfc	FIX: Don't notify of pending flags if min_flags_staff_visibility not met	2019-01-22 11:01:18 -05:00
Guo Xiang Tan	95e3841974	FIX: Remove old reference and use MiniScheduler::Stat.	2019-01-18 16:36:11 +08:00
Sam	384135845b	FEATURE: introduce ultra_low priority queue ... This commit introduces an ultra low priority queue for post rebakes. This way rebakes can never interfere with regular sidekiq processing for cases where we perform a large scale rebake. Additionally it allows Post.rebake_old to be run with rate_limiter: false to avoid triggering the limiter when rebaking. This is handy for cases where you want to just force the full rebake and not wait for it to trickle	2019-01-17 14:53:19 +11:00
Bianca Nenciu	7d84648d11	FEATURE: Remove full quotes only from new posts. (#6862)	2019-01-17 13:24:32 +11:00
Saurabh Patel	b63b399799	DEV: remove uploaded_meta_id column from category (#6725) ... * DEV: remove uploaded_meta_id column from category * remove uploaded_meta part	2019-01-10 09:37:21 +08:00
Sam	e08a3f719c	FEATURE: push post rebake regular task to low priority queue ... This allows us to run regular rebakes without starving the normal queue. It additionally adds the ability to specify queue with `Jobs.enqueue` so we can specifically queue a job with lower priority using the `queue` arg.	2019-01-09 08:57:20 +11:00
Vinoth Kannan	8f602be2fe	FEATURE: keep the topic in closed status until the community flags are handled	2019-01-08 16:13:10 +05:30
David Taylor	5bf16d7d10	FEATURE: Topic timer for bumping a topic in the future	2019-01-04 13:08:04 +00:00
Gerhard Schlager	1a8ca68ea3	FEATURE: Improve backup stats on admin dashboard ... * Dashboard doesn't timeout anymore when Amazon S3 is used for backups * Storage stats are now a proper report with the same caching rules * Changing the backup_location, s3_backup_bucket or creating and deleting backups removes the report from the cache * It shows the number of backups and the backup location * It shows the used space for the correct backup location instead of always showing used space on local storage * It shows the date of the last backup as relative date	2018-12-17 11:35:11 +01:00
Sam	f74ef71130	DEV: add transaction and active check to invalidate job ... Follows up on 3b76f19668 this per @tgxworld a transaction makes sense here Very minor	2018-12-13 14:59:56 +11:00
Neil Lalonde	3b76f19668	FIX: invalidating inactive admin emails should mark them as not active	2018-12-12 17:07:49 -05:00
Neil Lalonde	a1db15fead	FEATURE: require admins to re-validate their email addresses if they haven't been seen for a number of days, configurable with the invalidate_inactive_admin_email_after_days site setting. Social logins are also revoked. Default is 365 days.	2018-12-12 15:32:38 -05:00
David Taylor	9db829134c	FIX: Use database to persist metadata during social registration (#6750) ... Previously was using the cookie_store, which is limited to 4kb. This caused issues for providers sending large volumes of metadata about a user.	2018-12-10 15:10:06 +00:00
Saurabh Patel	9e3143445b	DEV:add uploaded_meta option in category for category meta image (#6724)	2018-12-07 16:24:07 +01:00
Sam	8e307e633e	FIX: posts would not auto rebake unless gravatar download was enabled	2018-12-07 17:03:22 +11:00
Vinoth Kannan	d33d031742	FEATURE: Filter topic and post web hook events by tags (#6726) ... * FEATURE: Filter topic and post web hook events by tags * Add a spec test with unmatched tags	2018-12-05 14:44:06 +05:30
Régis Hanol	3c9c95ac83	Update Rubocop to 0.60	2018-12-04 10:48:16 +01:00
Guo Xiang Tan	eecd1a7d8c	FIX: Jobs::CleanUpUploads fails when value of upload data_type is an empty string.	2018-11-30 10:46:39 +08:00
Guo Xiang Tan	ba280f9cf3	FIX: Give up migrating url site setting if endpoint doesn't return data.	2018-11-22 12:16:52 +08:00
Guo Xiang Tan	a8603e04ab	FIX: Give up migration of URL site settings if there is an SSL error.	2018-11-22 12:14:27 +08:00
Guo Xiang Tan	df72674f24	Warn when migrate url site settings job encounters an error.	2018-11-21 07:55:50 +08:00
Guo Xiang Tan	81b3bdaabd	FIX: Remove site settings override for deprecated url site settings.	2018-11-20 11:42:39 +08:00
Guo Xiang Tan	9fd704735e	Rescue from SocketError in migrate url onceoff job.	2018-11-19 13:07:34 +08:00
Guo Xiang Tan	9e86b425bc	FIX: Job to clean up old URL settings when new setting has been set. ... Related to 44391ee8ab	2018-11-16 09:33:31 +08:00
Guo Xiang Tan	901611cb4e	Fix migrate upload url site settings to rescue from invalid URLs.	2018-11-15 15:16:14 +08:00
Guo Xiang Tan	5b320e6652	DEV: Don't warn about using deprecated site settings in clean up uploads job.	2018-11-14 20:58:06 +08:00
Guo Xiang Tan	df111259fe	More URL site settings into a onceoff job. ... * Doing it in a post migration was a bad idea because the migration will fail if the site is down while trying to download uploads which points to the instance. This mainly affects self-hosters using `discourse_docker` where `./launcher rebuild` will take the existing container down.	2018-11-14 20:29:20 +08:00
Guo Xiang Tan	44391ee8ab	FEATURE: Upload Site Settings. (#6573)	2018-11-14 15:03:02 +08:00
Guo Xiang Tan	7b44339529	FIX: Prevent uploads used in site settings from being deleted.	2018-11-13 09:15:16 +08:00
Gerhard Schlager	24e5be3f0c	FIX: Relative links in translations should work with subfolder	2018-11-08 23:31:05 +00:00
Bianca Nenciu	2070edf889	FIX: Clarify User.group_locked_trust_level. ... * Rename User.group_locked_trust_level to User.group_granted_trust_level. * Remove the column from users table.	2018-11-07 10:27:44 +08:00
Bianca Nenciu	e0ccd36dbe	FEATURE: Suspicious logins report. (#6544)	2018-10-30 22:51:58 +00:00
Bianca Nenciu	6a3767cde7	FEATURE: Warn users via email about suspicious logins. (#6520) ... * FEATURE: Warn users via email about suspicious logins. * DEV: Move suspicious login check to a job.	2018-10-25 09:45:31 +00:00
Sam	de6b585368	minor, bypass gravatar update if user does not match ... this protects against a race condition that can happen when a user record is destroyed reasonably quickly	2018-10-23 12:20:41 +11:00
Kyle Zhao	0f1afad6da	FIX: extracted theme JavaScripts for multisite (#6502) ... * FIX: extracted theme javascripts for multisite * onceoff to rebake all theme fields	2018-10-18 17:05:34 +11:00
Sam	8d06731484	FIX: reduce amount of work onceoff does ... In the past onceoff was forcing inline download of gravatars, this can be so expensive that it will never finish This fix ensures it only marks avatars stale which will be picked up by regular schedules	2018-10-16 10:29:16 +11:00
Guo Xiang Tan	84d4c81a26	FEATURE: Support backup uploads/downloads directly to/from S3. ... This reverts commit 3c59106bac.	2018-10-15 09:43:31 +08:00
Régis Hanol	09961fb425	FIX: properly escape name of custom emoji	2018-10-11 09:35:23 +02:00
Guo Xiang Tan	3c59106bac	Revert "FEATURE: Support backup uploads/downloads directly to/from S3." ... This reverts commit c29a4dddc1. We're doing a beta bump soon so un-revert this after that is done.	2018-10-11 11:08:23 +08:00
Gerhard Schlager	c29a4dddc1	FEATURE: Support backup uploads/downloads directly to/from S3.	2018-10-11 10:38:43 +08:00
Bianca Nenciu	e0e0a91e7d	FIX: Retry sending email in case of temporary issue. (#6375)	2018-10-04 22:56:24 +08:00
Gerhard Schlager	3a6ab02563	FEATURE: Notify admins when scheduling of backup fails	2018-10-02 15:48:16 +02:00
Guo Xiang Tan	d8fa7fbbab	Fix onceoff job in cfa7173da3 not running.	2018-10-01 17:14:04 +08:00
Guo Xiang Tan	cfa7173da3	FIX: Onceoff job to fix missing user profile backgrounds.	2018-10-01 16:26:40 +08:00
Robin Ward	02da022c70	PERF: Quit out of the email job quickly if disabled (#6423) ... This prevents sidekiq from doing a bunch of queries when email is disabled. Critical emails are a special case and will be sent.	2018-10-01 01:15:45 +08:00
Guo Xiang Tan	767f27929d	Rename Jobs::RecoverPostUploads to rerun the job take 2.	2018-09-19 22:40:32 +08:00
Guo Xiang Tan	6dbe1d832d	Rename Jobs::RecoverPostUploads to rerun the job. ... Running a migration to destroy the onceoff job doesn't work because an instance running the old code may execute the job.	2018-09-19 21:59:44 +08:00
Guo Xiang Tan	667e68ec58	Prefer create over create! when not checking for response.	2018-09-19 18:22:54 +08:00
Guo Xiang Tan	aa1af9fc22	FIX: Onceoff job to recover missing post uploads. ... This fixes the regression due to 1f636c445b	2018-09-14 09:04:01 +08:00
Guo Xiang Tan	e1b16e445e	Rename FileHelper.is_image? -> FileHelper.is_supported_image?.	2018-09-12 09:22:28 +08:00
Gerhard Schlager	797cbf8653	FIX: Remove user fields when anonymizing user	2018-09-07 00:02:56 +02:00
Guo Xiang Tan	b6a139b581	Fix broken spec.	2018-09-06 12:41:43 +08:00
Sam	d9c0dc8687	correct prev commit ... s3. did not exists it is s3-	2018-09-05 16:11:44 +10:00
Sam	83e1315e42	FIX: correct urls in uploads table to point at dualstack ... Last week we added support for dual stack urls but did not remap the the old records in the uploads and optimized images table This caused a few minor edge cases worst was that if you rebaked old images S3 CDN was not repopulated.	2018-09-05 15:58:04 +10:00
Sam	e4498d2a8a	FIX: keep db and job correctly in multisite logs ... This ensures we report job and db correctly, previously we were only reporting this on default	2018-09-04 16:05:44 +10:00
Sam	e1975e293f	FIX: when uploads are destroyed clear up avatar refs in user table ... This also auto corrects twice daily when we ensure consistency	2018-08-31 14:46:42 +10:00
Guo Xiang Tan	4f81d4cc8e	Minor fixes to Jobs::BulkInvite.	2018-08-30 15:35:16 +08:00
Gerhard Schlager	b2cf725700	FIX: Don't try to send invite email when invite was deleted	2018-08-29 12:43:12 +02:00
Sam	44cf3cf975	FIX: queue heartbeats in readonly modes ... If sidekiq is paused or Discourse is in readonly continue to queue heartbeats If we do not do that then a master process can end up reaping sidekiq workers and causing various badness This also impacts restore which can do weird stuff TM in cases like this	2018-08-29 12:36:59 +10:00
Sam	740308675b	FEATURE: erode bounce score every time an email is sent ... Introduces a hidden setting (default is 0.1) that erodes bounce score every time we send an email. This means that erratic failures are less painful cause system auto corrects	2018-08-28 17:02:12 +10:00
Sam	9ab1fb7dfc	FEATURE: correctly store width and height on uploads ... Previously we used width and height for thumbnails, new code ensures 1. We auto correct width and height 2. We added extra columns for thumbnail_width and height, this is determined by actual upload and no longer passed in as a side effect 3. Optimized Image now stores filesize which can be used for analysis, decisions Also - fixes Android image manifest as a side effect - fixes issue where a thumbnail generated that is smaller than the upload is no longer used	2018-08-28 12:59:22 +10:00
Guo Xiang Tan	36a7028f19	FEATURE: Clean up PostReplyKey records. ... * Default retention of 90 days.	2018-08-23 10:40:02 +08:00
Guo Xiang Tan	8bdf14834b	PERF: Restrict number of skipped email log for Jobs::UserEmail.	2018-08-21 11:14:43 +08:00
Guo Xiang Tan	2c70d3f443	Take 2 on ba6f11c521.	2018-08-21 10:06:36 +08:00
Bianca Nenciu	860c1c3dcd	FEATURE: Automatically expire keys if not used for a configurable amount of time. (#6264)	2018-08-20 17:36:14 +02:00
Guo Xiang Tan	16c0ebe8a8	Fix the build.	2018-08-17 16:53:07 +08:00
Sam	796164b58c	FIX: automatically correct bad avatars on access ... Also start relying on upload extension for optimized images	2018-08-16 16:32:56 +10:00
Sam	1f17b84b63	FEATURE: more context for error reporting on jobs fails	2018-08-16 12:38:49 +10:00
Régis Hanol	de92913bf4	FIX: store the topic links using the cooked upload url	2018-08-14 12:23:32 +02:00
Guo Xiang Tan	ba022234c6	Add onceoff job to fix incorrect upload extensions.	2018-08-13 10:44:08 +08:00
Gerhard Schlager	b73950692b	FIX: Parsing non-existent feed should not fail	2018-08-10 18:37:14 +02:00
Simon Cossar	3cd4dc0f5f	Allow users with group_locked_trust_level to be promoted to tl3 (#6249)	2018-08-10 10:42:23 +10:00
Guo Xiang Tan	ba6f11c521	PERF: Only log the first skipped email when user exceeds daily limit. ... https://meta.discourse.org/t/cleaning-up-e-mail-logs/39132	2018-08-08 16:25:00 +08:00
Guo Xiang Tan	d5a7b818ba	FIX: Move Jobs::CreateAvatarThumbnails to low priority queue.	2018-08-07 16:05:54 +08:00
Guo Xiang Tan	4e11811321	FIX: UserAvatar#update_gravatar! does not update User#uploaded_avatar. ... https://meta.discourse.org/t/missing-user-profile-pictures/93844/4	2018-08-06 13:29:44 +08:00
Osama Sayegh	880462a41c	FEATURE: display out of date themes on admin dashboard ... * FEATURE: disaply out of date themes on admin dashboard * Update copy	2018-08-03 09:53:48 +10:00
Neil Lalonde	b829452c75	Merge pull request #6209 from discourse/mini_scheduler ... REFACTOR: extract scheduler to the mini_scheduler gem	2018-08-01 10:28:24 -04:00
Joffrey JAFFEUX	0b9437cee7	FIX: more resilient/consistent dashboard caching (#6223)	2018-08-01 09:45:50 -04:00
Gerhard Schlager	a115aae45f	Use rchardet instead of charlock_holmes gem	2018-08-01 10:41:20 +02:00
Gerhard Schlager	5d421fb946	FIX: Try respecting charset in HTTP header of RSS feed	2018-08-01 10:41:20 +02:00
Gerhard Schlager	ff942ed2f3	FIX: Try detecting encoding of RSS feed	2018-08-01 10:41:20 +02:00
Neil Lalonde	4ad7ce70ce	REFACTOR: extract scheduler to the mini_scheduler gem	2018-07-31 17:12:55 -04:00
Guo Xiang Tan	acde8d4323	Fix the build.	2018-07-30 15:07:03 +08:00
Guo Xiang Tan	96a0448c52	FIX: Add onceoff job to fix incorrect extension for gravatar uploads.	2018-07-30 14:44:02 +08:00
Guo Xiang Tan	87537b679c	Drop reply_key, skipped and skipped_reason from email_logs.	2018-07-30 11:39:28 +08:00
Guo Xiang Tan	ccf76d45f2	FIX: Missing variable outside of begin block.	2018-07-27 08:19:11 +08:00
Joffrey JAFFEUX	796639a797	FIX: makes disk_space computation more resilient (#6172)	2018-07-25 11:04:01 -04:00
Gerhard Schlager	c3b6811651	PERF: Split loading of posts to speed up user renames	2018-07-24 11:57:04 +02:00
Guo Xiang Tan	fad9c2b971	PERF: Move EmailLog#reply_key into new post_reply_keys table.	2018-07-24 13:51:53 +08:00
Guo Xiang Tan	ae8b0a517f	PERF: Split skipped email logs into a seperate table.	2018-07-24 13:14:37 +08:00
Vinoth Kannan	f8e9190617	FEATURE: Retry web hook when it is failed	2018-07-23 10:12:04 +08:00
Joffrey JAFFEUX	06323f9c89	FIX: takes old dashboard out of caching job	2018-07-21 12:42:03 -04:00
Joffrey JAFFEUX	0972dd2552	FIX: takes dashboard-next out of caching job	2018-07-21 11:13:15 -04:00
Joffrey JAFFEUX	1d5096eb46	FIX: lazy load more reports in dashboard	2018-07-20 23:35:53 -04:00
Joffrey JAFFEUX	1a78e12f4e	FEATURE: part 2 of dashboard improvements ... - moderation tab - sorting/pagination - improved third party reports support - trending charts - better perf - many fixes - refactoring - new reports Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>	2018-07-19 14:33:11 -04:00
Régis Hanol	6d6e026e3c	FEATURE: selectable avatars	2018-07-18 12:57:43 +02:00
Sam	91266cdabb	correct auto bump topic logic	2018-07-17 09:33:33 +10:00
Sam	ac0053f491	FEATURE: navigate to first post and auto bump category settings ... ### navigate_to_first_post_after_read setting for categories When enabled on categories logged on users will return to OP after reading the entire category. (useful for documentation categories) ### num_auto_bump_daily Set a number of topics that will automatically bump daily on a category. - Every 15 minutes we will check if any category has this setting - Categories with the setting are shuffled - We exclude pinned, closed, category description and archived topics - Maximum of 1 topic for the list of categories is bumped till limit reached per category - We always try to bump oldest first - Limit is elastic using a RateLimiter that ensures that we only bump N per day Also some minor organisation on category settings Froze strings on category.rb	2018-07-16 18:10:35 +10:00
Guo Xiang Tan	4172e1dd52	FIX: Rename User#usernames that clashes with Group#name. (#6069)	2018-07-09 16:54:57 +08:00
Guo Xiang Tan	f7322c05ad	FIX: Avoid destroy_all in Jobs::CleanUpUploads. ... `destroy_all` loads all the relation into memory as once. See https://github.com/rails/rails/issues/22510	2018-07-02 12:44:36 +08:00
Arpit Jalan	7550e9ff95	FIX: purge unactivated users with a message from non-human users	2018-06-29 13:03:04 +05:30
Ernesto Serrano	c5e24da5dd	Update poll_mailbox.rb	2018-06-25 16:18:07 +10:00
Sam	cbaf521fc1	correct regression and add integrity spec for onceoffs	2018-06-20 09:09:31 +10:00
Sam	5f64fd0a21	DEV: remove exec_sql and replace with mini_sql ... Introduce new patterns for direct sql that are safe and fast. MiniSql is not prone to memory bloat that can happen with direct PG usage. It also has an extremely fast materializer and very a convenient API - DB.exec(sql, *params) => runs sql returns row count - DB.query(sql, *params) => runs sql returns usable objects (not a hash) - DB.query_hash(sql, *params) => runs sql returns an array of hashes - DB.query_single(sql, *params) => runs sql and returns a flat one dimensional array - DB.build(sql) => returns a sql builder See more at: https://github.com/discourse/mini_sql	2018-06-19 16:13:36 +10:00
Sam	12fd0b827e	PERF: release results in a couple of cases	2018-06-13 15:11:43 +10:00
Gerhard Schlager	2564a8285d	REFACTOR: Run some parts of user anonymizing in background job	2018-06-08 15:50:07 +02:00
Guo Xiang Tan	ad5082d969	Make rubocop happy again.	2018-06-07 13:28:18 +08:00
Guo Xiang Tan	d600e71b3d	FIX: Clean up stale UserExport records daily. ... * Add tests for `UserExport.remove_old_exports`	2018-06-05 09:43:40 +08:00
Régis Hanol	6024fb84cc	make rubocop happy	2018-06-04 19:06:52 +02:00
Régis Hanol	ab8cdd6b5b	Upload.url can't be NULL	2018-06-04 18:43:00 +02:00
Régis Hanol	085eaaf18d	FIX: always delete invalid upload records	2018-06-04 18:40:57 +02:00
Robin Ward	587a9c82f5	FIX: Use the username formatter when updating cooked usernames	2018-05-25 17:29:06 -04:00
Régis Hanol	71f66cd679	FIX: ensure PostAlerter is always run in sidekiq	2018-05-24 17:27:43 +02:00
Arpit Jalan	cafd1241b9	FIX: make report data export more resilient to inconsistent date format ... The DAU/MAU report export was failing because of date being a string and not a valid Date value	2018-05-24 17:14:08 +05:30
Guo Xiang Tan	43f7cb05c9	FIX: Broken ping event for web hooks due to missing payload.	2018-05-24 15:16:52 +08:00
Gerhard Schlager	95db5f0c8c	FIX: Do not replace wrong avatars when renaming user	2018-05-22 13:41:51 +02:00
Sam	24abf38d38	PERF: lower the priority on user emails ... User emails can wait behind other regular jobs, they are usually somewhat slower as they involve smtp transactions	2018-05-22 15:20:55 +10:00
Guo Xiang Tan	bf84037f79	FIX: Payload for webhooks should be current as of the time the event was triggered. ... https://meta.discourse.org/t/group-category-tag-user-deleted-webhooks-not-firing/87752	2018-05-21 17:29:58 +08:00
Arpit Jalan	1841dd48dc	FIX: revert utf-8 encode changes	2018-05-20 17:50:36 +05:30
Arpit Jalan	9512796ef6	FIX: check for blank response when polling feed	2018-05-18 17:00:44 +05:30
Guo Xiang Tan	1ff767559d	Fix incorrect param.	2018-05-18 14:05:45 +08:00
Guo Xiang Tan	c42b65df5f	find raises an error if the record is missing.	2018-05-18 13:37:07 +08:00
Arpit Jalan	238a13643d	FIX: handle missing users when sending push notifications	2018-05-17 12:53:19 +05:30
Régis Hanol	39aceed63d	FIX: don't purge unactivated users with a message	2018-05-16 18:24:11 +02:00
Arpit Jalan	146f634c8f	FIX: UTF-8 encode feed response body	2018-05-16 12:59:23 +05:30
Sam	21e0b7c818	avoid async report pattern and replace with simpler hijack	2018-05-16 16:05:03 +10:00
Gerhard Schlager	74c4af279a	Improvements to user renaming ... * don't update search index if post belongs to deleted topic * log errors instead of crashing when updating post or revision fails * update mentions even when the href attribute is missing * run the background job with low priority * replace username in all notifications * update `action_code_who` used by small action posts	2018-05-15 21:05:51 +02:00
Gerhard Schlager	2e1b5bc8d3	FIX: Transaction in UserAnonymizer prevented avatar from updating	2018-05-15 20:47:58 +02:00
Joffrey JAFFEUX	9947c38e1c	UX: support for multiple datasets in one chart	2018-05-15 20:12:03 +02:00
Sam	193b6d5651	UX: improve new dashboard ... - top referred topics - limit search logs to 8 results	2018-05-15 15:08:36 +10:00
Régis Hanol	a28c58feb1	FIX: automatic group membership when using SSO	2018-05-15 01:48:30 +02:00
Gerhard Schlager	c67c2dc638	FIX: Username update should ignore revisions without raw	2018-05-14 15:22:42 +02:00
Gerhard Schlager	8232aba743	FIX: Update search index after renaming user within posts	2018-05-14 13:20:30 +02:00
Gerhard Schlager	02cb84847c	FIX: Update avatar in oneboxed posts when renaming user	2018-05-14 13:20:29 +02:00
Sam	6332d5040d	UX: switch dashboard to be the new dashboard ... Also: - add pageviews - add problems and version sections	2018-05-14 13:07:59 +10:00
Sam	bc9e0d46af	PERF: use cached reports for dashboard if available	2018-05-14 12:01:44 +10:00
Sam	9d97e1244e	correct it so when we have no dates we still return graphs	2018-05-14 11:12:52 +10:00
Sam	67054d524d	correct missing day from async reports	2018-05-11 15:06:23 +10:00
Sam	8a783412b7	UX: improvements to new dashboard ... - remove inactive user report and replace with posts - clean up internals so grouping by week happens on client - when switching periods old report was not destroyed leading to bugs - calculate trend based on previous interval ... not previous 30 days - show percentages for mau/dau - be more careful about utc date usage - show uniqu and click through rate on search panel - publish key of report with report so we only load the correct one - subscribe earlier in channel in case of concurrency issues	2018-05-11 13:30:32 +10:00
Gerhard Schlager	2e67998319	Improvements for user renaming (#5810) ... * FEATURE: Update avatars in posts and revisions when user gets renamed * FIX: Replace username in deleted posts when user gets renamed * FEATURE: Replace username in notifications when user gets renamed FEATURE: Update mentions and quotes when user gets merged	2018-05-08 10:02:43 -04:00
Misaka 0x4e21	ff6be3c2e3	FEATURE: add profile_background fields into SSO (#5701) ... Add profile_background and card_background fields into Discourse SSO.	2018-05-07 10:03:26 +02:00
Jeff Wong	91b31860a1	Feature: Push notifications for Android (#5792) ... * Feature: Push notifications for Android Notification config for desktop and mobile are merged. Desktop notifications stay as they are for desktop views. If mobile mode, push notifications are enabled. Added push notification subscriptions in their own table, rather than through custom fields. Notification banner prompts appear for both mobile and desktop when enabled.	2018-05-04 15:31:48 -07:00
Joffrey JAFFEUX	980972182f	dashboard next: caching, mobile support and new charts	2018-05-03 15:41:41 +02:00
Gerhard Schlager	3be3c50c7e	FEATURE: Rename user in mentions and quotes ... Co-authored-by: Robin Ward <robin.ward@gmail.com>	2018-05-01 13:49:14 -04:00
Arpit Jalan	4f55fbfefa	FEATURE: include report title in PM subject and filename	2018-04-24 22:25:54 +05:30
Arpit Jalan	a1f0c58f23	FIX: export download link was broken	2018-04-20 01:12:41 +05:30
Arpit Jalan	91bf10bd12	FIX: create upload record for exported csv files	2018-04-20 00:27:49 +05:30
Joffrey JAFFEUX	0e414d0890	dashboard next: trending search report ... This commit also improves how data is loaded sync and async	2018-04-19 18:19:21 +02:00
Joffrey JAFFEUX	01c061d20d	dashboard next: perf and UI tweaks ... * cache CORE reports * adds backups/uploads section * few css tweaks	2018-04-18 21:30:41 +02:00
Guo Xiang Tan	7bf9650e96	Remove comment that is no longer accurate.	2018-04-18 14:22:18 +08:00
Arpit Jalan	a16b616861	FEATURE: webhook for flag events	2018-04-13 07:47:58 +05:30
Arpit Jalan	f5febe5843	FIX: date range was inconsistent for admin dashboard reports	2018-04-08 16:49:41 +05:30
Vinoth Kannan	434cbc649f	FEATURE: Webhook for tag events	2018-04-04 17:49:20 +05:30
Guo Xiang Tan	142571bba0	Remove use of rescue nil. ... * `rescue nil` is a really bad pattern to use in our code base. We should rescue errors that we expect the code to throw and not rescue everything because we're unsure of what errors the code would throw. This would reduce the amount of pain we face when debugging why something isn't working as expexted. I've been bitten countless of times by errors being swallowed as a result during debugging sessions.	2018-04-02 13:52:51 +08:00
Vinoth Kannan	efb19dbdaf	Merge pull request #5705 from discourse/new_webhooks ... FEATURE: Webhook for group and category events	2018-04-02 10:53:21 +05:30
Guo Xiang Tan	90f91bf017	Fix regression due to ee69d58a59.	2018-03-29 10:01:29 +08:00
Vinoth Kannan	dc33f2d071	Add new web hook serializers	2018-03-28 17:40:29 +05:30
Guo Xiang Tan	ee69d58a59	FIX: Tests could get stucked in infinite loop if it fails to resolve IP of a hostname.	2018-03-28 14:49:05 +08:00
Guo Xiang Tan	347e4eadbc	Don't retry trying to download a file in test.	2018-03-28 12:54:11 +08:00
Neil Lalonde	7311023a52	Merge pull request #5700 from discourse/crawl-block ... FEATURE: control web crawlers access with white/blacklist	2018-03-27 15:06:03 -04:00
Guo Xiang Tan	2f61780a49	Remove file that is no longer used.	2018-03-26 10:27:28 +08:00
Neil Lalonde	ced7e9a691	FEATURE: control which web crawlers can access using a whitelist or blacklist	2018-03-22 15:41:02 -04:00
Robin Ward	b9abd7dc9e	FEATURE: Shared Drafts ... This feature can be enabled by choosing a destination for the `shared drafts category` site setting. * Staff members can create shared drafts, choosing a destination category for the topic when it is published. * Shared Drafts can be viewed in their category, or above the topic list for the destination category where it will end up. * When the shared draft is ready, it can be published to the appropriate category by clicking a button on the topic view. * When published, Drafts change their timestamps to the current time, and any edits to the original post are removed.	2018-03-20 17:15:26 -04:00
Guo Xiang Tan	486bbe9cc2	FIX: Auto re-opened topics should restore category auto close settings. ... https://meta.discourse.org/t/topic-closed-temporarily-due-to-community-flags-overwrites-category-auto-close-timer/77421	2018-02-27 15:33:31 +08:00
Sam	86d12bd44b	FEATURE: search within title using in:title ... Also - Significantly improved search ranking, title is treated most strongly - Adds tag names to the index - Run search re-indexer more aggressively - Re-index topic and all posts on category change	2018-02-20 14:41:21 +11:00
Arpit Jalan	33df2d6a02	FIX: data export should fill missing dates with zero value	2018-02-18 23:52:09 +05:30
Neil Lalonde	991dfadad7	FIX: CategoryTagStat queries need to exclude PMs with tags	2018-02-15 12:13:42 -05:00
Neil Lalonde	fdd8ce9722	empty category_tag_stats table before running init job	2018-02-15 11:28:25 -05:00
Sam	d8b4627fc8	we have to define this for tests to pass	2018-02-15 13:30:34 +11:00
Sam	b5b866aab3	oops	2018-02-15 13:13:31 +11:00
Sam	c89b42c488	PERF: only require the rss library if used ... Before: Total allocated: 257909321 bytes (2514134 objects) Total retained: 39681579 bytes (343387 objects) allocated memory by gem ----------------------------------- 42875979 rss retained memory by gem ----------------------------------- 2080188 rss retained objects by gem ----------------------------------- 13052 rss After: Total allocated: 210562047 bytes (2252030 objects) Total retained: 37433816 bytes (328635 objects) ---- So, 2 less megabytes on boot and 13000 objects stuck in ruby heaps forever.	2018-02-15 13:11:33 +11:00
Régis Hanol	7d501058d7	FIX: don't grant new user of the month badge to suspended users or based on deleted topics/posts	2018-02-13 17:32:38 +01:00
Neil Lalonde	76c309fe6b	PERF: a faster way to count tags used per category	2018-02-12 15:16:47 -05:00
Vinoth Kannan	e700e3e882	FIX: post_destroyed webhook event not fired	2018-02-13 01:36:56 +05:30
Neil Lalonde	d7e90edeb5	PERF: Tl3Promotions job can limit the number of TL3 candidates by using some simple requirements in the query	2018-02-05 17:54:36 -05:00
Neil Lalonde	8fe61c68a1	FIX: process_post job should update baked_at and baked_version if it rebakes the post	2018-02-05 11:47:04 -05:00
Régis Hanol	130974d58d	FIX: automatically unsilence users	2018-02-05 17:45:47 +01:00
Régis Hanol	d233ecbe34	push updates to backups list to client	2018-01-31 12:05:06 +01:00
Régis Hanol	77ac14d475	prevent users with a tiny number of posts to dominate the 'new user of the month' leaderboard	2018-01-29 12:09:17 +01:00
Sam	47058b29d3	FEATURE: emit external_id field with user webhook	2018-01-22 10:09:26 +11:00
Neil Lalonde	2493648f9c	PERF: calculate topic_counts for tags in an async job so tag queries that include counts are much faster	2018-01-12 11:03:03 -05:00
Jan Suchal	bc56d86a63	Support ruby 2.5.0	2018-01-09 16:03:17 +01:00
Robin Ward	69a90f31fb	FEATURE: Allow Forums to disable the Backups feature	2017-12-21 15:22:04 -05:00
Gerhard Schlager	7b58afe677	FIX: ProcessPost job failed for posts that have no user	2017-12-21 14:45:59 +01:00
Sam	88a4ec5f1b	FIX: stop forking regular backup jobs	2017-12-21 09:00:48 +11:00
Neil Lalonde	f5a3be750c	PERF: add option to limit how many categories are processed in one call to CategoryFeaturedTopic.feature_topics (#5446)	2017-12-20 13:42:29 +11:00
Guo Xiang Tan	97ceebb570	SECURITY: Don't pass email backup token to sidekiq as a parameter. ... * This exposes the token in the Sidekiq dashboard which can be viewed by an admin and defeats the purpose of using a token in the download backup email ink.	2017-12-18 11:25:22 +08:00
Guo Xiang Tan	5489cd14c7	Skip validations when fixing Topic#featured_link in onceoff job.	2017-12-15 23:45:07 +08:00
scossar	11050e5d10	Don't override count value that has been set by query.count	2017-12-13 18:48:46 -08:00
Sam	b998efdc94	FIX: do not send mailing list emails to unapproved users	2017-12-13 15:13:17 +11:00
Guo Xiang Tan	4bd5acec47	FIX: Topic#featured_link may contain more than a URL.	2017-12-11 16:36:19 +08:00
Arpit Jalan	3c56c9b637	FIX: strip webhook payload_url	2017-12-11 13:48:11 +05:30
Kyle Zhao	5f318a5241	FEATURE: Replace SimpleRSS with Ruby RSS module (#5311) ... * SPEC: PollFeedJob parsing atom feed * add FeedItemAccessor It is to provide a consistent interface to access a feed item's tag content. * add FeedElementInstaller to install non-standard and non-namespaced feed elements * FEATURE: replace SimpleRSS with Ruby RSS module * get FinalDestination and download with Excon * support namespaced element with FeedElementInstaller	2017-12-06 10:45:09 +11:00
Neil Lalonde	b35960fc35	FIX: export admin reports to csv would have 0 rows in the csv file	2017-12-01 15:50:36 -05:00
Guo Xiang Tan	c128e421c4	FIX: Don't run job if topic timer has already been deleted.	2017-11-30 15:26:26 +08:00
Robin Ward	77f90876d3	REFACTOR: Track manual locked user levels separately from groups	2017-11-27 11:23:44 -05:00
Régis Hanol	4addc5e329	Add missing contexts when destroying users	2017-11-22 15:43:54 +01:00
Régis Hanol	c4d0eb802e	FIX: delete upload records when sha is null	2017-11-21 10:20:42 +01:00
Régis Hanol	2d48caffdf	FIX: be more lenient when deleting a custom emoji	2017-11-20 23:50:23 +01:00
Neil Lalonde	dcd60dcc8f	FIX: cap posts_read_count in user_stats to 50 posts per topic_entered	2017-11-20 17:15:05 -05:00
Neil Lalonde	b37e40eea9	FEATURE: show read time in last 60 days	2017-11-16 15:46:51 -05:00
Régis Hanol	678e28794a	FIX: properly handle too large & broken images in posts	2017-11-16 15:45:07 +01:00
Sam	9c22c68d39	FIX: only save custom fields if they actually change	2017-11-16 15:14:10 +11:00
Vinoth Kannan	7b494a65c9	NEW: large image placeholder added in cooked html (#5291)	2017-11-15 11:30:47 +01:00
Robin Ward	971e302ff2	FEATURE: Support an end date for user silencing	2017-11-14 13:20:19 -05:00
Régis Hanol	ba2209f7d7	FIX: always clean up uploads with no sha1	2017-11-14 10:56:10 +01:00
Régis Hanol	7370adeae3	FIX: don't delete uploads referenced in drafts or queued posts when using the short_url	2017-11-13 15:01:31 +01:00
Robin Ward	1f14350220	Rename "Blocked" to "Silenced"	2017-11-10 14:10:27 -05:00
Guo Xiang Tan	6def5a344a	Let's be more aggressive with purging old WebHookEvent records.	2017-11-08 14:15:34 +08:00
Guo Xiang Tan	6090994cdf	FEATURE: Retain the latest 30 days of WebHookEvent records by default.	2017-11-08 14:11:01 +08:00
Sam	7c5a71e929	DEV: allow queue_jobs = false in dev ... your mileage may vary	2017-10-31 13:50:58 +11:00
Guo Xiang Tan	0abc5f90cd	FIX: Broken link in new user of the month post.	2017-10-30 13:11:29 +08:00
Neil Lalonde	2c15e9c6fe	FIX: search couldn't find tags from before 2017-08-25	2017-10-24 17:55:05 -04:00
Guo Xiang Tan	d5e369d6cf	Fix weird Rubocop error.	2017-10-23 12:30:28 +08:00
Régis Hanol	c838f43a75	let's not generate an error when logging errors...	2017-10-18 23:14:13 +02:00
Neil Lalonde	c53f41f4f2	FIX: don't flag watched words when rebaking posts	2017-10-12 15:34:22 -04:00
Arpit Jalan	97395ebb66	FIX: SSO avatar downloads were broken ... cc @tgxworld	2017-10-12 12:12:04 +05:30
Régis Hanol	f7282e4ecd	use force_https site setting when adding scheme for downloading schemaless images locally	2017-10-12 00:06:24 +02:00
Régis Hanol	4e78abb537	let's try 3 times to download images locally	2017-10-11 23:11:44 +02:00
Guo Xiang Tan	9dcb11f553	Fix the build.	2017-10-11 17:45:19 +08:00
Guo Xiang Tan	09721090a3	FIX: Ensure that we revert back to default connection after running jobs.	2017-10-11 17:17:03 +08:00
Guo Xiang Tan	59aeb0bc56	FIX: Sidekiq hot reloading wasn't working in dev. ... https://meta.discourse.org/t/webhooks-sidekiq-issue-on-dev-instance/71129 * Remove code that is no longer required as well.	2017-10-09 18:23:25 +08:00
Sam	4ea87b5ab8	Merge branch 's3_refactor'	2017-10-09 10:27:52 +11:00
Sam	70bb2aa426	FEATURE: allow specifying s3 config via globals ... This refactors handling of s3 so it can be specified via GlobalSetting This means that in a multisite environment you can configure s3 uploads without actual sites knowing credentials in s3 It is a critical setting for situations where assets are mirrored to s3.	2017-10-06 16:20:01 +11:00
Guo Xiang Tan	4ba5e678d8	Require dependencies to enable live reload in dev for Sidekiq.	2017-10-06 11:39:00 +08:00
Régis Hanol	e212435545	FIX: redirect to top wasn't working	2017-10-04 22:08:41 +02:00
Kyle Zhao	ac666ddf17	PollFeed: check 'content:encoded' for content first	2017-10-02 01:16:11 -04:00
Guo Xiang Tan	0f2c5f5fc9	FIX: Don't raise error when trying to download avatar from URL.	2017-10-02 12:59:41 +08:00
Guo Xiang Tan	974836962d	Fix invalid method call.	2017-10-02 12:50:22 +08:00
Guo Xiang Tan	77ea063751	FIX: Missing attribute.	2017-10-02 10:24:37 +08:00
Guo Xiang Tan	4eeb6014f4	Don't raise an error if user has been destroyed.	2017-09-30 09:09:40 +08:00
Guo Xiang Tan	d79fee9ff3	Fix undefined method for Nil class error.	2017-09-28 17:38:53 +08:00
Sam	8ecf313a81	FIX: correctly raise errors when downloads fail ... This corrects an issue where we are hitting Gravatar for 404 over and over Also ensures file download properly reports errors	2017-09-28 16:35:43 +10:00
Régis Hanol	3a75242c38	add more logs to pull hotlinked images	2017-09-28 01:00:13 +02:00
Régis Hanol	dd07094bd7	bump log level to debug download issues	2017-09-27 23:26:07 +02:00
Robin Ward	fa41913ba5	FIX: Don't count private content in New User of the Month	2017-09-27 15:03:24 -04:00
Robin Ward	d1ebc62065	The ability to display errors on flagging actions.	2017-09-25 12:28:01 -04:00
Robin Ward	677b016387	Send a suspension message via email to a user	2017-09-25 12:26:41 -04:00
Guo Xiang Tan	23b787e0a6	Require dependency otherwise it causes Sidekiq to lock up in development.	2017-09-25 13:48:59 +08:00
Neil Lalonde	16fe7aa307	FEATURE: automatically handle flags and posts that have been waiting in a queue for a long time. Flags will be deferred. Posts waiting for approval will be rejected. Control how old the records need to be with the auto_handle_queued_age site setting.	2017-09-14 12:01:06 -04:00
Régis Hanol	d9465bac13	add 'staged' column to user export	2017-09-13 18:09:11 +02:00
Vinoth Kannan	6e9671c2c3	UX: Placeholder images color changed & tootip added	2017-09-13 15:16:38 +05:30
Neil Lalonde	beea5cac48	FIX: send the queued posts reminder as a message to moderators instead of an email to the contact_email	2017-09-12 18:00:51 -04:00
Neil Lalonde	6831efe2e9	FIX: no notification was being sent when a post is hidden by community flags	2017-09-12 15:43:44 -04:00
Vinoth Kannan	0fb7831749	FEATURE: Add placeholders to broken and large image files (#5113)	2017-09-01 10:26:13 -04:00
Neil Lalonde	2c56f8df7c	FEATURE: show tags in search results	2017-08-25 11:52:59 -04:00
Leo McArdle	3986367f3f	update pr based on review	2017-08-23 14:55:34 +01:00
Leo McArdle	be1df3ba75	FIX: transfer posts by duplicated staged users to original	2017-08-22 09:58:51 +01:00
Sam Saffron	56f7b4e01e	PERF: reindex search data without loading large post counts	2017-08-16 08:18:59 -04:00
Erick Guan	6e59149a77	FIX: rebuild index when engine replaced (#5021)	2017-08-16 07:38:34 -04:00
Guo Xiang Tan	b77aa29e71	Merge pull request #5013 from LeoMcA/alternate-emails-phase-1.5 ... FIX: add additional email to tests and clean up resulting mess	2017-08-16 16:19:28 +09:00
Guo Xiang Tan	793eccf6c5	FIX: Staged users were incorrectly created multiple times with same email.	2017-08-10 18:56:15 +09:00
Guo Xiang Tan	a849959915	Fix missing parameter.	2017-08-10 11:15:51 +09:00
Guo Xiang Tan	b404a4b97c	Merge pull request #5034 from tgxworld/fix_staged_primary_email ... FIX: Staged users are still missing primary email.	2017-08-10 10:30:51 +09:00
Arpit Jalan	e993d53260	FIX: handle missing parent category when exporting user archive ... https://meta.discourse.org/t/download-my-posts-failed/67613?u=techapj	2017-08-09 14:37:21 +05:30
Guo Xiang Tan	0bc690ed11	FIX: Staged users are still missing primary email.	2017-08-09 12:03:49 +09:00
Leo McArdle	836dee1120	FIX: add additional email to tests and clean up resulting mess	2017-07-31 22:27:29 +00:00
Neil Lalonde	5d528f0d15	Merge pull request #4958 from dmacjam/search_posts_by_filetype ... FEATURE: Search posts by filetype	2017-07-31 11:55:34 -04:00
Guo Xiang Tan	5012d46cbd	Add rubocop to our build. (#5004)	2017-07-28 10:20:09 +09:00
Neil Lalonde	24cb950432	FEATURE: Watched Words: when posts contain words, do one of flag, require approval, censor, or block	2017-07-26 11:01:09 -04:00
Neil Lalonde	d8c27e3871	Merge branch 'master' into search_posts_by_filetype	2017-07-25 14:41:20 -04:00
Robin Ward	2f8f2aa1dd	FEATURE: Whitelists for inline oneboxing	2017-07-21 15:41:47 -04:00
Leo McArdle	ddc0134b48	add DiscourseEvent triggers necessary to update a user's permissions before they're notified	2017-07-21 11:03:54 -04:00
Leo McArdle	d0b027d88d	FEATURE: phase 1 of supporting multiple email addresses	2017-07-20 11:22:27 +09:00
Robin Ward	6b6ad9391b	Clean up job for search logs	2017-07-14 14:30:58 -04:00
Jakub Macina	677267ae78	Add onceoff job for uploads migration of column extension. Simplify filetype search and related rspec tests.	2017-07-12 17:19:27 +02:00
Régis Hanol	a6dff79c2c	change log level to info when failing to download a hotlinked image	2017-07-12 11:06:28 +02:00
Guo Xiang Tan	e92acb4c40	FIX: Jobs::PullHotlinkedImages#is_valid_image_src returns true for a generic string.	2017-07-06 18:31:15 +09:00
Guo Xiang Tan	061aa261da	Log site name when logging to Logster in Jobs::PullHotlinkedImages.	2017-07-05 10:34:24 +09:00
Guo Xiang Tan	4e8b80c157	Remove unnecessary ensure block.	2017-07-05 10:21:42 +09:00
Robin Ward	0ba39109a0	FIX: Make omit_default_port the global default	2017-06-30 12:43:26 -04:00
Robin Ward	46a3b30021	FIX: omit the default port in the Host header	2017-06-30 12:36:02 -04:00
Sam	5c89a37ceb	FIX: log when push notifications fail	2017-06-30 10:45:53 -04:00
Arpit Jalan	16d356ab4e	FEATURE: resending invite should include original custom message ... https://meta.discourse.org/t/will-resent-invite-include-original-custom-message/64699	2017-06-30 18:13:33 +05:30
Sam	c1580b9d36	attempt to fix push notifications	2017-06-30 08:40:43 -04:00
Guo Xiang Tan	1ab60d83df	PERF: Terminate scheduled job earlier if badge is not enabled.	2017-06-26 10:13:58 +09:00
Guo Xiang Tan	6cc174ca82	PERF: Fetch users in batches in grant anniversary badge job.	2017-06-23 16:54:35 +09:00
Régis Hanol	2e7753c27f	User 'FileHelper.is_image?' to check wether a link is poiting to an image	2017-06-22 12:54:42 +02:00
Guo Xiang Tan	80e348d226	PERF: Speed up slow tests in our test suite. ... Before ``` Finished in 7 minutes 23 seconds (files took 4.15 seconds to load) 7145 examples, 0 failures, 10 pending ``` After ``` Finished in 6 minutes 12 seconds (files took 4.41 seconds to load) 7145 examples, 0 failures, 10 pending ```	2017-06-22 11:23:31 +09:00
Guo Xiang Tan	d82dbd565b	FIX: Remove dependency on rest-client.	2017-06-16 09:42:41 +09:00
Régis Hanol	d6c63cc5b2	FIX: user's default group should only be set once ... Setting a user's default groups based on their email address should only be done once, ie. when they confirm their email address. Previously we were doing this everytime we'd save a user record 🤷	2017-06-14 19:20:18 +02:00
Régis Hanol	5d63a7f4a6	FIX: pull hotlinked images even when they have no extension	2017-06-13 13:27:05 +02:00
Guo Xiang Tan	e888369f51	UX: Don't send emails for discobot notifications.	2017-06-12 17:00:27 +09:00
Robin Ward	d92c938491	FIX: Don't raise an error cleaning up uploads if a path is nil	2017-06-08 14:31:58 -04:00
Régis Hanol	e8f0771dc9	FIX: the 'clean_up_uploads' jobs would delete images used in site settings ... when they were entered using absolute URLs, with the CDN or simple a different format than the one used in the database	2017-06-07 22:53:15 +02:00
Vinoth Kannan	209383faab	FEATURE: pull onebox images	2017-06-06 18:51:58 +05:30
Sam	0aed2533ac	Revert unread optimisation, has too many edge cases	2017-05-26 09:04:13 -04:00
Sam	29fac1ac18	PERF: improve performance of unread queries ... Figuring out what unread topics a user has is a very expensive operation over time. Users can easily accumulate 10s of thousands of tracking state rows (1 for every topic they ever visit) When figuring out what a user has that is unread we need to join the tracking state records to the topic table. This can very quickly lead to cases where you need to scan through the entire topic table. This commit optimises it so we always keep track of the "first" date a user has unread topics. Then we can easily filter out all earlier topics from the join. We use pg functions, instead of nested queries here to assist the planner.	2017-05-25 15:07:30 -04:00
Robin Ward	cdbe027c1c	Refactor FileHelper to use keyword arguments.	2017-05-24 13:54:26 -04:00
Robin Ward	b78b010757	FIX: Fixes to grant new user of the month badge	2017-05-24 11:36:24 -04:00
Neil Lalonde	9edc490d3f	FIX: remove memoized values in jobs	2017-05-22 16:26:30 -04:00
Robin Ward	b23fc2bf84	Helper to find the final destination for a URL	2017-05-22 15:52:41 -04:00
Neil Lalonde	f350dd4fd1	FIX: possible data leaking from one site to another in multisite in PendingFlagsReminder	2017-05-22 15:18:13 -04:00
Robin Ward	773445b8df	FIX: Topic Crawling should only crawl HTTP/S urls	2017-05-22 11:57:20 -04:00
Guo Xiang Tan	4382a0bb07	Rename PostTimestampChanger -> TopicTimestampChanger.	2017-05-22 15:01:33 +08:00
Robin Ward	ea9f93dcc5	FIX: Don't crawl non-http/s links	2017-05-19 16:57:41 -04:00
Neil Lalonde	7821400141	FEATURE: staff can set a timer to remind them about a topic	2017-05-16 14:49:50 -04:00
Robin Ward	bd0bb879e5	FIX: Don't count likes from system users in the new user of the month	2017-05-15 13:14:32 -04:00
Guo Xiang Tan	8eecd42856	FIX: Delete topic timer after completion.	2017-05-12 10:28:51 +08:00
Neil Lalonde	55b61e9bea	rename topic_status_update to topic_timer	2017-05-11 18:27:53 -04:00
Neil Lalonde	1019bbda46	FEATURE: set a timer to delete a topic	2017-05-11 12:52:29 -04:00
Robin Ward	3ade46de0b	FIX: Don't send system message for new user of the month if disabled	2017-05-11 11:33:16 -04:00
Régis Hanol	4b7be137cb	don't generate errors if 'upload_id' is invalid	2017-05-11 09:07:04 +02:00
Régis Hanol	9641d2413d	REFACTOR: upload workflow creation into UploadCreator ... - Automatically convert large-ish PNG/BMP to JPEG - Updated fast_image to latest version	2017-05-11 00:16:57 +02:00
Sam	f709899a1d	Allow theme field object model to support uploads	2017-05-10 15:46:42 -04:00
Robin Ward	4db76796b9	FEATURE: Setting to poll feeds more frequently	2017-05-10 14:30:12 -04:00
Robin Ward	6e4ba8a33e	Catch RSS Parsing errors	2017-05-09 15:07:06 -04:00
Robin Ward	c2bf525a06	Make CloseTopic a no-op just in case	2017-05-09 15:02:05 -04:00
Robin Ward	ba1868b051	FIX: There are still jobs enqueued for CloseTopic	2017-05-09 14:58:37 -04:00
Arpit Jalan	e6e0025326	FIX: handle BOM in bulk import CSV file	2017-05-09 22:38:07 +05:30
Arpit Jalan	94683b33b8	FIX: sanitize bulk invite error log	2017-05-09 17:41:59 +05:30
Robin Ward	4f6e5fed2a	We don't need to raise an error when no post is present. Just noop.	2017-05-08 15:08:29 -04:00
Guo Xiang Tan	71a266b673	Remove daily mailing mode option as it doesn't scale. ... https://meta.discourse.org/t/daily-updates-option-for-mailing-list-mode/45029/14?u=tgxworld	2017-05-05 12:21:50 +08:00
Guo Xiang Tan	50c8ae2c10	Load user records in batches.	2017-05-05 10:57:31 +08:00
Arpit Jalan	86f1cc8c92	FIX: don't apply max_emails_per_day_per_user on critical emails	2017-05-03 17:07:39 +05:30
Arpit Jalan	cdce060a38	FIX: don't apply max emails per day per user to forgot password	2017-05-03 14:02:37 +05:30
Neil Lalonde	ca224ed8e9	FIX: pending flags message should go to moderators group, not staff	2017-05-01 14:53:16 -04:00
Robin Ward	dfe1174137	FIX: The dates for retroactive anniversary badges were wrong	2017-05-01 12:06:18 -04:00
Robin Ward	f05f1a24d3	Change Anniversary badge to be multiple grant, once per year	2017-04-28 14:22:54 -04:00
Guo Xiang Tan	85d9342ff0	Merge pull request #4836 from tgxworld/fix_clean_up_staged_users_job ... FIX: Clean up unused staged users job not completing.	2017-04-27 15:41:46 +08:00
Robin Ward	bf9c4a7828	FEATURE: secure_email site setting to prevent data going out in email	2017-04-26 13:05:56 -04:00
Guo Xiang Tan	fe0a7d97ca	Fix incorrect class name.	2017-04-26 18:12:51 +08:00
Guo Xiang Tan	b00886f5c1	Remove sidekiq-statistic gem. ... * We don't really use it and there is an on-going issue with the gem not expiring keys in a Redis list which hasn't been fully resolved. https://github.com/davydovanton/sidekiq-statistic/issues/73	2017-04-26 14:54:47 +08:00
Guo Xiang Tan	daa97c40ce	FIX: Clean up unused staged users job not completing.	2017-04-26 10:51:36 +08:00
Guo Xiang Tan	423f2ab228	FIX: Processing incoming email should be done in a background job.	2017-04-24 13:57:28 +08:00
Neil Lalonde	05efa7ce68	simplify last_notified_id	2017-04-20 15:26:28 -04:00
Neil Lalonde	3835e16cf7	FIX: New implementation of the "notify about flag after" setting. Only notify about new flags since the last notification. Send a private message to staff. Mention the 3 most active moderators in the message so they get notification emails.	2017-04-19 16:17:45 -04:00
Guo Xiang Tan	73180c8a19	FIX: Private message can be set to publish in the future.	2017-04-11 20:44:25 +08:00
Guo Xiang Tan	aadf4805a5	FIX: Topic status update not being deleted once it has been executed.	2017-04-11 10:32:13 +08:00
Régis Hanol	db77640634	FIX: grant first reply by email job was *brokenated*	2017-04-10 22:11:29 +02:00
Guo Xiang Tan	690d2f4bd3	UX: Publish topic changes when topic is published.	2017-04-07 15:32:00 +08:00
Guo Xiang Tan	48a9860f07	FIX: Publish topic to a category should unlist it as well.	2017-04-07 13:58:52 +08:00
Guo Xiang Tan	8e794070d2	Fix incorrect method name.	2017-04-06 13:45:59 +08:00
Guo Xiang Tan	e0e06c2992	Merge pull request #4794 from tgxworld/nuke_old_auto_close_jobs ... FIX: Add onceoff job to remove old auto close topic sidekiq jobs.	2017-04-06 12:29:42 +08:00
Guo Xiang Tan	5943543ec3	FIX: Improve checks for non-human users.	2017-04-06 11:29:34 +08:00
Guo Xiang Tan	e8eaffbd72	FIX: Add onceoff job to remove old auto close topic sidekiq jobs.	2017-04-06 10:52:13 +08:00
Robin Ward	17f2974d0a	SECURITY: Confirm new administrator accounts via email	2017-04-04 15:59:01 -04:00
Guo Xiang Tan	69661be500	FIX: Don't raise an error if TopicStatusUpdate has been deleted.	2017-04-04 14:29:47 +08:00
Guo Xiang Tan	ad44d2a400	Merge pull request #4790 from tgxworld/add_publish_to_topic_status_update ... FEATURE: Allow admins to schedule a topic to be published in the future.	2017-04-04 11:18:53 +08:00
Guo Xiang Tan	f4758a4c4d	FEATURE: Allow admins to schedule a topic to be published in the future.	2017-04-04 11:16:05 +08:00
Robin Ward	ebe232da47	Weigh staff votes more for New User of the Month badges	2017-04-03 16:52:31 -04:00
Robin Ward	a13a8dc96c	FIX: Safeguard to not award NewUserOfTheMonth if it hasn't been a month	2017-04-03 13:26:51 -04:00
Robin Ward	3d64f33d40	Require at least two likes to get the "New User of the Month" badge	2017-04-03 13:03:28 -04:00
Jeff Atwood	3b64aeaf21	loosen new user of the month criteria slightly	2017-03-31 16:33:50 -07:00
Robin Ward	e4b1376146	Change New User of the Month Badge to use trust level rather than age	2017-03-31 16:56:58 -04:00
Robin Ward	a8d3779f0b	Update New User of the Month badge to require 4 posts in 2 topics	2017-03-31 16:52:00 -04:00
Robin Ward	fc7fa4c0ad	Rename "Rookie of the Month" to "New User of the Month"	2017-03-31 16:30:30 -04:00
Robin Ward	e6f6bd34d8	Send the user a notice when they've received rookie of the month	2017-03-31 15:06:31 -04:00
Robin Ward	893e93dfbe	New badge, Rookie of the Month, for two new high quality users.	2017-03-31 15:06:31 -04:00
Guo Xiang Tan	34b7bee568	FEATURE: Allow admin to auto reopen at topic. ... * This commit also introduces a `TopicStatusUpdate` model to support other forms of deferred topic status update in the future.	2017-03-31 11:14:18 +08:00
Arpit Jalan	df246c79b6	FEATURE: add user profile fields in user list export	2017-03-21 15:51:52 +05:30
Guo Xiang Tan	566f367fc3	FIX: Don't migrate custom emojis that are no longer valid. ... * Warn about failed migration in logs.	2017-03-17 08:28:24 +08:00
Robin Ward	1957d12670	SECURITY: Don't use backticks for exporting your archive	2017-03-16 16:24:59 -04:00
Guo Xiang Tan	0a87547cbc	Fix broken tests.	2017-03-16 10:22:15 +08:00
Erick Guan	cfbfea0596	FEATURE: Allow easier customization to the web hook event serialization.	2017-03-16 10:09:05 +08:00
Guo Xiang Tan	1a7e954e09	FIX: Store custom emojis as uploads. ... * Depending on a hardcoded directory was a flawed design which made it impossible to debug when custom emojis go missing.	2017-03-14 13:07:18 +08:00
Régis Hanol	23b06d2895	FIX: should not try to send digest to users who reached the bounce threshold	2017-03-08 19:19:11 +01:00
Régis Hanol	cf8bc4483f	FIX: always send critical emails even when bounce score threshold has been reached	2017-03-08 10:06:16 +01:00
Arpit Jalan	d5bcc70e9c	FIX: grant trust level when bulk adding users to group	2017-03-06 14:39:53 +05:30
Blake Erickson	80858bae2c	FEATURE: further restrict downloading of backups ... - send email to logged in admin when they press the "download" button - show pop-up that email was sent - create email template - require a valid token to download backup	2017-03-01 08:28:34 -07:00
Blake Erickson	0a41da6bad	FEATURE: Add order logic to admin users controller ... Added order and direction parameters for sorting admin user pages. This commit only includes backend api changes. https://meta.discourse.org/t/make-admin-users-list-sortable-suggestion/47649 Now you can pass in `order` and `asc` parameters to the `/admin/users/list/<query>.json` endpoint. Example: `/admin/users/list/active.json?&order=post_count` which defaults to desc and `/admin/users/list/active.json?order=post_count&asc=true`	2017-02-24 17:11:17 -07:00
Régis Hanol	f07b4b310a	should not have renamed this setting in 460665895c	2017-02-08 18:11:34 +01:00
Sam	ff49f72ad9	FEATURE: per client user tokens ... Revamped system for managing authentication tokens. - Every user has 1 token per client (web browser) - Tokens are rotated every 10 minutes New system migrates the old tokens to "legacy" tokens, so users still remain logged on. Also introduces weekly job to expire old auth tokens.	2017-02-07 09:22:16 -05:00
Arpit Jalan	19f7beaa2c	FIX: topic links were getting dropped when post is rebaked	2017-01-30 14:55:53 +05:30
Robin Ward	496682c442	Merge pull request #4662 from tgxworld/fix_localized_group_name_change ... Fix localized group name change	2017-01-26 10:50:00 -05:00
Guo Xiang Tan	706b4f6b9f	FEATURE: Remap group mentions when group name has been changed.	2017-01-18 13:39:34 +08:00
Leo McArdle	b60e9b7330	FIX: Handle img src starting with "//" in pull_hotlinked_images job	2017-01-16 10:50:07 +00:00
Arpit Jalan	7a1ff59822	FIX: PM email to suspended member was broken	2017-01-05 13:58:14 +05:30
Guo Xiang Tan	076a08d8e1	FIX: Unactivated users should not be automatically added into groups as well.	2016-12-21 18:15:01 +08:00
Guo Xiang Tan	7228081820	FIX: Automatic group membership should not add staged or unactivated users.	2016-12-21 18:04:26 +08:00
Neil Lalonde	923cf73c6e	Topic Featured Links: move data from custom fields to topics and categories tables. Invert behaviour of topic_featured_link_allowed checkbox. Fix a bug with invalid topic records due to changing that category checkbox.	2016-12-19 14:54:07 -05:00
Sam	f867af6bf9	bye bye byebug	2016-12-15 15:52:25 +11:00
Guo Xiang Tan	3666575b46	UX: Improve styling for groups page.	2016-12-15 12:19:13 +08:00
Régis Hanol	664feca199	FIX: don't send emails from muted users in mailing list mode	2016-12-12 15:28:26 +01:00
Guo Xiang Tan	9a800107cb	FIX: Associate category logo and background to uploads record.	2016-12-12 17:37:28 +08:00
Guo Xiang Tan	05f55dbc10	FEATURE: Group logs.	2016-12-12 17:29:54 +08:00
Robin Ward	424fc8e2e2	FIX: Don't raise an error if the RSS endpoint is 404	2016-12-05 12:29:14 -05:00
Arpit Jalan	ce974da9e5	FIX: simplify CSV file upload	2016-12-05 14:09:08 +05:30
Guo Xiang Tan	55b35a05ed	FIX: This should not have been checked in.	2016-12-05 11:49:04 +08:00
Guo Xiang Tan	22059d4df9	Add Rake task to clean up unused multisite Redis keys.	2016-12-05 11:46:34 +08:00
Régis Hanol	0dfac2dd24	Merge pull request #4545 from hiveeyes/pop3_polling_openssl_verify ... Add “pop3_polling_openssl_verify” setting to turn off TLS server certificate verification	2016-11-15 19:33:44 +01:00
Andreas Motl	43fd3ebd4a	Add “pop3_polling_openssl_verify” setting to turn off TLS server certificate verification like “smtp_openssl_verify_mode”. Defaults to “true”, so it does not change current behavior.	2016-11-11 21:59:15 +01:00
Sam	ac2c035856	FIX: stop raising exceptions when a post goes missing	2016-11-08 14:51:56 +11:00
Erick Guan	dd58c00699	FEATURE: Add instance id in the webhook payload	2016-11-04 15:21:41 +01:00
Guo Xiang Tan	f03d9cad06	PERF: NOT IN query is really inefficient for large tables.	2016-11-02 13:09:18 +08:00
Arpit Jalan	478418e780	FIX: notify_old_email template did not had new_email	2016-10-25 23:50:55 +05:30
Régis Hanol	52b338db62	FIX: category logo & background URLs should not use the CDN	2016-10-25 10:43:57 +02:00
Régis Hanol	923db2e559	FIX: download avatar from facebook/twitter in a job in order to prevent hangs when avatars are huge	2016-10-24 17:15:13 +02:00
Kiril Staikov	aee943486a	FEATURE:'No Echo' option for mailing list mode. ... Mailing list mode now includes the 'no echo' option: to only receive emails of posts not created by you. If you reply to an email thread in mailing list mode, your reply will not then be echoed back to you in a duplicate email by the system.	2016-10-19 13:14:36 -04:00
Arpit Jalan	e5a13b0ac1	FIX: specify CSV file encoding and better error reporting	2016-10-18 00:31:35 +05:30
Robin Ward	af83c8dc14	Upload Logos Step	2016-09-22 09:52:19 -04:00
Erick Guan	707fcb9434	FIX: Content-Lenght should be the size in octets	2016-09-21 10:31:20 +08:00
Erick Guan	00d5facf36	FEATURE: prompts new webhook events	2016-09-19 12:07:17 +08:00
Guo Xiang Tan	451050c6c4	Merge pull request #4437 from fantasticfears/webhooks-event-name ... FIX: show event name in webhook headers	2016-09-16 14:27:12 +08:00
Guo Xiang Tan	baacb30ba1	FIX: Incorrect folder.	2016-09-15 15:20:07 +08:00
Erick Guan	7423140825	FIX: show event name in webhook headers	2016-09-12 17:48:54 +08:00
Guo Xiang Tan	0fbb949af5	Merge pull request #4432 from tgxworld/migrate_upload_scheme_to_scheduled_job ... FIX: Make `Jobs::MigrateUploadScheme` a scheduled job.	2016-09-06 08:39:27 +08:00
Erick Guan	9ce61b4586	FEATURE: Webhooks.	2016-09-05 18:44:00 +08:00
Sam	340874d345	FIX: post notifications in JSON so we properly support arrays and so on	2016-09-04 15:51:16 +10:00
Guo Xiang Tan	a869d861f4	FIX: Make Jobs::MigrateUploadScheme a scheduled job. ... This reverts https://github.com/discourse/discourse/commit/9d8db11c If the job fails during execution or if `SiteSetting.migrate_to_new_scheme` has been set to `false`, the job will be considered as executed even though the migration has not been completed. As a result, the job will have to be executed manually which is not desirable.	2016-09-02 11:48:45 +08:00
Arpit Jalan	929730c008	FIX: properly insert images in markdown inline format (take 2)	2016-09-01 17:56:39 +05:30
Arpit Jalan	54a1180140	FIX: properly insert images in markdown inline format	2016-09-01 11:55:40 +05:30
Sam	896732975e	correct url linked in push notification	2016-08-26 13:45:56 +10:00
Sam	4fe52c8cbe	FEATURE: backend support for pushing notifications to clients	2016-08-26 12:47:10 +10:00
Matt Palmer	394cd43d77	Scrub only after converting strings to UTF-8 ... Scrubbing an ASCII-8BIT string isn't ever going to remove anything, because there's no code point that isn't valid 8-bit ASCII. Since we'd really prefer it if everything were UTF-8 anyway, we'll just assume, for now, that whatever comes out of SimpleRSS is probably UTF-8, and just nuke anything that isn't a valid UTF-8 codepoint. Of course, the *real* bug here is that SimpleRSS [unilaterally converts everything to ASCII-8BIT](https://github.com/cardmagic/simple-rss/issues/15). It's presumably *far* too much to ask that it detects the encoding of the source RSS feed and marks the parsed strings with the correct encoding...	2016-08-25 16:09:07 +10:00
Arpit Jalan	a2220feaea	FEATURE: new site setting rebake_old_posts_count	2016-08-15 16:34:13 +05:30
Régis Hanol	7db2083d45	FIX: 'cancel_scheduled_job' was deleting all jobs in multisite	2016-08-12 13:10:52 +02:00
Régis Hanol	e55e2aff94	FIX: FirstReplyByEmail badge wasn't granted ... DEPRECATED: PostProcess badge trigger	2016-08-10 19:24:01 +02:00
Régis Hanol	51322a46b3	FEATURE: retry processing incoming emails on rate limit	2016-08-08 22:28:27 +02:00
Robin Ward	8b252f19d7	Merge pull request #4365 from gdpelican/fix/daily-mlm-notifications ... Don't halt notification emails for those on daily mailing list mode	2016-08-08 14:30:56 -04:00
Arpit Jalan	c064e946b2	FIX: custom reason for flags were not showing for non-english locales	2016-08-05 18:41:11 +05:30
James Kiesel	c2819e99f4	Don't halt notification emails for those on daily mailing list mode	2016-08-03 12:29:38 -04:00
Régis Hanol	c591429868	FIX: don't destroy uploads in queued posts and drafts	2016-08-01 18:35:57 +02:00
Sam	12dc511fea	PERF: make score calculator cheaper when site has long topics	2016-07-22 09:48:44 +10:00