8 Commits

Author	SHA1	Message	Date
Loïc Guitaut	64605519da	DEV: Fix flaky specs related to flag services ... Creating or updating flags generates global side effects. Sometimes it seems the state can leak from the flag specs. This is probably related to the use of `fab!`. This patch replaces those calls with standard `let`s. While the overall performances of these tests will be a little less good, their state should not leak anymore.	2024-10-18 17:47:09 +02:00
Loïc Guitaut	7f607699b8	DEV: Refactor flag related services a bit ... Extracted from https://github.com/discourse/discourse/pull/29129. This patch makes the code more compliant with the upcoming service docs best practices.	2024-10-18 10:10:28 +02:00
Krzysztof Kotlarek	c5a024f8df	FIX: custom flag name should be unique (#28869) ... Validation to ensure that the custom flag name is unique.	2024-09-30 09:17:19 +10:00
Loïc Guitaut	d26d45540e	DEV: Use run_successfully matcher in service specs	2024-08-28 16:30:09 +02:00
Krzysztof Kotlarek	c975c7fe1b	FEATURE: custom flag can require additional message (#27908) ... Allow admin to create custom flag which requires an additional message. I decided to rename the old `custom_flag` into `require_message` as it is more descriptive.	2024-07-18 10:10:22 +10:00
Krzysztof Kotlarek	9e4e591d60	Revert "FEATURE: custom flag can require additional message (#27706)" (#27906) ... This reverts commit c0bcd979e3.	2024-07-15 09:45:57 +10:00
Krzysztof Kotlarek	c0bcd979e3	FEATURE: custom flag can require additional message (#27706) ... Allow admin to create custom flag which requires an additional message. I decided to rename the old `custom_flag` into `require_message` as it is more descriptive.	2024-07-15 08:48:01 +10:00
Krzysztof Kotlarek	c3fadc7330	FEATURE: created edit and delete flags (#27484) ... Allow admins to create edit and delete flags.	2024-07-03 08:45:37 +10:00