discourse

github-mirror/discourse

Fork 0

mirror of https://github.com/discourse/discourse.git synced 2024-11-26 19:43:38 +08:00

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Jan Cernik	117611ea82	FIX: 500 error when reviewable has a missing message (#25113 )	2024-01-03 11:49:54 -03:00
Alan Guo Xiang Tan	41f8bff2c3	DEV: Remove superfluous `js: true` metadata (#21960 ) Why this change? It is very unlikely that we need to ever JS for system tests considering that we rely on a JS framework on the frontend.	2023-06-07 09:26:58 +08:00
Joffrey JAFFEUX	6c90747dea	FIX: correctly use types for reviewables type (#21333 ) Before this fix if the underlying model of a reviewable was changed, the filter wouldn't work anymore as it was expecting a 1:1 relation between filter type and model name. This commit also relies on the `Reviewable.types` array to check against valid types instead of a regex not checking much. Finally this commit adds a spec to ensure chat reviewables are listable from the review index page.	2023-05-02 14:21:14 +02:00

Jan Cernik

117611ea82

FIX: 500 error when reviewable has a missing message (#25113 )

2024-01-03 11:49:54 -03:00

Alan Guo Xiang Tan

41f8bff2c3

DEV: Remove superfluous js: true metadata (#21960 )

Why this change?

It is very unlikely that we need to ever JS for system tests considering
that we rely on a JS framework on the frontend.

2023-06-07 09:26:58 +08:00

Joffrey JAFFEUX

6c90747dea

FIX: correctly use types for reviewables type (#21333 )

Before this fix if the underlying model of a reviewable was changed, the filter wouldn't work anymore as it was expecting a 1:1 relation between filter type and model name.

This commit also relies on the `Reviewable.types` array to check against valid types instead of a regex not checking much.

Finally this commit adds a spec to ensure chat reviewables are listable from the review index page.

2023-05-02 14:21:14 +02:00

3 Commits