Robin Ward
0b098566ff
REFACTOR: Remove _.union
2020-09-03 10:03:33 -04:00
Robin Ward
e60d06d880
REFACTOR: Remove _.isString
2020-09-03 10:03:33 -04:00
Robin Ward
b4444070b3
REFACTOR: Remove _.groupBy
2020-09-03 10:03:33 -04:00
Robin Ward
1265a5f7c0
REFACTOR: Remove _.max
2020-09-03 10:03:33 -04:00
Robin Ward
d06deb0c4f
REFACTOR: Remove _.chain
2020-09-03 10:03:33 -04:00
Robin Ward
71ddcefffa
REFACTOR: Remove _.filter
2020-09-03 10:03:33 -04:00
Robin Ward
87b3caf927
REFACTOR: Remove _.reject
2020-09-03 10:03:33 -04:00
Robin Ward
2a4dfa83b0
REFACTOR: Remove _.omit
2020-09-03 10:03:33 -04:00
Robin Ward
17bca14c4b
REFACTOR: Remove _.sortBy
2020-09-03 10:03:33 -04:00
Robin Ward
2353794a30
REFACTOR: Remove _.findIndex
2020-09-03 10:03:33 -04:00
Robin Ward
e3ec7b72d0
REFACTOR: Remove _.uniq and use ember version
2020-09-03 10:03:33 -04:00
Robin Ward
66021abe41
REFACTOR: Remove _.first from codebase
2020-09-03 10:03:33 -04:00
Robin Ward
55c9c54b8b
REFACTOR: Remove _.range and use ES6 instead
2020-09-03 10:03:33 -04:00
Robin Ward
115b3b6921
REFACTOR: Remove _.isEmpty in favor of the existing version
2020-09-03 10:03:33 -04:00
Robin Ward
65f6a92129
REFACTOR: Replace _.extend with Object.assign
2020-09-03 10:03:33 -04:00
Robin Ward
2f11457263
REFACTOR: Use Array.isArray instead of _.isArray
2020-09-03 10:03:33 -04:00
Blake Erickson
67dec38f31
FIX: Gravatar download attempt if user is missing their email
...
It is possible that a user could exist without an email, if so we should
not enqueue a job to download their gravatar.
This commit resolves this error that can occur:
```
Job exception: undefined method `email' for nil:NilClass
/var/www/discourse/app/models/user.rb:1204:in `email'
/var/www/discourse/app/jobs/regular/update_gravatar.rb:12:in `execute'
```
This commit also fixes the original spec which actually was wrong. The
job never enqueued in the original spec and so the gravatar was never
actually updated and the test was checking if the two values were the
same, but they were both null and never updated, so of course they were
the same!
A new test has also been added to make sure the gravatar job isn't
enqueued when a user's email is missing.
2020-09-02 20:19:46 -06:00
Krzysztof Kotlarek
9954a677ab
FIX: don't send mailing list for post with empty content ( #10577 )
...
discourse-assign is creating posts with empty content to show that a specific user was assign/unassigned for a specific topic.
It is causing confusing emails with empty content
The bug was mentioned here: https://meta.discourse.org/t/again-on-empty-emails-and-notifications-generated-on-topic-assignment/162213
2020-09-03 08:58:25 +10:00
Joffrey JAFFEUX
de038c0eab
FIX: highlightjs 10 requires some languages to be loaded before others ( #10584 )
...
cs is also not present in 10 and relies only on csharp file, but for cs alias to work csharp has to be loaded.
2020-09-02 21:32:57 +02:00
Penar Musaraj
6a837c32e4
DEV: Add class to wizard HTML element
2020-09-02 14:53:38 -04:00
Penar Musaraj
50827684d5
UX: Hide category settings badges checkbox when enable_badges is off
2020-09-02 11:23:59 -04:00
Robin Ward
0a492829ea
Add category id to webhook post serializer
2020-09-02 10:42:51 -04:00
Joffrey JAFFEUX
c6e336b519
REFACTOR: simplifies connectors code ( #10579 )
...
- directly uses factoryFor to avoid having to set owner later
- drops jquery usage
- renames view into component as I find it more explicit
2020-09-02 15:53:42 +02:00
Joe
879e274dc7
UX: wrap extra long links in GitHub oneboxes instead of overflowing
2020-09-02 21:50:57 +08:00
Gerhard Schlager
31c1d57228
FIX: System message wasn't fully translatable
2020-09-02 15:24:25 +02:00
Dan Ungureanu
ef68e11137
FIX: Check if invite has expired before showing it ( #10581 )
2020-09-02 13:24:49 +03:00
Guo Xiang Tan
01600492de
FIX: Don't raise error in update username job if user has been deleted.
2020-09-02 11:17:17 +08:00
awesomerobot
ec0b4b2acc
FIX: wait for groups before showing empty message
2020-09-01 22:36:00 -04:00
Jeff Wong
d49e96c6a3
DEV: add plugin hooks for silence message parameters ( #10538 )
...
DEV: add plugin hooks for silence message parameters
Allows plugins to add, and update extra silence message params for custom
i18n vars
Allows plugins to override system messages via `message_title` and
`message_raw` parameters. We can later expose these params where necessary via event
hooks. Expose the parameter for the on user_silenced trigger.
2020-09-01 17:25:24 -07:00
Kane York
26ec4fd25b
FIX: User export category preferences on a deleted category. ( #10573 )
...
Tests from a1dd761bd9
2020-09-01 13:22:59 -07:00
Ahmed Gagan
b14098ce28
removed REGEXP_IN_MATCH regex to make it flexible to use with plugins ( #10476 )
...
* dynamic regex generation for 'STATUS' and 'IN' ddropdown
2020-09-01 14:33:05 +02:00
Arpit Jalan
34478760b2
Update annotations.
2020-09-01 13:41:04 +05:30
Joffrey JAFFEUX
f8062300da
DEV: removes jquery usage from highlight-syntax ( #10564 )
2020-09-01 09:50:49 +02:00
Arpit Jalan
bb2e830010
Remove out-of-date / non-core annotations.
2020-09-01 12:40:57 +05:30
Arpit Jalan
e66eefe179
Annotate models.
2020-09-01 10:22:32 +05:30
Krzysztof Kotlarek
084e15b447
FIX: modify notification after remove auto_watch_category ( #10568 )
...
When a category is removed from `auto_watch_category` we are removing
CategoryUser. However, there are still TopicUser with notification level
set to `watching` which was inherited from Category.
We should move them back to `regular` unless they were modified by a user.
2020-09-01 13:07:41 +10:00
awesomerobot
e824385e64
only remove edit button margin when text is hidden
2020-08-31 22:45:43 -04:00
Guo Xiang Tan
069a109cbb
DEV: Require scheduled job in development to avoid loading file twice.
...
This removes the need to memoize constant in order to avoid the "warning: already initialized constant".
2020-09-01 10:14:40 +08:00
Kane York
a1dd761bd9
FIX: Handle deleted categories in post export ( #10567 )
...
Fixes a crash when exporting my own archive on Meta.
2020-08-31 17:33:28 -07:00
Martin Brennan
594d919d22
FIX: Focus first button in topic admin menu ( #10562 )
...
When using Shift+A to toggle the admin menu for a topic the first button was not focused, so the menu could not be navigated with tab.
2020-09-01 10:29:35 +10:00
Kane York
5ec5fbd7ba
User export improvements 2 ( #10560 )
...
* FEATURE: Use predictable filenames inside the user archive export
* FEATURE: Include badges in user archive export
* FEATURE: Add user_visits table to the user archive export
2020-08-31 15:26:51 -07:00
Joe
c3560a66f3
DEV: CSS truncation followup
...
After merging this
58fe78bf28 (diff-fed21847d651f6eb2cc76abbd770f5f8)
2020-09-01 02:01:17 +08:00
tshenry
2550c5bd03
FIX: Ensure disabling 2FA works as expected ( #10485 )
2020-08-31 09:56:57 -07:00
Roman Rizzi
2a3a173e8e
FIX: Disable insert link button when editing a category ( #10549 )
2020-08-31 13:50:40 -03:00
Joe
58fe78bf28
UX: don't wrap topic status icons in the header if there's more than one
...
Context: https://meta.discourse.org/t/when-a-topic-is-closed-and-pinned-the-pin-icon-in-header-not-in-correct-place/162473
Flex is causing a bit of a problem here since it makes the `topic-statuses` div in the header wrap when it has more than one icon. Given that we already use grid on the parent and that the icons are aligned properly, I think it's safe to remove it here.
2020-09-01 00:40:42 +08:00
Bianca Nenciu
f2e14a3946
FEATURE: Add site setting and wizard step to set base font ( #10250 )
...
Co-authored-by: Neil Lalonde <neillalonde@gmail.com>
2020-08-31 13:14:09 +03:00
Guo Xiang Tan
5270cd97ef
DEV: Leaking state in PostActionNotifier in tests take 2.
...
Follow-up to a3b48826
2020-08-31 12:55:42 +08:00
Guo Xiang Tan
a3b4882665
DEV: Leaking state in PostActionNotifier in tests.
...
Follow-up to 8a0478b97d
2020-08-31 12:04:17 +08:00
Sam Saffron
b31da92ede
DEV: clear last seen cache consistently
...
Previously in some cases the test suite could fail due to a bad entry in
redis from previous tests
This ensures the correct cache is expired when needed
Additionally improves performance of the redis check
2020-08-31 08:54:42 +10:00
Sam Saffron
8ca8a7edba
DEV: Lint file
...
Ruby in warning mode complains about `foo *[]` instead `foo(*[])` is
preferred
2020-08-31 08:52:01 +10:00
