Navin
3fdba0019b
Extract callbacks and validations for Post
...
Move Post create callbacks to PostCreate
Extract Post validations
Move stripped_length_validator to lib/validators
2013-06-09 20:47:04 +02:00
Robin Ward
26a81b30c2
When rebaking, update the links even if the cooked content didn't change. Someone
...
might be linking to us even if we don't have a link.
2013-06-08 21:53:33 -04:00
Chris Hunt
d741798d9c
Add onebox for GitHub pull requests
2013-06-08 11:01:06 -07:00
Robin Ward
c2821bee91
Merge pull request #990 from sanderdatema/dutch_translation
...
Updated Dutch translation
2013-06-08 09:58:37 -07:00
Sander Datema
27d0b120fd
Updated Dutch translation
2013-06-08 18:12:20 +02:00
Sam
26f378e022
Merge pull request #989 from chrishunt/redirect-when-cant-edit
...
Fix RestrictedUserRoute
2013-06-08 07:16:22 -07:00
Sam
9aa2cc2262
extra spec
2013-06-08 23:56:40 +10:00
Sam
1756f713d6
SECURITY HOLE, upgrade right away if you are using Secure Groups.
2013-06-08 23:52:06 +10:00
Chris Hunt
3bdfdd7c04
Redirect when can_edit === false or undefined
2013-06-07 22:09:51 -07:00
Chris Hunt
af1c14939e
Add 'dynamic favicon' setting
2013-06-07 17:15:49 -07:00
Jeff Atwood
7a73afa117
three main pre-reqs
2013-06-07 17:00:01 -06:00
Jeff Atwood
3fbcea6b21
add link to official-ish install docs
2013-06-07 16:57:55 -06:00
Jeff Atwood
9477cdaffa
Robin lurves him some MailCatcher
2013-06-07 16:54:09 -06:00
Sam
63c0c59114
Merge pull request #985 from avdi/clarify-jobs-dissection
...
Clarify job args dissection using destructuring assignment.
2013-06-07 15:44:34 -07:00
Robin Ward
eab38b5c34
JSHint fix :(
...
)
2013-06-07 18:08:08 -04:00
Robin Ward
b46b533e70
Create the composer view with the defaultContainer. This is in prep for redeploying
...
on RC5. Ideally we'll change how the composer is instantiated altogether but that will
have to wait for a future release.
2013-06-07 18:04:51 -04:00
Sam
a6f67d85eb
also should have caught this earlier
2013-06-08 07:47:48 +10:00
Sam
1e725629cd
no idea how this was even working
2013-06-08 07:45:45 +10:00
Robin Ward
f4d70b922d
Merge pull request #986 from chrishunt/fix-local-onebox
...
Link to category slug instead of name in onebox
2013-06-07 14:23:53 -07:00
Robin Ward
b2a6755a48
Merge pull request #984 from Supermathie/moreentropy
...
More entropy for foreign titles
2013-06-07 14:23:26 -07:00
Robin Ward
fa4cfa1269
ScreenTrack refactor - removes logic from TopicView didInsertElement
2013-06-07 17:20:10 -04:00
Neil Lalonde
34e1f376f6
Add [PM] to subject of email notifications for private messages
2013-06-07 15:50:11 -04:00
Chris Hunt
1df5a50324
Link to category slug instead of name in onebox
2013-06-07 12:31:39 -07:00
Robin Ward
463be6fadf
Merge pull request #982 from jd-erreape/add_scopes_to_roleable
...
Added role scopes to roleable
2013-06-07 12:08:26 -07:00
Robin Ward
cdc3a57a91
Merge pull request #983 from ZogStriP/fix-combobox-not-working-properly
...
FIX: combobox were not working properly
2013-06-07 12:08:04 -07:00
Michael Brown
f3fb10de03
settings: Update english description of entropy
2013-06-07 15:07:43 -04:00
Avdi Grimm
8cdd5d95fc
Clarify job args dissection using destructuring assignment.
2013-06-07 15:02:21 -04:00
Michael Brown
bb77d2c38b
More entropy for foreign titles
...
* Treat strings with non-ASCII characters as having more entropy
2013-06-07 14:47:07 -04:00
Régis Hanol
3f5c12ca1b
FIX: combobox were not working properly
2013-06-07 20:45:31 +02:00
Neil Lalonde
169125e96d
Fix a case where a random topic with null slug will be rendered instead of 404
2013-06-07 14:30:26 -04:00
Robin Ward
668a4a3042
Move MessageBus subscribing/unsubscribing out of view
2013-06-07 14:28:33 -04:00
Robin Ward
5217602ec3
FIX: RSS paths render a 404 for missing topics.
2013-06-07 12:52:12 -04:00
Robin Ward
1056b94b56
Don't apply styling unless the HTML template is active
2013-06-07 12:39:35 -04:00
Robin Ward
1b5ec42173
FIX: Regression where a topic rollback would not properly report errors to the client.
2013-06-07 12:36:37 -04:00
Juan de Dios Herrero
36fe8fbc6d
Added role scopes to roleable
2013-06-07 18:26:06 +02:00
Robin Ward
3ae72259a6
Merge pull request #979 from iancmyers/strong-parameters
...
All parameters for #create in PostsController pass through strong_parameters
2013-06-07 09:17:29 -07:00
Robin Ward
7c715e76e8
Refactor: Light pass of didInsertElement calls of views
2013-06-07 12:13:46 -04:00
Robin Ward
f23807af8f
Merge pull request #980 from jd-erreape/add_roleable_to_user
...
Added roleable module for User model
2013-06-07 07:24:08 -07:00
Juan de Dios Herrero
1b92d9d7f8
Added roleable module for User model
2013-06-07 12:33:48 +02:00
Ian Christian Myers
b61e10f9ad
All parameters for #create in PostsController pass through strong_parameters.
...
We are now explicitly whitelisting all parameters for Post creation. A nice side-effect is that it cleans up the #create action in PostsController. We can now trust that all parameters entering PostCreator are of a safe scalar type.
2013-06-07 01:29:25 -07:00
Sam
d1784f1f87
more moment goodness
2013-06-07 18:27:42 +10:00
Sam
000847b8d2
date helper uses the formatter now
2013-06-07 18:27:42 +10:00
Sam
5fa20ce357
more progress towards full migration to moment.js
2013-06-07 18:27:42 +10:00
Sam
875151f08a
Merge pull request #970 from chrishunt/you-already-like-me
...
Improve on-boarding experience
2013-06-06 20:22:41 -07:00
Chris Hunt
2f59c5c513
Set line height on entire row, not two columns
2013-06-06 18:37:25 -07:00
Chris Hunt
d50a598e62
Notify admin of successful user approval
2013-06-06 18:37:25 -07:00
Chris Hunt
f6ce985121
Send activation email after user approved
2013-06-06 18:37:25 -07:00
Chris Hunt
93fc0e74bc
Test correct login behavior when pending approval
2013-06-06 18:36:16 -07:00
Chris Hunt
41b0692543
Show 'waiting approval' and don't send email
...
When 'must approve users' in enabled, we don't want to send an
activation email to users after they sign up. Instead, we will show them
'waiting approval' and not take an action until their account is
approved by an admin.
2013-06-06 18:36:16 -07:00
Chris Hunt
e7b38fb188
Move duplicated request to helper method
2013-06-06 18:36:16 -07:00
