github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-14 11:43:40 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
36,883 Commits 214 Branches 500 Tags 960 MiB
0e3dfd2925
Commit Graph

36883 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Penar Musaraj
ea0f20e331 DEV: Concatenate value-list choices array 
Followup to 89d9704194
 2020-02-14 11:33:17 -05:00
Penar Musaraj
89d9704194 FIX: value-list choices when removing a value 
Fixes an issue where choices were broken when removing an item from the value-list component.

Adds test case for this scenario.
 2020-02-14 11:21:06 -05:00
Robin Ward
dafa354d3d FIX: Confirm draft_key is present on GET 
Also adds a test for the `show` action which did not exist
 2020-02-14 11:06:12 -05:00
Robin Ward
bfdd42c53a FIX: Return a 404 when the draft_key is missing 
Previously if `draft_key` was missing you'd get a 500 error in the logs.
 2020-02-14 10:48:56 -05:00
Régis Hanol
aad46a1aba DEV: remove unused 'composer/parse_html' route 2020-02-14 16:15:34 +01:00
David Taylor
b37d2f09ba
PERF: Memoize allowed user fields more efficiently (#8968) 
Previously we were caching by user_id, but the there are only two possible outcomes. Therefore we only need to cache two values.

This removes another N+1 query when serializing multiple user cards.
 2020-02-14 14:47:16 +00:00
Joffrey JAFFEUX
2c7d32e783
FIX: prevents everyone group to show as group option for polls (#8957) 2020-02-14 14:11:34 +01:00
David Taylor
ce588006e3
DEV: Update the site title in qunit fixtures (#8959) 
This confuses me every time I run qunit tests in the browser. The tab is labelled Meta, but it's not meta! This change has no functional impact on the tests
 2020-02-14 11:30:04 +00:00
Dan Ungureanu
8eae7d2799
DEV: Improve code readability (#8967) 
Follow-up to b0f72ca1 and 8e27fa1b.
 2020-02-14 13:05:52 +02:00
Joffrey JAFFEUX
7d94de6439
FIX: brings back castInteger as a safer migration path for sk2 (#8966) 2020-02-14 10:00:39 +01:00
Dan Ungureanu
09edde8ef7
DEV: Add test (#8961) 
Follow-up to 67c9940d72.
 2020-02-14 10:19:57 +02:00
Dan Ungureanu
9aeb9f0ca1
DEV: Add test (#8960) 
Follow-up to 3ad07aacfa.
 2020-02-14 10:19:40 +02:00
Krzysztof Kotlarek
e90f9e5cc4
FIX: when unread reply notification exists don't create new (#8921) 
* FIX: when unread reply notification exists don't create new

From time to time, the user is creating a reply post and then they want to add additional details. They edit an existing post and for example, add a quote from a previous one.

In that situation, if the user to whom reply was directed to already have the unread notification, we should not create the new one.

That behaviour was mentioned here: https://meta.discourse.org/t/reply-then-edit-to-add-quote-notification-redundancy/138358

* FIX: dont create new notification if already exists
 2020-02-14 16:41:42 +11:00
Vinoth Kannan
38dd184a16 FIX: update Site.top_tags in "categories" route if topic list available. 
Else it is not updating the tags dropdown while navigate between the category pages.
 2020-02-14 09:53:41 +05:30
dependabot-preview[bot]
157dcc7e3b
DEV: Bump sidekiq from 6.0.4 to 6.0.5 (#8964) 
Bumps [sidekiq](https://github.com/mperham/sidekiq) from 6.0.4 to 6.0.5.
- [Release notes](https://github.com/mperham/sidekiq/releases)
- [Changelog](https://github.com/mperham/sidekiq/blob/master/Changes.md)
- [Commits](https://github.com/mperham/sidekiq/compare/v6.0.4...v6.0.5)

Changes are safe, mostly around 2.7 support
 2020-02-14 14:53:31 +11:00
Martin Brennan
56b16bc68e
FIX: Never allow custom emoji to be marked secure (#8965) 
* Because custom emoji count as post "uploads" we were
marking them as secure when updating the secure status for post uploads.
* We were also giving them an access control post id, which meant
broken image previews from 403 errors in the admin custom emoji list.
* We now check if an upload is used as a custom emoji and do not
assign the access control post + never mark as secure.
 2020-02-14 11:17:09 +10:00
Joffrey JAFFEUX
149196b9ce
FIX: displays selection text when no default_notification_level is set (#8962) 2020-02-13 23:45:03 +01:00
Joffrey JAFFEUX
6405159484
FEATURE: adds a new plugin api to decorate plugin outlets (#8937) 
```
api.decoratePluginOutlet(
  "discovery-list-container-top",
  elem => {
    if (elem.classList.contains("foo")) {
      elem.style.backgroundColor = "yellow";
    }
  }
);
```
 2020-02-13 23:44:34 +01:00
Neil Lalonde
2136d4b5d5 Version bump to v2.4.0.beta11 2020-02-13 16:56:46 -05:00
Neil Lalonde
632ef306e2 Version bump to v2.3.10 2020-02-13 16:26:48 -05:00
Neil Lalonde
637535fc6b Update translations 2020-02-13 15:00:16 -05:00
Robin Ward
c2e58b6b85 FIX: Don't remove the topic image if posts don't have them 2020-02-13 14:00:30 -05:00
dependabot-preview[bot]
4b46db6ea8
Build(deps-dev): Bump webmock from 3.8.1 to 3.8.2 (#8951) 
Bumps [webmock](https://github.com/bblimke/webmock) from 3.8.1 to 3.8.2.
- [Release notes](https://github.com/bblimke/webmock/releases)
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md)
- [Commits](https://github.com/bblimke/webmock/compare/v3.8.1...v3.8.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-02-13 12:32:02 -05:00
Gerhard Schlager
a7efca1fa9 DEV: Remove unused "search help" 2020-02-13 18:31:21 +01:00
David Taylor
8d50f092b5
DEV: Use classes for styling user and group cards (#8913) 
Styling based on element-ids, it is impossible for themes/plugins to display multiple cards on a single page. Using classes is a more flexible approach. The element-ids are maintained for backwards compatibility with existing plugins/themes.
 2020-02-13 09:58:17 +00:00
Joffrey JAFFEUX
3875785dcc
FIX: ensures shortcuts work correctly with topic-notifications-button (#8956) 2020-02-13 10:01:28 +01:00
Joffrey JAFFEUX
42bda52486
FIX: ensures select-kit can select a row with 0 as value (#8955) 2020-02-13 09:04:32 +01:00
Martin Brennan
e1e74abd4f
FEATURE: Improving bookmarks part 2 -- Topic Bookmarking (#8954) 
### UI Changes

If `SiteSetting.enable_bookmarks_with_reminders` is enabled:

* Clicking "Bookmark" on a topic will create a new Bookmark record instead of a post + user action
* Clicking "Clear Bookmarks" on a topic will delete all the new Bookmark records on a topic
* The topic bookmark buttons control the post bookmark flags correctly and vice-versa
Disabled selecting the "reminder type" for bookmarks in the UI because the backend functionality is not done yet (of sending users notifications etc.)

### Other Changes

* Added delete bookmark route (but no UI yet)
* Added a rake task to sync the old PostAction bookmarks to the new Bookmark table, which can be run as many times as we want for a site (it will not create duplicates).
 2020-02-13 16:26:02 +10:00
Kris
e7c4ebc6d5 Fix styling for topic count in category chooser 2020-02-12 22:19:00 -05:00
Dan Dascalescu
b2ac80593e
Fix run-on sentence (#8953) 2020-02-12 18:13:38 -08:00
Blake Erickson
965ac3567b FIX: Handle SSO Provider Parse exception 
Prevent unnecessary 500 errors from appearing in the logs and return a
422 response instead.
 2020-02-12 16:08:04 -07:00
Michael Brown
904bbdb307 DOCS: Clarify what a DNS "A record" is with a link 
* context: https://meta.discourse.org/t/-/141250/6
 2020-02-12 16:50:56 -05:00
Gerhard Schlager
33728035c7
DEV: Add configuration file for Crowdin 2020-02-12 22:45:17 +01:00
Penar Musaraj
efa9ba4975
UX: Prevent category-drop topic count from wrapping to new line (#8943) 2020-02-12 14:34:16 -05:00
Artem Vasiliev
c36ae17260
FEATURE: export defaultRenderTag function (#8941) 
* FEATURE: export defaultRenderTag function

This can be helpful for plugins e.g. when combined with replaceTagRenderer: a plugin may want to customize rendering for some tags and let others be rendered with default code

* refactor: don't change version

..as per review comment, https://github.com/discourse/discourse/pull/8941#discussion_r378406809
 2020-02-12 14:26:04 -05:00
Robin Ward
726d97b29d FIX: Linking to a category via hashtag had a broken URL. 2020-02-12 14:23:09 -05:00
Penar Musaraj
a791b67e66 UX: Use border-box sizing on SK2 dropdowns 2020-02-12 14:14:36 -05:00
Arpit Jalan
3bcd1485f7 UX: show all parent categories for destination topic 2020-02-13 00:34:02 +05:30
dependabot-preview[bot]
08f1866152
Build(deps-dev): Bump simplecov from 0.18.1 to 0.18.2 (#8945) 
Bumps [simplecov](https://github.com/colszowka/simplecov) from 0.18.1 to 0.18.2.
- [Release notes](https://github.com/colszowka/simplecov/releases)
- [Changelog](https://github.com/colszowka/simplecov/blob/master/CHANGELOG.md)
- [Commits](https://github.com/colszowka/simplecov/compare/v0.18.1...v0.18.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-02-12 13:51:21 -05:00
Mark VanLandingham
c0ccfdb45e
FIX: Correctly compile theme template overrides (#8946) 2020-02-12 10:45:53 -08:00
Dan Ungureanu
82c84c5141
PERF: Memoize PostRevisor#diff_size (#8939) 
Although this method is usually called twice, its execution can take
about 1s.
 2020-02-12 19:47:48 +02:00
Vinoth Kannan
9c96511ec4 FIX: use plain text if available instead of image upload. 
Previously, while pasting from Excel 365 it uploaded a table image instead of markdown table.
 2020-02-12 23:13:51 +05:30
Penar Musaraj
52fe5b938c FIX: Regression with wizard canvas elements 2020-02-12 12:31:15 -05:00
Gerhard Schlager
453bec9394 FEATURE: Add small action post to indicate forwarded email 
This happens only when the sender of the email didn't write anything in their email.
 2020-02-12 16:23:17 +01:00
Gerhard Schlager
0adab26e45 FIX: Don't count ignored, missing uploads in migration to S3 2020-02-12 16:18:52 +01:00
dependabot-preview[bot]
fb2fad4811
Build(deps): Bump concurrent-ruby from 1.1.5 to 1.1.6 (#8930) 
Bumps [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby) from 1.1.5 to 1.1.6.
- [Release notes](https://github.com/ruby-concurrency/concurrent-ruby/releases)
- [Changelog](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ruby-concurrency/concurrent-ruby/compare/v1.1.5...v1.1.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: Robin Ward <robin.ward@gmail.com>
 2020-02-12 10:11:31 -05:00
Mark VanLandingham
0772a4338b
FIX: Remove pie draw animation (#8940) 2020-02-12 07:09:40 -08:00
dependabot-preview[bot]
86bbc844fa
Build(deps-dev): Bump test-prof from 0.11.2 to 0.11.3 (#8931) 
Bumps [test-prof](https://github.com/palkan/test-prof) from 0.11.2 to 0.11.3.
- [Release notes](https://github.com/palkan/test-prof/releases)
- [Changelog](https://github.com/palkan/test-prof/blob/master/CHANGELOG.md)
- [Commits](https://github.com/palkan/test-prof/compare/v0.11.2...v0.11.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: Régis Hanol <regis@hanol.fr>
 2020-02-12 09:38:32 -05:00
Dan Ungureanu
8e27fa1bd8
PERF: Optimize post editing 
Reordering the conditions reduced the execution time by a factor of 5.
 2020-02-12 15:53:28 +02:00
Dan Ungureanu
67c9940d72
FIX: Avoid highlight mention to groups that are not public. 
Follow-up to 3f50481188.
 2020-02-12 13:04:40 +02:00