github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-24 23:48:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
38,125 Commits 190 Branches 500 Tags 938 MiB
0edffcc47d
Commit Graph

38125 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Guo Xiang Tan
27b2e335ef
DEV: Retry on distributed mutex timeout error when starting sidekiq. 
We need Sidekiq to start `mini_scheduler` no matter what. Timeouts
happen when trying to boot an app with Redis in readonly mode.
 2020-06-23 15:43:28 +08:00
Martin Brennan
e92909aa77
FIX: Use ActionDispatch::Http::ContentDisposition for uploads content-disposition (#10108) 
See https://meta.discourse.org/t/broken-pipe-error-when-uploading-to-a-s3-clone-a-pdf-with-a-name-containing-e-i-etc/155414

When setting content-disposition for attachment, use the ContentDisposition class to format it. This handles filenames with weird characters and localization (accented characters) correctly.
 2020-06-23 17:10:56 +10:00
Sam Saffron
97f045d06a
DOCS: remove thin from copyright 
it is no longer used
 2020-06-23 15:43:58 +10:00
Guo Xiang Tan
1157d2a0ff
DEV: Print proper summary when errors have been reporter in turbo_rspec 2020-06-23 13:34:58 +08:00
Guo Xiang Tan
add2a9411e
DEV: Remove specs that are no longer relevant. 2020-06-23 12:09:04 +08:00
Guo Xiang Tan
e3e7905d9e
FIX: TurboTests::Runner not failing on errors. 2020-06-23 11:45:18 +08:00
Guo Xiang Tan
97d12a3a8e
Bump rails_failover to 0.5.2. 2020-06-23 10:07:30 +08:00
Guo Xiang Tan
d775338d63
FIX: Use a mutex when reseting column information while seeding. 
`rake multisite:migrate` runs SeedFu concurently in threads so we need
this to be thread safe.
 2020-06-23 09:15:47 +08:00
Guo Xiang Tan
0384b6d910
FIX: multisite:migrate failing to properly seed data. 2020-06-23 09:10:02 +08:00
Guo Xiang Tan
25db91e351
Revert "FIX: These tests are broken" 
This reverts commit b1114b9a20.
 2020-06-23 08:41:10 +08:00
Robin Ward
b1114b9a20 FIX: These tests are broken 2020-06-22 16:30:46 -04:00
Robin Ward
ac9577bcc7 FIX: Don't raise an exception if we can't update the user on demotion 
This is causing issues when purging old users, if they are set up in the
exact condition where they will be demoted into another group, but also
do not have a primary email.
 2020-06-22 15:43:59 -04:00
David Taylor
d473ddd02c
FIX: Use raw content when checking for watched words to flag (#10104) 
This makes flagged watched words match the behavior of censor, requires_approval and blocked watched words.
 2020-06-22 19:48:06 +01:00
dependabot-preview[bot]
1617905e03
Build(deps): Bump rubocop from 0.85.1 to 0.86.0 (#10103) 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.85.1 to 0.86.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.85.1...v0.86.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-06-22 12:43:39 -04:00
dependabot-preview[bot]
2ffb6ebd47
Build(deps): Bump parser from 2.7.1.3 to 2.7.1.4 (#10096) 
Bumps [parser](https://github.com/whitequark/parser) from 2.7.1.3 to 2.7.1.4.
- [Release notes](https://github.com/whitequark/parser/releases)
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/whitequark/parser/compare/v2.7.1.3...v2.7.1.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-06-22 12:39:59 -04:00
Dan Ungureanu
2e1efbde52
FIX: Pass local scope variable to inner function 2020-06-22 19:23:59 +03:00
Bianca Nenciu
68f767a557
FEATURE: Check if selectable avatars exist before enabling them (#10032) 2020-06-22 16:58:26 +03:00
Bianca Nenciu
685646540a
FIX: Hide PM tags if the site setting is disabled (#10089) 
* FIX: Hide PM tags if the site setting is disabled

* Apply code suggestions
 2020-06-22 16:48:24 +03:00
Bianca Nenciu
aff9bfd5bc
FIX: Fix select kit size (#10094) 2020-06-22 16:48:00 +03:00
Guo Xiang Tan
8cc8e80d7a
Fix the build. 2020-06-22 14:50:17 +08:00
Guo Xiang Tan
3370ef188e
FEATURE: Remove deprecated uploads url site settings. 
The site settings have been replaced with direct image upload since
Discourse 2.3.
 2020-06-22 14:32:29 +08:00
Martin Brennan
516a03be09
FIX: Improve admin permalink UX (#10101) 
The admin permalink list was a little tricky to use because the URLs are easily reduced with a ... if they are too long. This adds a copy to clipboard button for the URL and a title on hover so the full text of the URL can be seen.
 2020-06-22 13:14:16 +10:00
Jarek Radosz
26260d50b1
DEV: Import I18n in standard plugins (#10098) 2020-06-22 02:36:45 +02:00
Jarek Radosz
d04234c667 DEV: Fix typos in tests 2020-06-21 21:56:20 +02:00
Gerhard Schlager
1f053173a4 FEATURE: Import script for jForum 2020-06-21 12:12:42 +02:00
Gerhard Schlager
390dc5c7a9 Update translations 2020-06-21 11:58:21 +02:00
Kris
02d3bf304a remove inaccurate comment, follow up to c028936 2020-06-19 16:49:56 -04:00
Kris
c0289362f7 Safari icon fix, follow up to 5cc0369 2020-06-19 16:44:34 -04:00
David Taylor
17c4f76eac
FIX: Do not attempt to pull_hotlinked on emoji images when CDN enabled (#10091) 2020-06-19 20:21:05 +01:00
Jarek Radosz
f28ea4751b FIX: A variable name typo 
Not that this whole method is used much anymore.
 2020-06-19 19:29:19 +02:00
Régis Hanol
47a1157458 DEV: various bugfixes in bulk importer 2020-06-19 17:53:06 +02:00
Mark VanLandingham
0b58414de2
DEV: Add classes to admin customize nav items (#10092) 2020-06-19 10:51:53 -05:00
Jarek Radosz
58a5293d9b
FIX: Delete PostUploads on Post deletion (#10090) 
Related uploads will then be removed by Jobs::CleanUpUploads
 2020-06-19 17:45:08 +02:00
Robin Ward
4a2871f7f6
FEATURE: Don't display muted/ignored users under "who liked" (#10084) 
* FEATURE: Don't display muted/ignored users under "who liked"

Previously, if you clicked on the heart icon below a post
it would show you the avatar for a user even if you ignored or muted
them.

This commit will instead display a (?) icon. The count of likes will
remain correct, but you needn't be reminded of the person you
preferred not to see.

* Use a circle instead of (?) for unknown user
 2020-06-19 10:44:21 -04:00
Aman Gupta Karmani
8a86705e51
FIX: handle heroku style HTTP_X_REQUEST_START (#10087) 2020-06-19 10:17:24 -04:00
David Taylor
a99bb0ded4
Revert "FIX: Do not attempt to pull_hotlinked on emoji images when CDN enabled" 
This changed cause plugin spec failures and needs further investigation

This reverts commit 78626d2832.
 2020-06-19 14:39:16 +01:00
Penar Musaraj
29dc2058c5
DEV: Update ImageMagick version in CI (#10080) 2020-06-19 09:26:50 -04:00
David Taylor
9f2e7e4651
FIX: Handle invalid URLs gracefully when pulling hotlinked images 2020-06-19 12:52:51 +01:00
David Taylor
78626d2832
FIX: Do not attempt to pull_hotlinked on emoji images when CDN enabled 2020-06-19 12:45:06 +01:00
Daniel Waterworth
9cf77372a2 FIX: Guardian#can_remove_allowed_users? shouldn't break for ownerless topics 
A topic can outlive its original author. TopicGuardian should still work
in this situation.
 2020-06-19 10:35:52 +01:00
Joffrey JAFFEUX
3e161e372a
FEATURE: allows to have header/footer in publshed pages (#10067) 
Usage: fill Header/Footer sections of your theme.
 2020-06-19 09:51:03 +02:00
Martin Brennan
b5495b8e9c
FIX: Do not incorrectly add topic bookmark on Escape (#10088) 
* The first post was showing as bookmarked incorrectly after pressing f to open the topic modal then pressing escape to cancel without saving, because the closeWithoutSaving option was not being respected.
* Also re-introduce the enter shortcut when the name input is focused to saveAndClose the bookmark modal by pressing enter.
 2020-06-19 11:17:18 +10:00
Kris
5faf074e61 minor fix to post admin menu button class 2020-06-18 19:18:00 -04:00
Vinoth Kannan
ae47bcb269
DEV: move user references deletion code to before_destroy. (#10085) 
Moving the `delete_source_user_references` method code from user merger service to user model.
 2020-06-18 17:42:39 -04:00
Bianca Nenciu
a1df68d4c4
FIX: Do not change tracked categories for staged users (#10076) 2020-06-18 21:09:54 +03:00
Cassius
d13d5e2b99
FIX: Allow multiple hyphens in host (#10078) 
* FIX: Allow multiple hyphens in host

* FIX: added spec for multiple hyphens
 2020-06-18 13:58:47 -04:00
Robin Ward
494a27dc27 FIX: A much nicer error message if you can't ignore/mute a user 2020-06-18 13:41:27 -04:00
Robin Ward
6cb6faff29 UX: Ignore modal margin was too tight 2020-06-18 13:26:25 -04:00
Gerhard Schlager
2da6faf281 FEATURE: Add before_email_send event 
Plugins can use it to customize the message (e.g. add header) before the email is sent.
 2020-06-18 18:58:51 +02:00
Régis Hanol
5143309014 DEV: ensure values are converted to integers in bulk importer 2020-06-18 17:42:14 +02:00