github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 22:26:26 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
39,260 Commits 190 Branches 500 Tags 938 MiB
15f7fa801d
Commit Graph

39260 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Blake Erickson
67dec38f31 FIX: Gravatar download attempt if user is missing their email 
It is possible that a user could exist without an email, if so we should
not enqueue a job to download their gravatar.

This commit resolves this error that can occur:

```
Job exception: undefined method `email' for nil:NilClass
/var/www/discourse/app/models/user.rb:1204:in `email'
/var/www/discourse/app/jobs/regular/update_gravatar.rb:12:in `execute'
```

This commit also fixes the original spec which actually was wrong. The
job never enqueued in the original spec and so the gravatar was never
actually updated and the test was checking if the two values were the
same, but they were both null and never updated, so of course they were
the same!

A new test has also been added to make sure the gravatar job isn't
enqueued when a user's email is missing.
 2020-09-02 20:19:46 -06:00
dependabot-preview[bot]
d9b30308f1 Build(deps): Bump public_suffix from 4.0.5 to 4.0.6 
Bumps [public_suffix](https://github.com/weppos/publicsuffix-ruby) from 4.0.5 to 4.0.6.
- [Release notes](https://github.com/weppos/publicsuffix-ruby/releases)
- [Changelog](https://github.com/weppos/publicsuffix-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/weppos/publicsuffix-ruby/compare/v4.0.5...v4.0.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-09-03 09:53:59 +08:00
Krzysztof Kotlarek
9954a677ab
FIX: don't send mailing list for post with empty content (#10577) 
discourse-assign is creating posts with empty content to show that a specific user was assign/unassigned for a specific topic.

It is causing confusing emails with empty content

The bug was mentioned here: https://meta.discourse.org/t/again-on-empty-emails-and-notifications-generated-on-topic-assignment/162213
 2020-09-03 08:58:25 +10:00
Joffrey JAFFEUX
de038c0eab
FIX: highlightjs 10 requires some languages to be loaded before others (#10584) 
cs is also not present in 10 and relies only on csharp file, but for cs alias to work csharp has to be loaded.
 2020-09-02 21:32:57 +02:00
Penar Musaraj
6a837c32e4
DEV: Add class to wizard HTML element 2020-09-02 14:53:38 -04:00
Penar Musaraj
50827684d5
UX: Hide category settings badges checkbox when enable_badges is off 2020-09-02 11:23:59 -04:00
Robin Ward
0a492829ea Add category id to webhook post serializer 2020-09-02 10:42:51 -04:00
Joffrey JAFFEUX
c6e336b519
REFACTOR: simplifies connectors code (#10579) 
- directly uses factoryFor to avoid having to set owner later
- drops jquery usage
- renames view into component as I find it more explicit
 2020-09-02 15:53:42 +02:00
Joe
879e274dc7 UX: wrap extra long links in GitHub oneboxes instead of overflowing 2020-09-02 21:50:57 +08:00
Bianca Nenciu
803841ca47
FIX: Remove font-famly property in .font- classes 2020-09-02 16:29:09 +03:00
Gerhard Schlager
31c1d57228
FIX: System message wasn't fully translatable 2020-09-02 15:24:25 +02:00
Joffrey JAFFEUX
02f0637892
FIX: updates highlightjs to latest version to avoid a freeze (#10578) 
Example repro of the freeze:

```
```css
[
```
 2020-09-02 15:14:48 +02:00
Dan Ungureanu
ef68e11137
FIX: Check if invite has expired before showing it (#10581) 2020-09-02 13:24:49 +03:00
Dan Ungureanu
38c9c87128
FIX: Add to tags result set only visible tags (#10580) 2020-09-02 13:24:40 +03:00
dependabot-preview[bot]
fc7bd3e605 Build(deps): Bump rubocop from 0.89.1 to 0.90.0 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.89.1 to 0.90.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.89.1...v0.90.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-09-02 11:21:58 +08:00
Blake Erickson
d79f50a3c6 DEV: Remove rb-inotify gem from Gemfile 
We are no longer directly referencing the rb-inotify gem directly in
code. This was just a spec level dependency anyways.

Using `git log -S "Inotify"` resulted in these two commits as usages of
`Inotify`:

- b56b11d96a
- 9cf03b352c

both from 2013, but we no longer are using inotify in

https://github.com/discourse/discourse/blob/master/lib/tasks/autospec.rake

which appears to be the only file that was using it.

Based on this info we can safely remove rb-inotify from the Gemfile.

Just as a side note we still do have a couple of gems that do have
rb-inotify as a dependency: listen, and lru_redux.
 2020-09-02 11:21:40 +08:00
dependabot-preview[bot]
8ecd04cbe4 Build(deps-dev): Bump minitest from 5.14.1 to 5.14.2 
Bumps [minitest](https://github.com/seattlerb/minitest) from 5.14.1 to 5.14.2.
- [Release notes](https://github.com/seattlerb/minitest/releases)
- [Changelog](https://github.com/seattlerb/minitest/blob/master/History.rdoc)
- [Commits](https://github.com/seattlerb/minitest/compare/v5.14.1...v5.14.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-09-02 11:18:48 +08:00
Guo Xiang Tan
01600492de
FIX: Don't raise error in update username job if user has been deleted. 2020-09-02 11:17:17 +08:00
awesomerobot
ec0b4b2acc FIX: wait for groups before showing empty message 2020-09-01 22:36:00 -04:00
Sam Saffron
7b7357147e
FIX: add cache breaker for fonts 
This is a temporary fix since fonts may be cached without CORS

A larger scale change needed.

Our long term solution here is to have the SCSS compilation pipeline take
care of this by introducing some SCSS var that can be consumed in the various
stylesheets.

We do not want to write a file on boot
 2020-09-02 12:17:28 +10:00
Jeff Wong
d49e96c6a3
DEV: add plugin hooks for silence message parameters (#10538) 
DEV: add plugin hooks for silence message parameters

Allows plugins to add, and update extra silence message params for custom
i18n vars

Allows plugins to override system messages via `message_title` and
`message_raw` parameters. We can later expose these params where necessary via event
hooks. Expose the parameter for the on user_silenced trigger.
 2020-09-01 17:25:24 -07:00
Sam Saffron
f5051ec833
FIX: Allow fonts to be delivered via CDN 
We introduced support for custom fonts which are shipped out of the `/fonts`
directory, however we did not provide a bypass in our NGINX config.
 2020-09-02 10:19:19 +10:00
Vinoth Kannan
3b55de90e5 FIX: skip pm view action log while generating webhook payload. 
Currently, while generating webhook payloads for a topic it's accidentally adding a personal message view log in 'system' user's history.
 2020-09-02 05:40:42 +05:30
Kane York
26ec4fd25b
FIX: User export category preferences on a deleted category. (#10573) 
Tests from a1dd761bd9 were incomplete and did not test a deleted category's category_users record.
 2020-09-01 13:22:59 -07:00
Penar Musaraj
899b841554
DEV: Faster SCSS refresh locally for plugins 
Only updates the targeted stylesheet when available
 2020-09-01 13:56:40 -04:00
Jay Pfaffman
5e66d7d082
FIX: emails.rake use authentication (#10572) 
It looks like support got added for DISCOURSE_SMTP_AUTHENTICATION in Discourse, but not in this rake task (or perhaps it's always been broken?).

N.B.: I have not tested this code, but it reportedly works and looks safe to me.

https://meta.discourse.org/t/smtp-unrecognized-authentication-type-with-office-365/145830/6?u=pfaffman
 2020-09-01 11:08:18 -04:00
dependabot-preview[bot]
58e17d7eab
Build(deps-dev): Bump test-prof from 0.12.0 to 0.12.1 (#10571) 
Bumps [test-prof](https://github.com/test-prof/test-prof) from 0.12.0 to 0.12.1.
- [Release notes](https://github.com/test-prof/test-prof/releases)
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md)
- [Commits](https://github.com/test-prof/test-prof/compare/v0.12.0...v0.12.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-09-01 11:07:00 -04:00
Daniel Waterworth
a3580fa292 DEV: Show plugin versions in CI 2020-09-01 16:05:07 +01:00
dependabot-preview[bot]
90eeb8f7d9
Build(deps): Bump logster from 2.9.3 to 2.9.4 (#10570) 
Bumps [logster](https://github.com/discourse/logster) from 2.9.3 to 2.9.4.
- [Release notes](https://github.com/discourse/logster/releases)
- [Changelog](https://github.com/discourse/logster/blob/master/CHANGELOG.md)
- [Commits](https://github.com/discourse/logster/compare/v2.9.3...v2.9.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-09-01 16:15:54 +03:00
Discourse Translator Bot
71da5e0e27 Update translations 2020-09-01 13:02:16 +00:00
Ahmed Gagan
b14098ce28
removed REGEXP_IN_MATCH regex to make it flexible to use with plugins (#10476) 
* dynamic regex generation for 'STATUS' and 'IN' ddropdown
 2020-09-01 14:33:05 +02:00
Arpit Jalan
34478760b2 Update annotations. 2020-09-01 13:41:04 +05:30
Joffrey JAFFEUX
f8062300da
DEV: removes jquery usage from highlight-syntax (#10564) 2020-09-01 09:50:49 +02:00
Arpit Jalan
bb2e830010 Remove out-of-date / non-core annotations. 2020-09-01 12:40:57 +05:30
Arpit Jalan
e66eefe179 Annotate models. 2020-09-01 10:22:32 +05:30
Krzysztof Kotlarek
084e15b447
FIX: modify notification after remove auto_watch_category (#10568) 
When a category is removed from `auto_watch_category` we are removing
CategoryUser. However, there are still TopicUser with notification level
set to `watching` which was inherited from Category.

We should move them back to `regular` unless they were modified by a user.
 2020-09-01 13:07:41 +10:00
awesomerobot
e824385e64 only remove edit button margin when text is hidden 2020-08-31 22:45:43 -04:00
Guo Xiang Tan
069a109cbb
DEV: Require scheduled job in development to avoid loading file twice. 
This removes the need to memoize constant in order to avoid the "warning: already initialized constant".
 2020-09-01 10:14:40 +08:00
Guo Xiang Tan
09a89cff1a
DEV: Increase log levels for more assets/static paths. 2020-09-01 09:52:50 +08:00
Kane York
a1dd761bd9
FIX: Handle deleted categories in post export (#10567) 
Fixes a crash when exporting my own archive on Meta.
 2020-08-31 17:33:28 -07:00
Martin Brennan
594d919d22
FIX: Focus first button in topic admin menu (#10562) 
When using Shift+A to toggle the admin menu for a topic the first button was not focused, so the menu could not be navigated with tab.
 2020-09-01 10:29:35 +10:00
Kane York
5ec5fbd7ba
User export improvements 2 (#10560) 
* FEATURE: Use predictable filenames inside the user archive export

* FEATURE: Include badges in user archive export

* FEATURE: Add user_visits table to the user archive export
 2020-08-31 15:26:51 -07:00
Blake Erickson
43ffd4d28f
DEV: Switch our fast_xor gem for xorcist (#10565) 
* DEV: Switch our fast_xor gem for xorcist

We use the `xor` function as part of password hashing and we want to use
a faster version than the native ruby xor'ing feature so we use a gem
for this.

fast_xor has been abandoned, and xorcist fixed our initial holdup for
switching in https://github.com/fny/xorcist/issues/4

xorcist also has jruby support so we can remove our jruby fallback
logic.

* Move using statement inside of class
 2020-08-31 13:20:44 -06:00
Joe
c3560a66f3 DEV: CSS truncation followup 
After merging this

58fe78bf28 (diff-fed21847d651f6eb2cc76abbd770f5f8)

I noticed that the code I'm removing in this commit is causing text to be truncated a bit early on desktop. So, I'm removing it for now.
 2020-09-01 02:01:17 +08:00
tshenry
2550c5bd03
FIX: Ensure disabling 2FA works as expected (#10485) 2020-08-31 09:56:57 -07:00
Roman Rizzi
2a3a173e8e
FIX: Disable insert link button when editing a category (#10549) 2020-08-31 13:50:40 -03:00
Joe
58fe78bf28 UX: don't wrap topic status icons in the header if there's more than one 
Context: https://meta.discourse.org/t/when-a-topic-is-closed-and-pinned-the-pin-icon-in-header-not-in-correct-place/162473

Flex is causing a bit of a problem here since it makes the `topic-statuses` div in the header wrap when it has more than one icon. Given that we already use grid on the parent and that the icons are aligned properly, I think it's safe to remove it here.
 2020-09-01 00:40:42 +08:00
Robin Ward
284b9e9911 FIX: Flaky JS test due to not waiting for promises 2020-08-31 11:46:28 -04:00
Bianca Nenciu
f2e14a3946
FEATURE: Add site setting and wizard step to set base font (#10250) 
Co-authored-by: Neil Lalonde <neillalonde@gmail.com>
 2020-08-31 13:14:09 +03:00
Jarek Radosz
7290ca1f4a DEV: Remove jquery.cookie 
A follow up to c172f2068d

cc: @eviltrout
 2020-08-31 11:53:01 +02:00