discourse

github-mirror/discourse

Fork 0

mirror of https://github.com/discourse/discourse.git synced 2024-12-02 10:36:18 +08:00

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Krzysztof Kotlarek	b061631c18	FIX: correctly untrack topics when dismiss unread (#23894 ) Bug introduced when dismiss modal was moved to new component-based API - https://github.com/discourse/discourse/pull/22262 We need to track `dismissTopics` property to send correct request to server. Meta: https://meta.discourse.org/t/dismiss-all-unread/280948	2023-10-11 02:51:43 +00:00
Alan Guo Xiang Tan	1052ed9c3b	DEV: Fix flaky system test in `system/category_topics_spec.rb` (#22652 ) Why was the test flaky? The test relied on the fact that visiting a topic would marked its post as unread. However, we did not actually stay on the topic long enough in some cases for it to be considered read based on the logic in our client side code. This commit fixes the flakiness by ensuring that the post has actually been read before navigating away.	2023-07-18 07:35:47 +08:00

Krzysztof Kotlarek

b061631c18

FIX: correctly untrack topics when dismiss unread (#23894 )

Bug introduced when dismiss modal was moved to new component-based API - https://github.com/discourse/discourse/pull/22262

We need to track `dismissTopics` property to send correct request to  server.

Meta: https://meta.discourse.org/t/dismiss-all-unread/280948

2023-10-11 02:51:43 +00:00

Alan Guo Xiang Tan

1052ed9c3b

DEV: Fix flaky system test in system/category_topics_spec.rb (#22652 )

Why was the test flaky?

The test relied on the fact that visiting a topic would marked its
post as unread. However, we did not actually stay on the topic long
enough in some cases for it to be considered read based on the logic in
our client side code.

This commit fixes the flakiness by ensuring that the post has actually
been read before navigating away.

2023-07-18 07:35:47 +08:00

2 Commits