Commit Graph

1281 Commits

Author SHA1 Message Date
riking
1833b43ae2 FEATURE: Badge query validation, preview results, and EXPLAIN
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.

Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.

On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).

The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.

The Badge.save() method is amended to propogate errors.

Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.

Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.

An uninitialized variable path is removed in the backfill() method.

TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
Jeff Atwood
4281b16616 UX: dim the new and unread education 2014-08-29 22:54:11 -07:00
Régis Hanol
38f52f0f8e FIX: banner topic's max-width & max-height on both mobile & desktop 2014-08-28 16:15:48 +02:00
Robin Ward
09ea159afc UX: Add link to change username on admin page 2014-08-27 13:52:01 -04:00
Jeff Atwood
009dc7ded3 missed a spot in CSS 2014-08-27 02:58:32 -07:00
Jeff Atwood
f557f7eeb9 change fix for [quote] padding 2014-08-27 02:45:57 -07:00
Jeff Atwood
dc6dd26b10 FIX: [quote][/quote] missing top padding 2014-08-27 02:22:58 -07:00
Jeff Atwood
587f7f56c8 FIX: share link pushing viewport on mobile 2014-08-27 00:46:26 -07:00
Jeff Atwood
180430de93 LAYOUT: add more space around topic map links 2014-08-27 00:24:58 -07:00
Sam
64331e2ac1 row style is common, its the way we clear divs 2014-08-26 07:41:29 +10:00
Jeff Atwood
de1e0345df proper fix for top page bottom buttons on mobile 2014-08-25 12:55:45 -07:00
Jeff Atwood
a11cc46c73 remove global margin right on mobile btn 2014-08-25 12:47:02 -07:00
Jeff Atwood
024c503870 mobile login tweaks 2014-08-25 12:38:27 -07:00
Jeff Atwood
3a010c34cc smallenate anon drop-down topic counts 2014-08-25 12:14:47 -07:00
Sam
af71307363 Add 10px margin for buttons in mobile 2014-08-23 10:41:48 +10:00
Jeff Atwood
ae9fcf17ef make period chooser (/top h2) unselectable on touch 2014-08-22 17:01:12 -07:00
Kris Aubuchon
a8e6e1e3d5 adding highlight back to topic-list 2014-08-22 10:45:51 -04:00
Robin Ward
c1aa2458f8 UX: Add drop down for top lists, big refactor of repeated code. 2014-08-21 16:08:47 -04:00
Régis Hanol
b2232b4dcf FIX: banner on small desktop screen 2014-08-20 22:45:57 +02:00
Régis Hanol
8a20d05ba5 FEATURE: backup without uploads 2014-08-20 18:53:58 +02:00
Jeff Atwood
4c66362dd1 remove right-arrow on cross-topic oneboxes 2014-08-19 15:19:01 -07:00
Robin Ward
b46a373ff9 UX: Show User popup when clicking on a user in the topic list. 2014-08-19 16:22:37 -04:00
Régis Hanol
9f72971d26 FEATURE: add the pencil glyph when the post was edited after the first flag 2014-08-18 18:56:39 +02:00
Jeff Atwood
e9bfb1c89e make share link input field readonly, with css tweaks 2014-08-17 23:08:53 -07:00
Jeff Atwood
09291fcba0 make entire first/last entry popup unselectable 2014-08-16 23:16:13 -07:00
Jeff Atwood
6d09f53dfc topic jump buttons shouldn't be selectable 2014-08-16 14:20:20 -07:00
Robin Ward
aa41548e8e UX: When clicking an activity date, pop up a little menu with options to
go to beginning or end of the topic.
2014-08-15 16:39:57 -04:00
Jeff Atwood
c04b7cfe8a only do two levels of coldmapping 2014-08-14 22:27:10 -07:00
Jeff Atwood
f8cb0b6452 we have two sets of heatmap colors, apparently 2014-08-14 21:55:17 -07:00
Jeff Atwood
c32f64fe94 more betterer heat/coldmap color scheme 2014-08-14 21:36:35 -07:00
Jeff Atwood
e539e6ff21 try grey instead of blue for coldmap range 2014-08-14 16:42:31 -07:00
Kris Aubuchon
56e7ca10fe swapping around heatmap low/high 2014-08-14 09:33:41 -04:00
Jeff Atwood
7fc2892ef4 curse you misaligned semicolon 2014-08-14 03:25:48 -07:00
Jeff Atwood
a7528c858d hide sign up button from header on mobile 2014-08-14 03:04:09 -07:00
Jeff Atwood
48051127fc improve keyboard shortcut help layout 2014-08-14 02:54:53 -07:00
Kris Aubuchon
982b007604 heatmap/coldmap should stay red/blue despite theming 2014-08-13 16:38:49 -04:00
riking
62ed597faa Also put the shaded background on desktop 2014-08-13 12:43:27 -07:00
riking
6b22776160 Style & structure fixes for mobile user page 2014-08-13 12:38:55 -07:00
Jeff Atwood
c89a354fb1 clean up some flag page styles and alignment 2014-08-12 23:52:43 -07:00
Jeff Atwood
c83a742bec notification dropdown should not be selectable 2014-08-12 23:32:16 -07:00
Kris Aubuchon
6166e78888 adding hover state to notification menu, and small additional fixes 2014-08-13 00:03:29 -04:00
Robin Ward
532726005b FIX: Heatmaps for posts not showing up if you're not colourblind :) 2014-08-12 16:35:48 -04:00
Robin Ward
e49ef042f1 UX: Remove icon from sign up button, change button order 2014-08-12 13:51:00 -04:00
Robin Ward
1684ff3015 UX: Add a separate "Sign Up" button 2014-08-12 13:47:23 -04:00
Jeff Atwood
63d71fde80 tighten spacing on flags page 2014-08-12 03:49:19 -07:00
Kris Aubuchon
2ce291c2ab small fixes for dark themes 2014-08-12 00:11:58 -04:00
Robin Ward
c8767dc505 UX: Tweak about page 2014-08-11 18:15:49 -04:00
Robin Ward
996d14965e Minor UX tweaks 2014-08-11 17:03:12 -04:00
Robin Ward
c103398e9a First stab at About page 2014-08-11 16:59:15 -04:00
Régis Hanol
5e41408b55 FEATURE: use less space for flag dispositions 2014-08-11 22:28:11 +02:00