David Taylor
1844bde57c
FIX: Allow mobile-nav to work without loading transitions ( #12184 )
...
Previously, the `{{mobile-nav}}` component required a `currentRouteName` property, passed from the router service. It would observe changes in this property, and update the UI accordingly.
If we change between routes which have the same `currentRouteName` (e.g. two different group message inboxes), then the `currentRouteName` does not change and does not trigger the observer. Currently in core, we are relying on the fact that currentRouteName temporarily enters a `.loading` substate during a transition. This will change when we remove the loading substate in the near future.
This commit refactors `{{mobile-nav}}` to inject the router directly, and use the `routeDidChange` event instead of an observer. The change is backwards compatible, but plugins passing the old `currentPath` property will be shown a deprecation notice.
2021-02-23 11:16:40 +00:00
Osama Sayegh
0f807ba85b
UX: Allow select-kit to have an autofocus option ( #12183 )
...
On some modals the main/primary input field is a select-kit component (like `{{email-group-user-chooser}}` on the assign modal), so it makes sense to allow select-kit to steal focus on modals like these. This PR adds an `autofocus` option (default false) that allows select-kit to steal focus when it's rendered.
2021-02-23 13:20:32 +03:00
Kris
477930683b
UX: More consistent group mention style ( #12156 )
2021-02-22 19:02:47 -05:00
Neil Lalonde
9a72876863
DEV: add plugin outlets above and below discovery-categories ( #12176 )
2021-02-22 17:17:03 -05:00
Penar Musaraj
9063520d89
FIX: Avoid Safari service worker error on back navigation ( #12171 )
2021-02-22 14:11:20 -05:00
Penar Musaraj
0620f6298e
UX: Remove emoji step in wizard ( #12169 )
2021-02-22 12:14:18 -05:00
Jarek Radosz
3ba0a47e61
UX: Tweak group layout to fix button alignment ( #12167 )
...
Included:
* DEV: Span can't contains divs
* DEV: Drop extra elements
* UX: Tweak `group` layout to fix button alignment
* UX: Add space between "Members" and "(N)"
2021-02-22 16:06:52 +01:00
Jarek Radosz
b693bf8ca0
FIX: Don't show "bulk" icon on group-index for unauthorized users ( #12166 )
...
Closes https://meta.discourse.org/t/group-management-tools-show-up-for-all-users/179259/9
Includes:
* DEV: Add missing <tr>
2021-02-22 15:29:04 +01:00
Jarek Radosz
858436b17c
DEV: Fix group-index-test under Ember CLI ( #12153 )
...
`:nth()` and `:first` are jQuery-only selectors and fail when used with `querySelector`/`querySelectorAll`.
2021-02-22 15:27:01 +01:00
Jarek Radosz
24f828c467
DEV: Scope query to the testing container ( #12152 )
...
We don't want it to find QUnit UI elements… This fixes some Ember CLI test failures.
2021-02-22 15:26:50 +01:00
Joffrey JAFFEUX
d0d54bbead
A11Y: deselect focused choice when using enter in multi-select ( #12165 )
2021-02-22 14:34:31 +01:00
Joffrey JAFFEUX
74d83abcc7
A11Y: gives autocomplete in search a more accessible name ( #12164 )
...
s/discourse/discourse-search
2021-02-22 12:11:06 +01:00
Joffrey JAFFEUX
b7dbdec6fb
A11Y: makes other and color, fieldset/legend elements ( #12163 )
2021-02-22 12:10:51 +01:00
Joffrey JAFFEUX
0b14eb6ab1
A11Y: makes edit username and avatar accessible ( #12162 )
...
This commit also adds name as a bindable attribute of link-to
2021-02-22 12:10:44 +01:00
David Taylor
863c7919d7
FIX: Close navigation dropdown when item selected ( #12155 )
...
This `if` statement was backwards, such that it was a no-op. This hasn't
caused a problem because clicking an item triggers a page load, which
destroys and recreates the component.
However, we are soon planning to remove the intermediate loading screen,
which means the component will not be removed/recreated.
https://meta.discourse.org/t/177939/202
2021-02-22 10:41:09 +00:00
Joffrey JAFFEUX
72258c663b
A11Y: ensures avatar image in site header has alt attribute ( #12161 )
2021-02-22 11:09:18 +01:00
Kris
47ef83505f
UX: make tag input full width for PMs ( #12158 )
2021-02-22 16:49:12 +11:00
Neil Lalonde
da8b0818ef
DEV: add classes to sections in category settings ( #12150 )
...
Some had them, most didn't.
2021-02-19 15:28:19 -05:00
Rafael dos Santos Silva
5117f0a3e8
FIX: Subfolder replace should only affect URL prefix ( #12135 )
...
* FIX: Subfolder replace should only affect URL prefix
Issue was reported in https://meta.discourse.org/t/-/179504
* DEV: Test subfolder handling in get-url when called twice on the same path
2021-02-19 16:06:18 -03:00
Penar Musaraj
5604ce70d4
DEV: More refactoring of SCSS importers ( #12143 )
2021-02-19 11:22:24 -05:00
Penar Musaraj
7ee660a017
FIX: Sort admin dashboard new updates by latest ( #12146 )
2021-02-19 11:03:36 -05:00
Joffrey JAFFEUX
47835ade9a
UX: implements a new tags-intersection-chooser ( #12139 )
2021-02-19 13:46:02 +01:00
Martin Brennan
11f28e3eb3
FIX: Do not allow bookmarks to use post date in past for reminder ( #12138 )
...
See https://meta.discourse.org/t/bookmark-reminder-date-in-post-in-the-past/180128
2021-02-19 13:57:27 +10:00
Kris
c3f6eb17a5
UX: On very short screens switch quick-access-profile to 2-columns ( #12120 )
2021-02-18 18:47:37 -05:00
Kris
77c8f0c864
UX: Show bullets for some composer lists ( #12122 )
2021-02-18 18:47:27 -05:00
Jordan Vidrine
de119afec5
UX: Adjust padding on create account modal ( #12133 )
...
This commit adds padding to the top and bottom of the form on the create account modal.
2021-02-18 16:03:55 -06:00
Penar Musaraj
916e1d85cf
FEATURE: Quick theme installs via query parameters ( #12128 )
2021-02-18 12:51:44 -05:00
Joffrey JAFFEUX
e175e17ebb
UX: publishes page, on public change, only when page is published ( #12123 )
2021-02-18 17:34:50 +01:00
Kris
c6a9142dbb
FIX: remove top gradient from signup modal ( #12121 )
2021-02-18 08:12:28 -06:00
Jordan Vidrine
2aab306665
UX: Remove margin from security key login button ( #12115 )
...
This commit removes the right margin from the security key button in the login with security key screen.
2021-02-18 08:12:03 -06:00
Bianca Nenciu
08acf51be0
FEATURE: Use diffhtml to update composer preview ( #11237 )
...
Displaying videos, animated GIFs or any kind of rich content in preview
used to refresh on every keystroke, which could cause performance
problems.
2021-02-18 16:07:26 +02:00
Martin Brennan
e0f0fe5624
FIX: Bump max topic timer duration to 20 years ( #12107 )
...
This way it has some sort of cap, even if it seems pretty
high, and we don't have to worry about requests for increasing
it from 2 to 5 to 10 etc.
2021-02-18 11:52:30 +10:00
Kris
c4ff6def8e
UX: change emailLogin to info class when empty ( #12105 )
2021-02-17 16:28:52 -05:00
Penar Musaraj
4739bdac0a
UX: Adjustments to admin theme editor ( #12112 )
2021-02-17 13:00:34 -05:00
Arpit Jalan
a174c8b8d4
FIX: hide sso payload behind a button click and log views ( #12110 )
2021-02-17 21:27:51 +05:30
Penar Musaraj
431c6de480
UX: Add editing guidance for remote themes ( #12111 )
2021-02-17 10:24:34 -05:00
Joffrey JAFFEUX
237d172fd9
DEV: flexify post-controls and stop relying on clearfix ( #12098 )
2021-02-17 09:58:17 +01:00
Kris
933dde9419
A11Y: Add rowheader to topic title TDs ( #12092 )
2021-02-17 00:00:34 -05:00
Kris
355b8f69af
UX: Fix excess line breaks in login modal alerts ( #12104 )
2021-02-16 21:22:49 -05:00
Arpit Jalan
94036a6f49
FIX: force refresh staff action logs when transitioning from site settings ( #12096 )
2021-02-17 00:18:39 +05:30
Bianca Nenciu
d89c5aedbe
FIX: Fix subcategory, tag drops and none values ( #11934 )
...
* FIX: Generate correct URLs for category and tag drops
* DEV: Remove unused properties
* FIX: No subcategory and tag filter did not work
2021-02-16 17:54:24 +02:00
Osama Sayegh
277eae97e1
FIX: Use autocomplete=discourse in select-kit to disable autocomplete in Chrome ( #12094 )
...
Chrome ignores `autocomplete="off"` on input fields, but as a workaround we can supply a nonsensical value (`discourse` or anything else) to the `autocomplete` attribute and it'll disable autocomplete.
Context: https://meta.discourse.org/t/-/107484/66?u=osama and https://meta.discourse.org/t/-/140884/13?u=osama .
2021-02-16 12:46:46 +03:00
Martin Brennan
0cba1fafe4
DEV: debug: false for service workers to stop log spam via workbox ( #12093 )
2021-02-16 14:01:19 +10:00
Martin Brennan
9f0f801ae3
FIX: Do not mark group_flair images as secure on upload ( #12081 )
...
See https://meta.discourse.org/t/secure-media-uploads-breaks-group-flair-image/173671/4
Group flair image uploads definitely do not need to be secure.
2021-02-16 12:34:03 +10:00
Martin Brennan
c0c7c237aa
FIX: Clean up topic-timer-info CSS classes, add edit button, and improve UI ( #12080 )
...
This PR adds an edit button to the topic timer info message which opens the modal.
Also, I have cleaned up a few more places where we were referencing "topic status update" which is what these were called prior to being called topic timers.
The category settings for auto-close topic hours has now also been modified to use the new relative-time-picker component.
Finally, the relative-time-picker input step and min is dynamic based on mins/other intervals selected, see https://review.discourse.org/t/feature-relative-time-input-for-timers-and-bookmarks-and-promote-auto-close-after-last-post-timer-12063/19204/7?u=martin
2021-02-16 12:07:30 +10:00
Joffrey JAFFEUX
323a5f22e7
A11Y: makes select-kit header a listbox ( #12078 )
...
Note that for now pressing enter doesn’t make anything, this is awaiting another change.
2021-02-15 18:22:10 +01:00
Arpit Jalan
85c4e8fd32
FEATURE: support mark tag ( #12088 )
...
This commit adds support for `mark` tag for highlighting text content.
2021-02-15 21:47:30 +05:30
Joffrey JAFFEUX
c5d0a33cc5
A11Y: adds support for aria-current through d-navigation-item ( #12079 )
2021-02-15 15:34:25 +01:00
Gerhard Schlager
f71ff2c34b
UX: relative-time-picker should use pluralized strings ( #12086 )
2021-02-15 14:15:22 +01:00
Joffrey JAFFEUX
467b075ef7
A11Y: makes aria-owns an ID and not a data attribute ( #12075 )
2021-02-15 12:32:09 +01:00
