Commit Graph

7940 Commits

Author SHA1 Message Date
Sam
e1ce47a901 Pass the full CommonMark spec 2017-07-21 13:20:52 -04:00
Robin Ward
aa5b8a5749 REFACTOR: Merge onebox and inline onebox code paths 2017-07-21 13:12:30 -04:00
Guo Xiang Tan
2a17f1ccd7 FIX: Group owners should be able to invite users to their groups.
https://meta.discourse.org/t/group-owner-cannot-send-an-invite-to-a-group/60617/12
2017-07-21 23:48:25 +09:00
Joffrey JAFFEUX
c7f2b0fe58 tweaks to copy and styles 2017-07-21 14:19:04 +02:00
Joffrey JAFFEUX
79c8b505e8 FIX: faster successive loading of emojis 2017-07-21 14:18:02 +02:00
Joffrey JAFFEUX
1ce1953ee1 FIX: makes sure we don’t track when clicking on recent emojis 2017-07-21 13:35:55 +02:00
Joffrey JAFFEUX
c906bd3f22 emoji-picker refactoring 2017-07-21 13:35:29 +02:00
Joffrey JAFFEUX
1ca0c33802 FIX: dot not close emoji-picker when click is inside picker 2017-07-21 12:01:39 +02:00
Joffrey JAFFEUX
0c9ea1aaf2 reduce emoji loading threshold 2017-07-21 11:46:34 +02:00
Jakub Macina
44bd8f3837 Add info about more results to full-page search frontend. 2017-07-21 09:35:04 +02:00
Robin Ward
657e592a39 FIX: Oneboxes were not being previewed 2017-07-20 17:12:54 -04:00
Robin Ward
3882722195 FEATURE: Inline (Mini) Oneboxing
see:
https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400?source_topic_id=66066
2017-07-20 15:38:04 -04:00
Sam
44fb2a2833 DEV: support multiple capture groups for text post process 2017-07-20 15:33:44 -04:00
Joffrey JAFFEUX
d7a20c8e93 FIX: Object.assign is not supported in all browsers 2017-07-20 20:27:59 +02:00
Joffrey JAFFEUX
ac6413f456 FIX: broken specs 2017-07-20 20:08:11 +02:00
Sam
1096dcd602 correct bbcode parsing edge case 2017-07-20 13:02:40 -04:00
Sam
0791d740a6 FIX: only highlight exact word matches in results
- also fixes phrase highlighting
2017-07-20 12:26:46 -04:00
Sam
911ffbb98c Correct mention edge cases
@sam. was not correctly detected as a mention
2017-07-20 11:52:38 -04:00
Joffrey JAFFEUX
a9ab3f9ef0 FIX: emoji-picker positioning glitches on few edge cases 2017-07-20 17:03:45 +02:00
Joffrey JAFFEUX
a5a3651cf3 FIX: improves emoji-picker handling of its different states
- closing modal with escape
- using modal less frequently
- closing the picker by clicking anywhere
2017-07-20 16:08:25 +02:00
Joffrey JAFFEUX
739794f0cb resets img src before changing it 2017-07-19 23:24:50 +02:00
Joffrey JAFFEUX
26a7ae3750 increase time needed to load section in emoji-picker 2017-07-19 23:20:27 +02:00
Joffrey JAFFEUX
d27f744d16 refactor async code of the emoji-picker 2017-07-19 22:54:58 +02:00
Joffrey JAFFEUX
ce982d9935 enforce that emoji-picker is not active by default 2017-07-19 22:54:57 +02:00
Joffrey JAFFEUX
bb7241ccc2 simplify emoji-picker recent usage logic 2017-07-19 22:54:56 +02:00
Joffrey JAFFEUX
f32950a475 unbind div-resizing event 2017-07-19 22:54:55 +02:00
Joffrey JAFFEUX
bd0607b15b makes emoji-picker position more dynamic 2017-07-19 22:54:55 +02:00
Joffrey JAFFEUX
d238de87a4 FIX: infinite rebinding when filtering emojis 2017-07-19 22:54:53 +02:00
Joffrey JAFFEUX
69a52cca83 improve emoji picker filter style 2017-07-19 22:54:52 +02:00
Joffrey JAFFEUX
a1de26d614 more consistent positioning 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
81c1cc4f22 should be a const 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
33c1ce8d55 better scroll/touch handling on mobiles 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
b3454b535f refactoring 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
4ef52d5e88 correctly hide the picker 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
8d91e7d493 pixel perfect position 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
2322118d4f es-lint 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
c99a5bce8f faster tests 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
b83f430ef0 better positioning on mobile devices 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
8cf7e614d9 move picker at top of the screen on mobile 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
9956a58df0 uses es6 shorthands 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
0b98bfe1dc function is not needed 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
7739b2f53e reduces element search scope 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
d992ef24ce emphasizes it's a jquery object 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
b5c5c9c883 formating 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
6ebdf86ec1 storing scroll position every 100 ms should be enough 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
9a4dcd1a1c es-lint 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
bd0e5b91c0 function is not needed 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
f4c20472d2 refactoring 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
80ff685148 disable modale escape for now 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
60c0b5f0d2 bind hover only on desktop 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
38be969727 do not apply touch start hack on emojis 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
89573e3427 simplifying code 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
03508b72b9 clarification 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
6a4d74d9f8 performance/memory optimizations 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
9664fd7302 fixes es-lint errors 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX
6de258d4cf FEATURE: Introduces new emoji-picker 2017-07-19 16:48:23 +02:00
Guo Xiang Tan
87a1ff15fd Treat URL as loaded when loading script with tag. 2017-07-19 10:25:13 +09:00
Sam
c7b0764089 correct more edge cases with new engine 2017-07-17 17:44:48 -04:00
Sam
8921058c67 FIX: medium URL with @ incorrectly handled as mention
Also:

- remove unused code
- rename bbcode_ruler to bbcode.ruler
- add md.core.textPostProcess.ruler to apply at end of chain (excluding links)
2017-07-17 17:44:48 -04:00
Robin Ward
29d529020b UX: Allow site settings to display as textareas if they like 2017-07-17 16:38:26 -04:00
Robin Ward
cdb3706025 Track clicks on topics in search results 2017-07-17 15:42:32 -04:00
Sam Saffron
d0c5205a52 Feature: Change markdown engine to markdown it
This commit removes the old evilstreak markdownjs engine.

- Adds specs to WhiteLister and changes it to stop using globals
    (Fixes large memory leak)
- Fixes edge cases around bbcode handling
- Removes mdtest which is no longer valid (to be replaced with
    CommonMark)
- Updates MiniRacer to correct minor unmanaged memory leak
- Fixes plugin specs
2017-07-17 11:41:34 -04:00
Guo Xiang Tan
2ddf2e0e95 FIX: Concurently loading deferred loading of a script incorrectly resolves the promise. 2017-07-17 14:41:46 +09:00
Guo Xiang Tan
d613f3f559 Fix guard against concurrently loading of assets. 2017-07-17 13:04:30 +09:00
Guo Xiang Tan
c5401a0927 Log errors when trying to load a markdown-it-bunlde.js. 2017-07-17 11:21:57 +09:00
Sam
79a084dd58 Revert "remove old markdown engine work-in-progress"
This reverts commit ee470b5317.
2017-07-12 18:10:51 -04:00
Sam
bcbb9f208d Revert "Integrate new engine, correct old specs"
This reverts commit f1b38ba4fb.
2017-07-12 18:10:07 -04:00
Sam
d609f8a53c Revert "correct more specs"
This reverts commit 40bcc6bbdc.
2017-07-12 18:10:05 -04:00
Sam
40bcc6bbdc correct more specs 2017-07-12 17:44:40 -04:00
Sam
f1b38ba4fb Integrate new engine, correct old specs
corrects edge cases with

- full quotes
- [url] with nested tags
- engine overrides
- onebox applying to non http srcs
2017-07-12 17:44:40 -04:00
Sam Saffron
ee470b5317 remove old markdown engine work-in-progress 2017-07-12 17:44:40 -04:00
Arpit Jalan
76981605fa FIX: don't raise error when inviting existing user to private topic via email
https://meta.discourse.org/t/inviting-existing-user-to-a-private-topic-message-via-email-shows-error-message/65994
2017-07-12 21:51:21 +05:30
Sam
98e03b04b5 Don't depend on imports for md extensions 2017-07-11 16:48:25 -04:00
Sam
5d139e461c FIX: multi option poll not working (new engine) 2017-07-11 14:43:34 -04:00
Sam
3f950a756a FEATURE: support image dimensions via Markdown image 2017-07-11 12:13:03 -04:00
Robin Ward
1163c086a3 FIX: Missing model binding 2017-07-11 11:19:49 -04:00
Arpit Jalan
3fb1c21dd5 Fix the build. 2017-07-11 19:26:33 +05:30
Sam
9840e4285d Merge pull request #4962 from nbianca/add_composer_events
Added events to show and hide the preview pane.
2017-07-11 08:26:25 -04:00
Guo Xiang Tan
31932813b7 FIX: Wait for CSS transition to end before attempting to focus.
https://meta.discourse.org/t/tab-should-work-after-edit-title-or-using-hotkeys/65792
2017-07-11 15:26:57 +09:00
Guo Xiang Tan
3ff9133f85 FIX: Only trigger callback for parent transition events.
* This fixes a bug where multiple requests were being
  made to the server whenever the composer is opened.
2017-07-11 15:09:22 +09:00
Bianca Nenciu
375eb290b9 Made changes as per review. 2017-07-10 23:28:35 +01:00
Bianca Nenciu
1e7f0fd8f1 Added events to show and hide the preview pane. 2017-07-10 20:23:56 +01:00
Robin Ward
31f7640335 FIX: Allow discourse app to link directly to wizard 2017-07-10 14:31:58 -04:00
Robin Ward
dcdd5baf54 FIX: Only show search if there are more total posts than the chunk size 2017-07-10 13:46:50 -04:00
Sam
ba9898c5a9 FIX: smarter newline handling for <img> tags on line alone
Run all of pretty text spec on new engine
2017-07-10 12:22:15 -04:00
Sam
9fb180f839 we don't want that console.log 2017-07-07 16:38:52 -04:00
Sam
6f09df0deb FIX: don't create tags autolinks inside links (new engine) 2017-07-07 13:04:25 -04:00
Sam
436b894f7a FIX: mention not working after a newline (new engine) 2017-07-07 11:06:50 -04:00
Robin Ward
fa2eb8dab1 UX: Reply button was offset improperly when anonymous 2017-07-06 15:05:45 -04:00
Guo Xiang Tan
b49579d9a7 FIX: Disable topic status info when no category has been selected. 2017-07-06 17:08:29 +09:00
Guo Xiang Tan
f6491ee125 FIX: Select topic timer's category by default in edit modal. 2017-07-06 16:01:57 +09:00
Robin Ward
c53eeaaa68 REFACTOR: Remove requirejs calls 2017-07-05 17:24:27 -04:00
Robin Ward
754c1e5438 Upgrade to Babel 6 2017-07-05 15:25:23 -04:00
Joffrey JAFFEUX
fcc50edeef FIX: do not override 🦗 with :cricket_bat_and_ball: 2017-07-05 18:51:25 +02:00
Joffrey JAFFEUX
76a55fd138 FIX: adds new emojis into correct groups 2017-07-05 16:24:53 +02:00
Robin Ward
df213639f1 UX: Allow CTRL+ENTER to save topic title edits 2017-07-04 14:23:57 -04:00
Robin Ward
35ff5d6796 FIX: Naving to root URL was broken 2017-07-04 12:44:53 -04:00
Sam
d2ba543ed3 correct case where %20 decoded as space in auto link
correct case where onebox is not applied when url is decoded
2017-07-03 16:32:53 -04:00
Sam
45c3ad5f91 FIX: stop highlighting single l which is used for sorting 2017-07-03 15:45:15 -04:00
Sam
845170bd6b FEATURE: add support for group visibility level
There are 4 visibility levels

- public (default)
- members only
- staff
- owners

Note, admins and group owners ALWAYS have visibility to groups

Migration treated old "non public" as "members only"
2017-07-03 15:26:57 -04:00
Arpit Jalan
4fb9269642 FEATURE: optimize invite js code 2017-07-01 19:11:39 +05:30
Robin Ward
566cf31c66 UX: Always show topic progress on mobile 2017-06-30 16:19:19 -04:00
Sam
0650c8dbab optimize rule lookup
we have tons of bbcode rules, might as well speed them up
2017-06-30 15:19:16 -04:00
Sam
a55e679563 support wrap function in bbcode rules 2017-06-30 12:21:01 -04:00
Sam
ca40c1725c add support for a wrap function in bbcode replace 2017-06-29 16:43:57 -04:00
Sam
d941ed90d6 support for bbcode [code] blocks 2017-06-29 16:04:10 -04:00
Sam
de50d8cd35 Support for [email] [url] [img] bbcodes 2017-06-29 14:00:09 -04:00
Arpit Jalan
e7b9b1312e FEATURE: remove all invites
https://meta.discourse.org/t/remove-all-invitations-button-for-the-admin-panel/65207
2017-06-29 22:30:10 +05:30
Sam
c6b83f4714 Correct logic so hashtags are properly ignored in links 2017-06-29 12:48:20 -04:00
Robin Ward
6ff7bf7505 REFACTOR: Use component for cook-text to improve async workflow 2017-06-29 12:14:27 -04:00
Régis Hanol
e12601b850 Merge pull request #4946 from jjaffeux/emoji-picker-fixes
Emoji picker fixes
2017-06-29 00:30:55 +02:00
Joffrey JAFFEUX
65fd92b991 Fixes glitch on iOS safari 2017-06-29 00:27:16 +02:00
Joffrey JAFFEUX
6e1a06d07f Uses es6 object literal shorthand 2017-06-29 00:27:02 +02:00
Robin Ward
25cecd5d25 FIX: Topic Entrance wasn't showing up on some suggested topics 2017-06-28 17:38:01 -04:00
Guo Xiang Tan
ad4694cdcd Revert "FIX: Can't cook queued posts when markdown-it is enabled."
This reverts commit 5ff563cddd.
2017-06-29 06:14:36 +09:00
Robin Ward
284570a5ae FIX: Don't show the admin menu if the progress bar is hidden 2017-06-28 16:31:55 -04:00
Sam
0e391a72a1 use custom whitelister for tables 2017-06-28 16:08:29 -04:00
Robin Ward
f7b686117b UX: Add a span to d-button so text can be hidden via CSS 2017-06-28 15:46:09 -04:00
Robin Ward
f6222ff225 FIX: Populate the Email Digest preview with the current username 2017-06-28 15:38:57 -04:00
Sam
6200d7d6ab correct bug where only a single poll per topic worked 2017-06-28 15:36:19 -04:00
Sam
cfbda863e8 implement unicode emoji replacements 2017-06-28 13:47:30 -04:00
Sam
301731ef24 make cook-text async friendly 2017-06-28 11:29:34 -04:00
Joffrey JAFFEUX
560dfe74af Adds support for skin tones in emoji picker 2017-06-28 15:07:05 +02:00
Guo Xiang Tan
a2349b99b6 FIX: Plugin outlet should be wrapped under d-editor-preview-wrapper. 2017-06-28 17:52:38 +09:00
Régis Hanol
173307de10 Merge pull request #4944 from nbianca/preview_plugin_outlet
Removed useless element (div).
2017-06-28 10:14:38 +02:00
Bianca Nenciu
2bf8b5706f Removed useless element (div).
{{plugin-outlet}} already wraps everything.
2017-06-28 11:04:41 +03:00
Sam
d4dbcca91b Merge pull request #4942 from nbianca/preview_plugin_outlet
Added plugin outlet near editor's preview.
2017-06-27 17:34:31 -04:00
Sam
4c5109ff5b FEATURE: site setting for Markdown typographer
It ships anyway with markdown.it so we might as well expose it
2017-06-27 16:50:13 -04:00
Sam
0d62420cbe Space prior to onebox stops onebox resolution 2017-06-27 16:16:17 -04:00
Sam
232de90607 explicit autolink should not be oneboxed 2017-06-27 15:34:16 -04:00
Sam
91a91d57f0 FIX: when quoting always ensure we are on a new line 2017-06-27 13:59:17 -04:00
Sam
e2f57a154b FIX: blockquote button implementation
Previously clicking on blockquote in the middle of sentence
would result in incorrect formatting
2017-06-27 13:32:20 -04:00
Sam
0e0092d738 corrected a parsing edge cases for bbcode blocks 2017-06-27 10:07:06 -04:00
Jeff Atwood
38950cdc10 add missing span tags to new topic btn 2017-06-27 02:47:10 -07:00
Arpit Jalan
70781749cd UX: add unique class to "most liked" section on user summary page 2017-06-27 14:49:52 +05:30
Guo Xiang Tan
5ff563cddd FIX: Can't cook queued posts when markdown-it is enabled. 2017-06-27 12:24:52 +09:00
Robin Ward
10358811a1 UX: Don't hide the reply button by default 2017-06-26 17:35:28 -04:00
Sam
21f7ac1f25 correct spec, require closing tag for bbcode blocks 2017-06-26 16:51:55 -04:00
Sam
8967d50dc2 Clean up sanitization code
- remove html table test, this is soon to be deprecated
- move sanitization tests into pretty text.rb
- fix up whitelister so it makes a copy of options
2017-06-26 15:21:47 -04:00
Robin Ward
4f27259e27 UX: Make the edit wiki button more prominent 2017-06-26 14:34:59 -04:00
Sam
e9f55adb3a FEATURE: add table support 2017-06-26 13:25:05 -04:00
Sam
df5ee0cfc1 correct onebox rendering so it fills in cached
the onebox plugin needs to pull in the actual cached onebox
and bypass the whitelister for onebox content
2017-06-26 13:09:58 -04:00
Sam
81eb3218b2 FEATURE: used strict sanitizer by default
This amends it so sanitize always uses the most strict sanitizer
by default, if it needs to be "widened" to use more options then
you need to pass it more options.
2017-06-26 11:27:30 -04:00
Bianca Nenciu
81dc1f039d Added plugin outlet near editor's preview. 2017-06-26 12:13:27 +03:00
Sam
da5ccd2000 correctly hunt for console.log 2017-06-23 15:24:20 -04:00
Robin Ward
34867a6e07 UX: Support for displaying wrench alongside progress bar 2017-06-23 14:39:18 -04:00
Sam
814c8804d4 correct text highlighting for no highlight 2017-06-23 14:35:46 -04:00
Sam
05e5a740a6 FEATURE: consistent bbcode inline and block rulers 2017-06-23 12:01:33 -04:00
Sam
234694b50f Feature: CommonMark support
This adds the markdown.it engine to Discourse.
https://github.com/markdown-it/markdown-it

As the migration is going to take a while the new engine is default
disabled. To enable it you must change the hidden site setting:
enable_experimental_markdown_it.

This commit is a squash of many other commits, it also includes some
improvements to autospec (ability to run plugins), and a dev dependency
on the og gem for html normalization.
2017-06-23 12:01:33 -04:00
Sam
6048ca2b7d Merge pull request #4941 from jjaffeux/emoji-ordering
Emoji ordering
2017-06-23 12:00:16 -04:00