7 Commits

Author	SHA1	Message	Date
Régis Hanol	0559a4736a	FIX: don't double request when downloading a file	2018-02-24 12:35:57 +01:00
Sam	8ecf313a81	FIX: correctly raise errors when downloads fail ... This corrects an issue where we are hitting Gravatar for 404 over and over Also ensures file download properly reports errors	2017-09-28 16:35:43 +10:00
Guo Xiang Tan	56f98de7b2	Use webmock to stub external web requests.	2017-05-26 15:19:09 +08:00
Guo Xiang Tan	04016f0dec	Support Ruby 2.4.	2017-04-15 12:29:00 +08:00
Andy Waite	3e50313fdc	Prepare for separation of RSpec helper files ... Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.	2015-12-01 20:39:42 +00:00
Luciano Sousa	b3d769ff4f	Update rspec syntax to v3 ... update rspec syntax to v3 change syntax to rspec v3 oops. fix typo mailers classes with rspec3 syntax helpers with rspec3 syntax jobs with rspec3 syntax serializers with rspec3 syntax views with rspec3 syntax support to rspec3 syntax category spec with rspec3 syntax	2015-01-05 11:59:30 -03:00
Régis Hanol	521226f4c9	FIX: registration fails with timeout on gravatar	2014-12-15 22:10:27 +01:00