Daniel Waterworth
5af63def61
Prefabricate group at the top level
2019-05-07 08:38:55 -04:00
Daniel Waterworth
df63080bca
Prefabricate staff_post at the top level
2019-05-07 08:38:55 -04:00
Daniel Waterworth
db64bee0c4
Use prefabricated user
2019-05-07 08:38:55 -04:00
Daniel Waterworth
30676e8a56
Brought prefabrication of another_user to the top level
2019-05-07 08:38:55 -04:00
Daniel Waterworth
2c7ed7b848
Use prefabricated admin instead of creating new ones
2019-05-07 08:38:55 -04:00
Daniel Waterworth
2f706be43a
Reuse prefabricated moderator instead of creating new ones
2019-05-07 08:38:55 -04:00
Daniel Waterworth
16c7b86c86
Use prefabricated user and moderator
2019-05-07 08:38:55 -04:00
Daniel Waterworth
7472f15368
Prefabricate evil_trout
2019-05-07 08:36:29 -04:00
Daniel Waterworth
d3769fff95
Prefabricate admin
2019-05-07 08:36:29 -04:00
Daniel Waterworth
d0c7e3469d
Prefabricated more things
2019-05-07 08:36:29 -04:00
Robin Ward
c403569895
Remove unused translation keys
...
cc @gschlager
2019-05-07 08:27:30 -04:00
Arpit Jalan
ed70595314
UX: add information about the use of permalinks
2019-05-07 17:13:26 +05:30
Vinoth Kannan
f5a217be92
Fix typo in condition value.
2019-05-07 17:09:08 +05:30
Bianca Nenciu
71fb8a4195
DEV: Fix failing click-track tests.
2019-05-07 13:54:12 +03:00
Joffrey JAFFEUX
4bbb34f7cb
REFACTOR: admin-user ( #7475 )
2019-05-07 10:53:21 +02:00
Joffrey JAFFEUX
f73ed45429
REFACTOR: color-scheme model ( #7477 )
2019-05-07 10:51:52 +02:00
Joffrey JAFFEUX
9507eff927
REFACTOR: resumable-upload ( #7474 )
2019-05-07 10:51:11 +02:00
Joffrey JAFFEUX
c487dff776
early preview of new emojis ( #7486 )
2019-05-07 10:49:15 +02:00
Bianca Nenciu
4696be4c19
DEV: Fix failling test.
2019-05-07 11:19:13 +03:00
Guo Xiang Tan
2adbec1b3c
PERF: Speed up migrate_to_s3 rake task by deleting optimized image record.
...
No point moving all optimized image files to tombstone when the store is
changing. Also, `destroy_all` can easily blow memory since we are no
loading in batches.
2019-05-07 16:10:32 +08:00
Sam Saffron
e4abc51866
DEV: avoid using send when we can simply call the method
2019-05-07 16:50:45 +10:00
Bianca Nenciu
4ff1195537
FEATURE: Use Beacon API for tracking clicks. ( #7483 )
2019-05-07 16:37:43 +10:00
Roman Rizzi
9adfd66a8b
Revert "FIX: When mutating a string to build a diff. Duplicate it first ( #7482 )" ( #7484 )
...
This reverts commit 20d4093a67
2019-05-07 16:36:23 +10:00
Joe
cf99431c18
Fix like and flag button count alignment ( #7487 )
2019-05-07 16:34:29 +10:00
Guo Xiang Tan
abbc639e0d
FIX: Only unregister service workers that belongs to Discourse.
2019-05-07 13:08:06 +08:00
Arpit Jalan
03169401ff
UX: correct order of site statistics on /about page
2019-05-07 09:50:41 +05:30
Daniel Waterworth
e219588142
DEV: Prefabrication (test optimization) ( #7414 )
...
* Introduced fab!, a helper that creates database state for a group
It's almost identical to let_it_be, except:
1. It creates a new object for each test by default,
2. You can disable it using PREFABRICATION=0
2019-05-07 13:12:20 +10:00
Guo Xiang Tan
329969ea20
FIX: Discobot mention tutorial should be case insensitive.
2019-05-07 10:54:22 +08:00
Sam Saffron
e2bcf55077
DEV: move send => public_send in lib folder
...
This handles most of the cases in `lib` where we were using send instead
of public_send
2019-05-07 12:25:44 +10:00
Guo Xiang Tan
451f7842ff
DEV: More send -> public_send.
2019-05-07 10:05:58 +08:00
Sam Saffron
cac80cdc3b
DEV: more send -> public_send changes
...
This is a work in progress commit for more send to public_send conversions
Also adds some comments for cases where we need to keep send
2019-05-07 11:58:06 +10:00
Guo Xiang Tan
61cc0f8c5f
Follow up to 152238b4cf.
2019-05-07 09:57:27 +08:00
Guo Xiang Tan
1e7c4592dc
Fix rebase fail in 152238b4cf.
2019-05-07 09:46:07 +08:00
Guo Xiang Tan
152238b4cf
DEV: Prefer public_send over send.
2019-05-07 09:33:21 +08:00
Sam Saffron
9be70a22cd
DEV: introduce new API to look up dynamic site setting
...
This removes all uses of both `send` and `public_send` from consumers of
SiteSetting and instead introduces a `get` helper for dynamic lookup
This leads to much cleaner and safer code long term as we are always explicit
to test that a site setting is really there before sending an arbitrary
string to the class
It also removes a couple of risky stubs from the auth provider test
2019-05-07 11:00:30 +10:00
Robin Ward
47995d2d89
FIX: Your own likes were missing on posts
2019-05-06 20:03:50 -04:00
Sam Saffron
20f84a364b
Correct regression, correctly raise exception when setting incorrect param
2019-05-07 09:48:14 +10:00
Sam Saffron
c8418595bf
SECURITY: avoid use of send in favor of public_send
2019-05-07 09:41:05 +10:00
Robin Ward
e9564c999f
FIX: We just show likes to see like count
2019-05-06 18:19:45 -04:00
Robin Ward
310e196aca
FIX: like-count has been removed from the post menu
2019-05-06 17:48:57 -04:00
Robin Ward
18d742d334
FIX: Broken spec
2019-05-06 17:09:08 -04:00
Robin Ward
31e100530f
FEATURE: Flag count in post menu
...
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.
We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
2019-05-06 16:13:31 -04:00
Neil Lalonde
e6843afa9e
FIX: don't send post edit notification when hidden tags are changed
2019-05-06 15:45:06 -04:00
Neil Lalonde
5de750d373
FIX: don't bump topics when hidden tags are added or removed
2019-05-06 14:52:18 -04:00
Bianca Nenciu
39260c841e
DEV: Add test for click-track and mention links.
...
Follow-up to b81d169e
2019-05-06 19:29:51 +03:00
Bianca Nenciu
233d3f611b
DEV: Fix test.
2019-05-06 19:29:51 +03:00
Roman Rizzi
20d4093a67
FIX: When mutating a string to build a diff. Duplicate it first ( #7482 )
2019-05-06 13:20:10 -03:00
Bianca Nenciu
e67ba8517d
DEV: Add test for click-track and <a> without href.
...
Follow-up to b9339e15
2019-05-06 18:38:57 +03:00
Penar Musaraj
5e546ba7d1
Standardize viewport rules for mobile and desktop
...
Also removes`maximum-scale` on non-mobile devices, better for accessibility.
2019-05-06 10:28:29 -04:00
Régis Hanol
e2e72f4e8e
DEV: rename ReadOnly module to ReadOnlyHeader
2019-05-06 16:07:49 +02:00
